| Message ID | 20230222120023.3004624-2-burzalodowa@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | x86/hvm: {svm,vmx}.{c,h} cleanup | expand |
On 22.02.2023 13:00, Xenia Ragiadakou wrote: > Remove forward declaration of struct vcpu, that is a leftover since > the removal of svm_update_guest_cr()'s declaration from svm.h. > > Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Acked-by: Jan Beulich <jbeulich@suse.com> > Fixes: b158e72abe30 ("x86/hvm: CFI hardening for hvm_funcs") I'm a little puzzled by this (a stray forward decl of a struct isn't really a bug imo), but ... > --- > > Changes in v2: > - leave the forward declaration of struct cpu_user_regs in place, > suggested by Andrew > - add a fixes tag based on Andrew's comment ... I realize you were asked to add it. (As a minor remark, more commonly the Fixes: tag would come ahead of the S-o-b: one, I think.) Jan
On 22/02/2023 12:59 pm, Jan Beulich wrote: > On 22.02.2023 13:00, Xenia Ragiadakou wrote: >> Remove forward declaration of struct vcpu, that is a leftover since >> the removal of svm_update_guest_cr()'s declaration from svm.h. >> >> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> > Acked-by: Jan Beulich <jbeulich@suse.com> > >> Fixes: b158e72abe30 ("x86/hvm: CFI hardening for hvm_funcs") > I'm a little puzzled by this (a stray forward decl of a struct isn't > really a bug imo), but ... >> --- >> >> Changes in v2: >> - leave the forward declaration of struct cpu_user_regs in place, >> suggested by Andrew >> - add a fixes tag based on Andrew's comment > ... I realize you were asked to add it. (As a minor remark, more > commonly the Fixes: tag would come ahead of the S-o-b: one, I think.) I didn't intend my reply to mean "put in a fixes tag". I was just trying to make an observation. But it doesn't hurt either. But I do agree that a Fixes tag ought to be ahead of a SoB tag. Where possible, we put tags in chronological order. I can fix that on commit. ~Andrew
On 2/23/23 12:50, Andrew Cooper wrote: > On 22/02/2023 12:59 pm, Jan Beulich wrote: >> On 22.02.2023 13:00, Xenia Ragiadakou wrote: >>> Remove forward declaration of struct vcpu, that is a leftover since >>> the removal of svm_update_guest_cr()'s declaration from svm.h. >>> >>> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> >> Acked-by: Jan Beulich <jbeulich@suse.com> >> >>> Fixes: b158e72abe30 ("x86/hvm: CFI hardening for hvm_funcs") >> I'm a little puzzled by this (a stray forward decl of a struct isn't >> really a bug imo), but ... >>> --- >>> >>> Changes in v2: >>> - leave the forward declaration of struct cpu_user_regs in place, >>> suggested by Andrew >>> - add a fixes tag based on Andrew's comment >> ... I realize you were asked to add it. (As a minor remark, more >> commonly the Fixes: tag would come ahead of the S-o-b: one, I think.) > > I didn't intend my reply to mean "put in a fixes tag". I was just > trying to make an observation. But it doesn't hurt either. > > But I do agree that a Fixes tag ought to be ahead of a SoB tag. Where > possible, we put tags in chronological order. > > I can fix that on commit. Thanks. I ve added it just for reference. It s ok to remove it. > > ~Andrew
diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h index 65e35a4f59..fa39d4d76a 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svm.h +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h @@ -46,7 +46,6 @@ static inline void svm_invlpga(unsigned long linear, uint32_t asid) } struct cpu_user_regs; -struct vcpu; unsigned long *svm_msrbit(unsigned long *msr_bitmap, uint32_t msr); void __update_guest_eip(struct cpu_user_regs *regs, unsigned int inst_len);
Remove forward declaration of struct vcpu, that is a leftover since the removal of svm_update_guest_cr()'s declaration from svm.h. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Fixes: b158e72abe30 ("x86/hvm: CFI hardening for hvm_funcs") --- Changes in v2: - leave the forward declaration of struct cpu_user_regs in place, suggested by Andrew - add a fixes tag based on Andrew's comment - update commit message xen/arch/x86/include/asm/hvm/svm/svm.h | 1 - 1 file changed, 1 deletion(-)