| Message ID | 20230223-topic-gmuwrapper-v3-10-5be55a336819@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | GMU-less A6xx support (A610, A619_holi) | expand |
On Thu, 23 Feb 2023 at 14:07, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > According to the vendor sources, it's equal to 16, which makes hbb_lo > equal to 3. I think we might be stricken with the ddr kind difference here, but I would not bet on it. > > Fixes: 840d10b64dad ("drm: msm: Add 680 gpu to the adreno gpu list") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index b5017c56fa1b..2c4afecdd213 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -885,12 +885,18 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) > hbb_lo = 2; > } > > - if (adreno_is_a640_family(adreno_gpu)) { > + if (adreno_is_a640(adreno_gpu)) { > amsbc = 1; > /* HBB = 15 */ > hbb_lo = 2; > } > > + if (adreno_is_a680(adreno_gpu)) { > + amsbc = 1; > + /* HBB = 16 */ > + hbb_lo = 3; > + } > + > if (adreno_is_a650(adreno_gpu) || adreno_is_a660(adreno_gpu)) { > amsbc = 1; > /* TODO: get ddr type from bootloader and use 2 for LPDDR4 */ > > -- > 2.39.2 >
On 23.02.2023 14:06, Dmitry Baryshkov wrote: > On Thu, 23 Feb 2023 at 14:07, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> According to the vendor sources, it's equal to 16, which makes hbb_lo >> equal to 3. > > I think we might be stricken with the ddr kind difference here, but I > would not bet on it. It totally is, but it also seems to be SoC-dependent.. I think all 8180x devices shipped with LPDDR4X FWIW Konrad > >> >> Fixes: 840d10b64dad ("drm: msm: Add 680 gpu to the adreno gpu list") >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> index b5017c56fa1b..2c4afecdd213 100644 >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >> @@ -885,12 +885,18 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) >> hbb_lo = 2; >> } >> >> - if (adreno_is_a640_family(adreno_gpu)) { >> + if (adreno_is_a640(adreno_gpu)) { >> amsbc = 1; >> /* HBB = 15 */ >> hbb_lo = 2; >> } >> >> + if (adreno_is_a680(adreno_gpu)) { >> + amsbc = 1; >> + /* HBB = 16 */ >> + hbb_lo = 3; >> + } >> + >> if (adreno_is_a650(adreno_gpu) || adreno_is_a660(adreno_gpu)) { >> amsbc = 1; >> /* TODO: get ddr type from bootloader and use 2 for LPDDR4 */ >> >> -- >> 2.39.2 >> > >
On Thu, 23 Feb 2023 at 15:49, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > On 23.02.2023 14:06, Dmitry Baryshkov wrote: > > On Thu, 23 Feb 2023 at 14:07, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > >> > >> According to the vendor sources, it's equal to 16, which makes hbb_lo > >> equal to 3. > > > > I think we might be stricken with the ddr kind difference here, but I > > would not bet on it. > It totally is, but it also seems to be SoC-dependent.. > I think all 8180x devices shipped with LPDDR4X FWIW I think so too. However sdmshrike dts uses LPDDR5. > > Konrad > > > >> > >> Fixes: 840d10b64dad ("drm: msm: Add 680 gpu to the adreno gpu list") > >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > >> --- > >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 +++++++- > >> 1 file changed, 7 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > >> index b5017c56fa1b..2c4afecdd213 100644 > >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > >> @@ -885,12 +885,18 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) > >> hbb_lo = 2; > >> } > >> > >> - if (adreno_is_a640_family(adreno_gpu)) { > >> + if (adreno_is_a640(adreno_gpu)) { > >> amsbc = 1; > >> /* HBB = 15 */ > >> hbb_lo = 2; > >> } > >> > >> + if (adreno_is_a680(adreno_gpu)) { > >> + amsbc = 1; > >> + /* HBB = 16 */ > >> + hbb_lo = 3; > >> + } > >> + > >> if (adreno_is_a650(adreno_gpu) || adreno_is_a660(adreno_gpu)) { > >> amsbc = 1; > >> /* TODO: get ddr type from bootloader and use 2 for LPDDR4 */ > >> > >> -- > >> 2.39.2 > >> > > > >
On 23.02.2023 15:48, Dmitry Baryshkov wrote: > On Thu, 23 Feb 2023 at 15:49, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> >> >> On 23.02.2023 14:06, Dmitry Baryshkov wrote: >>> On Thu, 23 Feb 2023 at 14:07, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >>>> >>>> According to the vendor sources, it's equal to 16, which makes hbb_lo >>>> equal to 3. >>> >>> I think we might be stricken with the ddr kind difference here, but I >>> would not bet on it. >> It totally is, but it also seems to be SoC-dependent.. >> I think all 8180x devices shipped with LPDDR4X FWIW > > I think so too. However sdmshrike dts uses LPDDR5. Yeah.. it may be better to skip this patch; it should be possible to apply this series without this one. Konrad > >> >> Konrad >>> >>>> >>>> Fixes: 840d10b64dad ("drm: msm: Add 680 gpu to the adreno gpu list") >>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>>> --- >>>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>>> index b5017c56fa1b..2c4afecdd213 100644 >>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c >>>> @@ -885,12 +885,18 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) >>>> hbb_lo = 2; >>>> } >>>> >>>> - if (adreno_is_a640_family(adreno_gpu)) { >>>> + if (adreno_is_a640(adreno_gpu)) { >>>> amsbc = 1; >>>> /* HBB = 15 */ >>>> hbb_lo = 2; >>>> } >>>> >>>> + if (adreno_is_a680(adreno_gpu)) { >>>> + amsbc = 1; >>>> + /* HBB = 16 */ >>>> + hbb_lo = 3; >>>> + } >>>> + >>>> if (adreno_is_a650(adreno_gpu) || adreno_is_a660(adreno_gpu)) { >>>> amsbc = 1; >>>> /* TODO: get ddr type from bootloader and use 2 for LPDDR4 */ >>>> >>>> -- >>>> 2.39.2 >>>> >>> >>> > > >
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index b5017c56fa1b..2c4afecdd213 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -885,12 +885,18 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) hbb_lo = 2; } - if (adreno_is_a640_family(adreno_gpu)) { + if (adreno_is_a640(adreno_gpu)) { amsbc = 1; /* HBB = 15 */ hbb_lo = 2; } + if (adreno_is_a680(adreno_gpu)) { + amsbc = 1; + /* HBB = 16 */ + hbb_lo = 3; + } + if (adreno_is_a650(adreno_gpu) || adreno_is_a660(adreno_gpu)) { amsbc = 1; /* TODO: get ddr type from bootloader and use 2 for LPDDR4 */
According to the vendor sources, it's equal to 16, which makes hbb_lo equal to 3. Fixes: 840d10b64dad ("drm: msm: Add 680 gpu to the adreno gpu list") Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)