diff mbox series

wifi: ath12k: remove memset with byte count of 278528

Message ID 20230222164014.860-1-kvalo@kernel.org (mailing list archive)
State Accepted
Commit 28013c35629647679e10cb1bbf36c3feec2af756
Delegated to: Kalle Valo
Headers show
Series wifi: ath12k: remove memset with byte count of 278528 | expand

Commit Message

Kalle Valo Feb. 22, 2023, 4:40 p.m. UTC 
From: Kalle Valo <quic_kvalo@quicinc.com>

Sparse warns:

drivers/net/wireless/ath/ath12k/dp.c:1471:15: warning: memset with byte count of 278528

There's no need to use memset() here, instead call dma_alloc_coherent() with __GFP_ZERO.

While at it, remove an extra line before the error handler.

Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
---
 drivers/net/wireless/ath/ath12k/dp.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)


base-commit: 5aa9ff08c0b71be15a607341fa5344546e19ceb2

Comments

Kalle Valo Feb. 24, 2023, 10:23 a.m. UTC | #1 
Kalle Valo <kvalo@kernel.org> wrote:

> Sparse warns:
> 
> drivers/net/wireless/ath/ath12k/dp.c:1471:15: warning: memset with byte count of 278528
> 
> There's no need to use memset() here, instead call dma_alloc_coherent() with __GFP_ZERO.
> 
> While at it, remove an extra line before the error handler.
> 
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

28013c356296 wifi: ath12k: remove memset with byte count of 278528
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c
index 9926d81c5fe4..ae1645d0f42a 100644
--- a/drivers/net/wireless/ath/ath12k/dp.c
+++ b/drivers/net/wireless/ath/ath12k/dp.c
@@ -1461,15 +1461,12 @@  static int ath12k_dp_reoq_lut_setup(struct ath12k_base *ab)
 	dp->reoq_lut.vaddr = dma_alloc_coherent(ab->dev,
 						DP_REOQ_LUT_SIZE,
 						&dp->reoq_lut.paddr,
-						GFP_KERNEL);
-
+						GFP_KERNEL | __GFP_ZERO);
 	if (!dp->reoq_lut.vaddr) {
 		ath12k_warn(ab, "failed to allocate memory for reoq table");
 		return -ENOMEM;
 	}
 
-	memset(dp->reoq_lut.vaddr, 0, DP_REOQ_LUT_SIZE);
-
 	ath12k_hif_write32(ab, HAL_SEQ_WCSS_UMAC_REO_REG + HAL_REO1_QDESC_LUT_BASE0(ab),
 			   dp->reoq_lut.paddr);
 	return 0;