| Message ID | 20230223-asoc-mt8192-quick-fixes-v1-4-9a85f90368e1@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ce40d93b062c0bdcd29218c12ab1dba544382dd8 |
| Headers | show |
| Series | ASoC: mt8192: Fixes from initial glance at kselftest run | expand |
On Fri, Feb 24, 2023 at 02:03:58PM +0000, Mark Brown wrote: > The Sidetone_Positive_Gain_dB control reports a range of 0..100 as valid > but the put() function rejects anything larger than 24. Fix this. > > There are numerous other problems with this control, the name is very non > idiomatic and it should be a TLV, but it's ABI so probably we should leave > those alone. > > Signed-off-by: Mark Brown <broonie@kernel.org> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas
Il 24/02/23 15:03, Mark Brown ha scritto: > The Sidetone_Positive_Gain_dB control reports a range of 0..100 as valid > but the put() function rejects anything larger than 24. Fix this. > > There are numerous other problems with this control, the name is very non > idiomatic and it should be a TLV, but it's ABI so probably we should leave > those alone. > > Signed-off-by: Mark Brown <broonie@kernel.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff --git a/sound/soc/mediatek/mt8192/mt8192-dai-adda.c b/sound/soc/mediatek/mt8192/mt8192-dai-adda.c index a02a297c0450..4919535e2759 100644 --- a/sound/soc/mediatek/mt8192/mt8192-dai-adda.c +++ b/sound/soc/mediatek/mt8192/mt8192-dai-adda.c @@ -670,7 +670,7 @@ static int mt8192_adda6_only_set(struct snd_kcontrol *kcontrol, static const struct snd_kcontrol_new mtk_adda_controls[] = { SOC_SINGLE("Sidetone_Gain", AFE_SIDETONE_GAIN, SIDE_TONE_GAIN_SFT, SIDE_TONE_GAIN_MASK, 0), - SOC_SINGLE_EXT("Sidetone_Positive_Gain_dB", SND_SOC_NOPM, 0, 100, 0, + SOC_SINGLE_EXT("Sidetone_Positive_Gain_dB", SND_SOC_NOPM, 0, 24, 0, stf_positive_gain_get, stf_positive_gain_set), SOC_SINGLE("ADDA_DL_GAIN", AFE_ADDA_DL_SRC2_CON1, DL_2_GAIN_CTL_PRE_SFT, DL_2_GAIN_CTL_PRE_MASK, 0),
The Sidetone_Positive_Gain_dB control reports a range of 0..100 as valid but the put() function rejects anything larger than 24. Fix this. There are numerous other problems with this control, the name is very non idiomatic and it should be a TLV, but it's ABI so probably we should leave those alone. Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/mediatek/mt8192/mt8192-dai-adda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)