| Message ID | 20230104211448.4804-1-vishal.moola@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Convert to filemap_get_folios_tag() | expand |
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Andrew Morton <akpm@linux-foundation.org>: On Wed, 4 Jan 2023 13:14:25 -0800 you wrote: > This patch series replaces find_get_pages_range_tag() with > filemap_get_folios_tag(). This also allows the removal of multiple > calls to compound_head() throughout. > It also makes a good chunk of the straightforward conversions to folios, > and takes the opportunity to introduce a function that grabs a folio > from the pagecache. > > [...] Here is the summary with links: - [f2fs-dev,v5,01/23] pagemap: Add filemap_grab_folio() https://git.kernel.org/jaegeuk/f2fs/c/ee7a5906ff08 - [f2fs-dev,v5,02/23] filemap: Added filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/247f9e1feef4 - [f2fs-dev,v5,03/23] filemap: Convert __filemap_fdatawait_range() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/6817ef514e1a - [f2fs-dev,v5,04/23] page-writeback: Convert write_cache_pages() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/0fff435f060c - [f2fs-dev,v5,05/23] afs: Convert afs_writepages_region() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/acc8d8588cb7 - [f2fs-dev,v5,06/23] btrfs: Convert btree_write_cache_pages() to use filemap_get_folio_tag() https://git.kernel.org/jaegeuk/f2fs/c/51c5cd3bafe5 - [f2fs-dev,v5,07/23] btrfs: Convert extent_write_cache_pages() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/9f50fd2e92e3 - [f2fs-dev,v5,08/23] ceph: Convert ceph_writepages_start() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/590a2b5f0a9b - [f2fs-dev,v5,09/23] cifs: Convert wdata_alloc_and_fillpages() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/4cda80f3a7a5 - [f2fs-dev,v5,10/23] ext4: Convert mpage_prepare_extent_to_map() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/50ead2537441 - [f2fs-dev,v5,11/23] f2fs: Convert f2fs_fsync_node_pages() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/e6e46e1eb7ce - [f2fs-dev,v5,12/23] f2fs: Convert f2fs_flush_inline_data() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/a40a4ad1186a - [f2fs-dev,v5,13/23] f2fs: Convert f2fs_sync_node_pages() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/7525486affa5 - [f2fs-dev,v5,14/23] f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/1cd98ee747cf - [f2fs-dev,v5,15/23] f2fs: Convert last_fsync_dnode() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/4f4a4f0febe6 - [f2fs-dev,v5,16/23] f2fs: Convert f2fs_sync_meta_pages() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/580e7a492608 - [f2fs-dev,v5,17/23] gfs2: Convert gfs2_write_cache_jdata() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/87ed37e66dfd - [f2fs-dev,v5,18/23] nilfs2: Convert nilfs_lookup_dirty_data_buffers() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/5ee4b25cb730 - [f2fs-dev,v5,19/23] nilfs2: Convert nilfs_lookup_dirty_node_buffers() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/a24586583169 - [f2fs-dev,v5,20/23] nilfs2: Convert nilfs_btree_lookup_dirty_buffers() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/41f3f3b5373e - [f2fs-dev,v5,21/23] nilfs2: Convert nilfs_copy_dirty_pages() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/d4a16d31334e - [f2fs-dev,v5,22/23] nilfs2: Convert nilfs_clear_dirty_pages() to use filemap_get_folios_tag() https://git.kernel.org/jaegeuk/f2fs/c/243c5ea4f783 - [f2fs-dev,v5,23/23] filemap: Remove find_get_pages_range_tag() https://git.kernel.org/jaegeuk/f2fs/c/c5792d938411 You are awesome, thank you!
This patch series replaces find_get_pages_range_tag() with filemap_get_folios_tag(). This also allows the removal of multiple calls to compound_head() throughout. It also makes a good chunk of the straightforward conversions to folios, and takes the opportunity to introduce a function that grabs a folio from the pagecache. I've run xfstests on xfs, btrfs, ext4, f2fs, and nilfs2, but more testing may be beneficial. The page-writeback and filemap changes implicitly work. Still looking for review of cifs, gfs2, and ext4. --- v5: Rebased onto upstream 6.2-rc2 Filesystems modified to use folio_get() instead of folio_ref_inc() F2fs modified to maintain use of F2FS_ONSTACK_PAGES v4: Fixed a bug with reference counting in cifs changes - Reported-by: kernel test robot <oliver.sang@intel.com> Improved commit messages to be more meaningful Got some Acked-bys and Reviewed-bys v3: Rebased onto upstream 6.1 Simplified the ceph patch to only necessary changes Changed commit messages throughout to be clearer Got an Acked-by for another nilfs patch Got Tested-by for afs v2: Got Acked-By tags for nilfs and btrfs changes Fixed an error arising in f2fs - Reported-by: kernel test robot <lkp@intel.com> Vishal Moola (Oracle) (23): pagemap: Add filemap_grab_folio() filemap: Added filemap_get_folios_tag() filemap: Convert __filemap_fdatawait_range() to use filemap_get_folios_tag() page-writeback: Convert write_cache_pages() to use filemap_get_folios_tag() afs: Convert afs_writepages_region() to use filemap_get_folios_tag() btrfs: Convert btree_write_cache_pages() to use filemap_get_folio_tag() btrfs: Convert extent_write_cache_pages() to use filemap_get_folios_tag() ceph: Convert ceph_writepages_start() to use filemap_get_folios_tag() cifs: Convert wdata_alloc_and_fillpages() to use filemap_get_folios_tag() ext4: Convert mpage_prepare_extent_to_map() to use filemap_get_folios_tag() f2fs: Convert f2fs_fsync_node_pages() to use filemap_get_folios_tag() f2fs: Convert f2fs_flush_inline_data() to use filemap_get_folios_tag() f2fs: Convert f2fs_sync_node_pages() to use filemap_get_folios_tag() f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag() f2fs: Convert last_fsync_dnode() to use filemap_get_folios_tag() f2fs: Convert f2fs_sync_meta_pages() to use filemap_get_folios_tag() gfs2: Convert gfs2_write_cache_jdata() to use filemap_get_folios_tag() nilfs2: Convert nilfs_lookup_dirty_data_buffers() to use filemap_get_folios_tag() nilfs2: Convert nilfs_lookup_dirty_node_buffers() to use filemap_get_folios_tag() nilfs2: Convert nilfs_btree_lookup_dirty_buffers() to use filemap_get_folios_tag() nilfs2: Convert nilfs_copy_dirty_pages() to use filemap_get_folios_tag() nilfs2: Convert nilfs_clear_dirty_pages() to use filemap_get_folios_tag() filemap: Remove find_get_pages_range_tag() fs/afs/write.c | 116 ++++++++++++++++++++-------------------- fs/btrfs/extent_io.c | 57 ++++++++++---------- fs/ceph/addr.c | 58 ++++++++++---------- fs/cifs/file.c | 32 +++++++++-- fs/ext4/inode.c | 65 +++++++++++----------- fs/f2fs/checkpoint.c | 49 +++++++++-------- fs/f2fs/data.c | 84 ++++++++++++++++++++--------- fs/f2fs/node.c | 72 +++++++++++++------------ fs/gfs2/aops.c | 64 ++++++++++++---------- fs/nilfs2/btree.c | 14 ++--- fs/nilfs2/page.c | 59 ++++++++++---------- fs/nilfs2/segment.c | 44 +++++++-------- include/linux/pagemap.h | 32 +++++++---- include/linux/pagevec.h | 8 --- mm/filemap.c | 84 ++++++++++++++--------------- mm/page-writeback.c | 44 +++++++-------- mm/swap.c | 10 ---- 17 files changed, 481 insertions(+), 411 deletions(-)