| Message ID | 20230228182226.52201-1-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [XEN] automation: Always pull base image when building a container | expand |
On 28/02/2023 6:22 pm, Anthony PERARD wrote: > Ask docker to check if there's an update of the base image to avoid > using an old container cached locally. > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> I've lost count of how many times I've fallen over this.
On Tue, 28 Feb 2023, Anthony PERARD wrote: > Ask docker to check if there's an update of the base image to avoid > using an old container cached locally. > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > automation/build/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/automation/build/Makefile b/automation/build/Makefile > index f1d56ce532..4df43b0407 100644 > --- a/automation/build/Makefile > +++ b/automation/build/Makefile > @@ -16,7 +16,7 @@ help: > include yocto/yocto.inc > > %: %.dockerfile ## Builds containers > - $(DOCKER_CMD) build -t $(REGISTRY)/$(@D):$(@F) -f $< $(<D) > + $(DOCKER_CMD) build --pull -t $(REGISTRY)/$(@D):$(@F) -f $< $(<D) > @if [ ! -z $${PUSH+x} ]; then \ > $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ > fi > -- > Anthony PERARD >
diff --git a/automation/build/Makefile b/automation/build/Makefile index f1d56ce532..4df43b0407 100644 --- a/automation/build/Makefile +++ b/automation/build/Makefile @@ -16,7 +16,7 @@ help: include yocto/yocto.inc %: %.dockerfile ## Builds containers - $(DOCKER_CMD) build -t $(REGISTRY)/$(@D):$(@F) -f $< $(<D) + $(DOCKER_CMD) build --pull -t $(REGISTRY)/$(@D):$(@F) -f $< $(<D) @if [ ! -z $${PUSH+x} ]; then \ $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ fi
Ask docker to check if there's an update of the base image to avoid using an old container cached locally. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- automation/build/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)