| Message ID | 20230302123051.12440-2-a39.skl@gmail.com (mailing list archive) |
|---|---|
| State | Queued |
| Headers | show |
| Series | [1/2] arm64: dts: qcom: msm8976: Add and provide xo clk to rpmcc | expand |
On Thu, 2 Mar 2023 at 14:31, Adam Skladowski <a39.skl@gmail.com> wrote: > > As xo_board is part of board not soc we define rates per device tree, > assign common 19.2Mhz rate to make consumers happy. > > Fixes: ff7f6d34ca07 ("arm64: dts: qcom: Add support for SONY Xperia X/X Compact") > Signed-off-by: Adam Skladowski <a39.skl@gmail.com> > --- > arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi > index 67baced639c9..085d79542e1b 100644 > --- a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi > @@ -280,3 +280,7 @@ &usb_hs_phy { > vdda3p3-supply = <&pm8950_l13>; > status = "okay"; > }; > + > +&xo_board { > + clock-frequency = <19200000>; This doesn't seem to be board-specific. Please move it to msm8976.dtsi. > +}; > -- > 2.25.1 >
On Thu, 2 Mar 2023 at 18:38, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Thu, 2 Mar 2023 at 14:31, Adam Skladowski <a39.skl@gmail.com> wrote: > > > > As xo_board is part of board not soc we define rates per device tree, > > assign common 19.2Mhz rate to make consumers happy. > > > > Fixes: ff7f6d34ca07 ("arm64: dts: qcom: Add support for SONY Xperia X/X Compact") > > Signed-off-by: Adam Skladowski <a39.skl@gmail.com> > > --- > > arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi > > index 67baced639c9..085d79542e1b 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi > > @@ -280,3 +280,7 @@ &usb_hs_phy { > > vdda3p3-supply = <&pm8950_l13>; > > status = "okay"; > > }; > > + > > +&xo_board { > > + clock-frequency = <19200000>; > > This doesn't seem to be board-specific. Please move it to msm8976.dtsi. Adam pointed out the clock frequency is now thought to be a board-specific thing. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi index 67baced639c9..085d79542e1b 100644 --- a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi @@ -280,3 +280,7 @@ &usb_hs_phy { vdda3p3-supply = <&pm8950_l13>; status = "okay"; }; + +&xo_board { + clock-frequency = <19200000>; +};
As xo_board is part of board not soc we define rates per device tree, assign common 19.2Mhz rate to make consumers happy. Fixes: ff7f6d34ca07 ("arm64: dts: qcom: Add support for SONY Xperia X/X Compact") Signed-off-by: Adam Skladowski <a39.skl@gmail.com> --- arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi | 4 ++++ 1 file changed, 4 insertions(+)