| Message ID | 20230203055812.257458-1-alexghiti@rivosinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | riscv: Allow user to set the satp mode | expand |
Hi Palmer, I think this series can be picked. All patches are fully acked. There is a nit in patch 3 that I believe you can choose to fix in-tree if you want to. Thanks, Daniel On 2/3/23 02:58, Alexandre Ghiti wrote: > This introduces new properties to allow the user to set the satp mode, > see patch 3 for full syntax. In addition, it prevents cpus to boot in a > satp mode they do not support (see patch 4). > > base-commit: commit 75cc28648574 ("configure: remove > backwards-compatibility code" > > v10: > - Fix user mode build by surrounding satp handling with #ifndef > CONFIG_USER_ONLY, Frank > - Fix AB/RB from Frank and Alistair > > v9: > - Move valid_vm[i] up, Andrew > - Fixed expansion of the bitmap map, Bin > - Rename set_satp_mode_default into set_satp_mode_default_map, Bin > - Remove outer parenthesis and alignment, Bin > - Fix qemu32 build failure, Bin > - Fixed a few typos, Bin > - Add RB from Andrew and Bin > > v8: > - Remove useless !map check, Andrew > - Add RB from Andrew > > v7: > - Expand map to contain all valid modes, Andrew > - Fix commit log for patch 3, Andrew > - Remove is_32_bit argument from set_satp_mode_default, Andrew > - Move and fixed comment, Andrew > - Fix satp_mode_map_max in riscv_cpu_satp_mode_finalize which was set > too early, Alex > - Remove is_32_bit argument from set_satp_mode_max_supported, Andrew > - Use satp_mode directly instead of a string in > set_satp_mode_max_supported, Andrew > - Swap the patch introducing supported bitmap and the patch that sets > sv57 in the dt, Andrew > - Add various RB from Andrew and Alistair, thanks > > v6: > - Remove the valid_vm check in validate_vm and add it to the finalize function > so that map already contains the constraint, Alex > - Add forgotten mbare to satp_mode_from_str, Alex > - Move satp mode properties handling to riscv_cpu_satp_mode_finalize, Andrew > - Only add satp mode properties corresponding to the cpu, and then remove the > check against valid_vm_1_10_32/64 in riscv_cpu_satp_mode_finalize, > Andrew/Alistair/Alex > - Move mmu-type setting to its own patch, Andrew > - patch 5 is new and is a fix, Alex > > v5: > - Simplify v4 implementation by leveraging valid_vm_1_10_32/64, as > suggested by Andrew > - Split the v4 patch into 2 patches as suggested by Andrew > - Lot of other minor corrections, from Andrew > - Set the satp mode N by disabling the satp mode N + 1 > - Add a helper to set satp mode from a string, as suggested by Frank > > v4: > - Use custom boolean properties instead of OnOffAuto properties, based > on ARMVQMap, as suggested by Andrew > > v3: > - Free sv_name as pointed by Bin > - Replace satp-mode with boolean properties as suggested by Andrew > - Removed RB from Atish as the patch considerably changed > > v2: > - Use error_setg + return as suggested by Alistair > - Add RB from Atish > - Fixed checkpatch issues missed in v1 > - Replaced Ludovic email address with the rivos one > > Alexandre Ghiti (5): > riscv: Pass Object to register_cpu_props instead of DeviceState > riscv: Change type of valid_vm_1_10_[32|64] to bool > riscv: Allow user to set the satp mode > riscv: Introduce satp mode hw capabilities > riscv: Correctly set the device-tree entry 'mmu-type' > > hw/riscv/virt.c | 19 ++-- > target/riscv/cpu.c | 271 +++++++++++++++++++++++++++++++++++++++++++-- > target/riscv/cpu.h | 25 +++++ > target/riscv/csr.c | 29 +++-- > 4 files changed, 313 insertions(+), 31 deletions(-) >
On 3/2/23 14:42, Daniel Henrique Barboza wrote: > Hi Palmer, > > I think this series can be picked. All patches are fully acked. There is a nit > in patch 3 that I believe you can choose to fix in-tree if you want to. Update: patch 1 is not applicable anymore due to changes in current master. All other patches have conflicts as well. I guess it's easier to Alexandre to rebase and re-send it when possible. Frank's comment in patch 3 can also be handled during the process. Thanks, Daniel > > > Thanks, > > > Daniel > > > > > On 2/3/23 02:58, Alexandre Ghiti wrote: >> This introduces new properties to allow the user to set the satp mode, >> see patch 3 for full syntax. In addition, it prevents cpus to boot in a >> satp mode they do not support (see patch 4). >> >> base-commit: commit 75cc28648574 ("configure: remove >> backwards-compatibility code" >> >> v10: >> - Fix user mode build by surrounding satp handling with #ifndef >> CONFIG_USER_ONLY, Frank >> - Fix AB/RB from Frank and Alistair >> >> v9: >> - Move valid_vm[i] up, Andrew >> - Fixed expansion of the bitmap map, Bin >> - Rename set_satp_mode_default into set_satp_mode_default_map, Bin >> - Remove outer parenthesis and alignment, Bin >> - Fix qemu32 build failure, Bin >> - Fixed a few typos, Bin >> - Add RB from Andrew and Bin >> >> v8: >> - Remove useless !map check, Andrew >> - Add RB from Andrew >> >> v7: >> - Expand map to contain all valid modes, Andrew >> - Fix commit log for patch 3, Andrew >> - Remove is_32_bit argument from set_satp_mode_default, Andrew >> - Move and fixed comment, Andrew >> - Fix satp_mode_map_max in riscv_cpu_satp_mode_finalize which was set >> too early, Alex >> - Remove is_32_bit argument from set_satp_mode_max_supported, Andrew >> - Use satp_mode directly instead of a string in >> set_satp_mode_max_supported, Andrew >> - Swap the patch introducing supported bitmap and the patch that sets >> sv57 in the dt, Andrew >> - Add various RB from Andrew and Alistair, thanks >> >> v6: >> - Remove the valid_vm check in validate_vm and add it to the finalize function >> so that map already contains the constraint, Alex >> - Add forgotten mbare to satp_mode_from_str, Alex >> - Move satp mode properties handling to riscv_cpu_satp_mode_finalize, Andrew >> - Only add satp mode properties corresponding to the cpu, and then remove the >> check against valid_vm_1_10_32/64 in riscv_cpu_satp_mode_finalize, >> Andrew/Alistair/Alex >> - Move mmu-type setting to its own patch, Andrew >> - patch 5 is new and is a fix, Alex >> >> v5: >> - Simplify v4 implementation by leveraging valid_vm_1_10_32/64, as >> suggested by Andrew >> - Split the v4 patch into 2 patches as suggested by Andrew >> - Lot of other minor corrections, from Andrew >> - Set the satp mode N by disabling the satp mode N + 1 >> - Add a helper to set satp mode from a string, as suggested by Frank >> >> v4: >> - Use custom boolean properties instead of OnOffAuto properties, based >> on ARMVQMap, as suggested by Andrew >> >> v3: >> - Free sv_name as pointed by Bin >> - Replace satp-mode with boolean properties as suggested by Andrew >> - Removed RB from Atish as the patch considerably changed >> >> v2: >> - Use error_setg + return as suggested by Alistair >> - Add RB from Atish >> - Fixed checkpatch issues missed in v1 >> - Replaced Ludovic email address with the rivos one >> >> Alexandre Ghiti (5): >> riscv: Pass Object to register_cpu_props instead of DeviceState >> riscv: Change type of valid_vm_1_10_[32|64] to bool >> riscv: Allow user to set the satp mode >> riscv: Introduce satp mode hw capabilities >> riscv: Correctly set the device-tree entry 'mmu-type' >> >> hw/riscv/virt.c | 19 ++-- >> target/riscv/cpu.c | 271 +++++++++++++++++++++++++++++++++++++++++++-- >> target/riscv/cpu.h | 25 +++++ >> target/riscv/csr.c | 29 +++-- >> 4 files changed, 313 insertions(+), 31 deletions(-) >>
Hi Daniel, On Thu, Mar 2, 2023 at 10:03 PM Daniel Henrique Barboza <dbarboza@ventanamicro.com> wrote: > > > > On 3/2/23 14:42, Daniel Henrique Barboza wrote: > > Hi Palmer, > > > > I think this series can be picked. All patches are fully acked. There is a nit > > in patch 3 that I believe you can choose to fix in-tree if you want to. > > Update: patch 1 is not applicable anymore due to changes in current master. All > other patches have conflicts as well. > > I guess it's easier to Alexandre to rebase and re-send it when possible. Frank's > comment in patch 3 can also be handled during the process. Sure I'll do that today, Thanks, Alex > > > Thanks, > > > Daniel > > > > > > > > > Thanks, > > > > > > Daniel > > > > > > > > > > On 2/3/23 02:58, Alexandre Ghiti wrote: > >> This introduces new properties to allow the user to set the satp mode, > >> see patch 3 for full syntax. In addition, it prevents cpus to boot in a > >> satp mode they do not support (see patch 4). > >> > >> base-commit: commit 75cc28648574 ("configure: remove > >> backwards-compatibility code" > >> > >> v10: > >> - Fix user mode build by surrounding satp handling with #ifndef > >> CONFIG_USER_ONLY, Frank > >> - Fix AB/RB from Frank and Alistair > >> > >> v9: > >> - Move valid_vm[i] up, Andrew > >> - Fixed expansion of the bitmap map, Bin > >> - Rename set_satp_mode_default into set_satp_mode_default_map, Bin > >> - Remove outer parenthesis and alignment, Bin > >> - Fix qemu32 build failure, Bin > >> - Fixed a few typos, Bin > >> - Add RB from Andrew and Bin > >> > >> v8: > >> - Remove useless !map check, Andrew > >> - Add RB from Andrew > >> > >> v7: > >> - Expand map to contain all valid modes, Andrew > >> - Fix commit log for patch 3, Andrew > >> - Remove is_32_bit argument from set_satp_mode_default, Andrew > >> - Move and fixed comment, Andrew > >> - Fix satp_mode_map_max in riscv_cpu_satp_mode_finalize which was set > >> too early, Alex > >> - Remove is_32_bit argument from set_satp_mode_max_supported, Andrew > >> - Use satp_mode directly instead of a string in > >> set_satp_mode_max_supported, Andrew > >> - Swap the patch introducing supported bitmap and the patch that sets > >> sv57 in the dt, Andrew > >> - Add various RB from Andrew and Alistair, thanks > >> > >> v6: > >> - Remove the valid_vm check in validate_vm and add it to the finalize function > >> so that map already contains the constraint, Alex > >> - Add forgotten mbare to satp_mode_from_str, Alex > >> - Move satp mode properties handling to riscv_cpu_satp_mode_finalize, Andrew > >> - Only add satp mode properties corresponding to the cpu, and then remove the > >> check against valid_vm_1_10_32/64 in riscv_cpu_satp_mode_finalize, > >> Andrew/Alistair/Alex > >> - Move mmu-type setting to its own patch, Andrew > >> - patch 5 is new and is a fix, Alex > >> > >> v5: > >> - Simplify v4 implementation by leveraging valid_vm_1_10_32/64, as > >> suggested by Andrew > >> - Split the v4 patch into 2 patches as suggested by Andrew > >> - Lot of other minor corrections, from Andrew > >> - Set the satp mode N by disabling the satp mode N + 1 > >> - Add a helper to set satp mode from a string, as suggested by Frank > >> > >> v4: > >> - Use custom boolean properties instead of OnOffAuto properties, based > >> on ARMVQMap, as suggested by Andrew > >> > >> v3: > >> - Free sv_name as pointed by Bin > >> - Replace satp-mode with boolean properties as suggested by Andrew > >> - Removed RB from Atish as the patch considerably changed > >> > >> v2: > >> - Use error_setg + return as suggested by Alistair > >> - Add RB from Atish > >> - Fixed checkpatch issues missed in v1 > >> - Replaced Ludovic email address with the rivos one > >> > >> Alexandre Ghiti (5): > >> riscv: Pass Object to register_cpu_props instead of DeviceState > >> riscv: Change type of valid_vm_1_10_[32|64] to bool > >> riscv: Allow user to set the satp mode > >> riscv: Introduce satp mode hw capabilities > >> riscv: Correctly set the device-tree entry 'mmu-type' > >> > >> hw/riscv/virt.c | 19 ++-- > >> target/riscv/cpu.c | 271 +++++++++++++++++++++++++++++++++++++++++++-- > >> target/riscv/cpu.h | 25 +++++ > >> target/riscv/csr.c | 29 +++-- > >> 4 files changed, 313 insertions(+), 31 deletions(-) > >>
This introduces new properties to allow the user to set the satp mode, see patch 3 for full syntax. In addition, it prevents cpus to boot in a satp mode they do not support (see patch 4). base-commit: commit 75cc28648574 ("configure: remove backwards-compatibility code" v10: - Fix user mode build by surrounding satp handling with #ifndef CONFIG_USER_ONLY, Frank - Fix AB/RB from Frank and Alistair v9: - Move valid_vm[i] up, Andrew - Fixed expansion of the bitmap map, Bin - Rename set_satp_mode_default into set_satp_mode_default_map, Bin - Remove outer parenthesis and alignment, Bin - Fix qemu32 build failure, Bin - Fixed a few typos, Bin - Add RB from Andrew and Bin v8: - Remove useless !map check, Andrew - Add RB from Andrew v7: - Expand map to contain all valid modes, Andrew - Fix commit log for patch 3, Andrew - Remove is_32_bit argument from set_satp_mode_default, Andrew - Move and fixed comment, Andrew - Fix satp_mode_map_max in riscv_cpu_satp_mode_finalize which was set too early, Alex - Remove is_32_bit argument from set_satp_mode_max_supported, Andrew - Use satp_mode directly instead of a string in set_satp_mode_max_supported, Andrew - Swap the patch introducing supported bitmap and the patch that sets sv57 in the dt, Andrew - Add various RB from Andrew and Alistair, thanks v6: - Remove the valid_vm check in validate_vm and add it to the finalize function so that map already contains the constraint, Alex - Add forgotten mbare to satp_mode_from_str, Alex - Move satp mode properties handling to riscv_cpu_satp_mode_finalize, Andrew - Only add satp mode properties corresponding to the cpu, and then remove the check against valid_vm_1_10_32/64 in riscv_cpu_satp_mode_finalize, Andrew/Alistair/Alex - Move mmu-type setting to its own patch, Andrew - patch 5 is new and is a fix, Alex v5: - Simplify v4 implementation by leveraging valid_vm_1_10_32/64, as suggested by Andrew - Split the v4 patch into 2 patches as suggested by Andrew - Lot of other minor corrections, from Andrew - Set the satp mode N by disabling the satp mode N + 1 - Add a helper to set satp mode from a string, as suggested by Frank v4: - Use custom boolean properties instead of OnOffAuto properties, based on ARMVQMap, as suggested by Andrew v3: - Free sv_name as pointed by Bin - Replace satp-mode with boolean properties as suggested by Andrew - Removed RB from Atish as the patch considerably changed v2: - Use error_setg + return as suggested by Alistair - Add RB from Atish - Fixed checkpatch issues missed in v1 - Replaced Ludovic email address with the rivos one Alexandre Ghiti (5): riscv: Pass Object to register_cpu_props instead of DeviceState riscv: Change type of valid_vm_1_10_[32|64] to bool riscv: Allow user to set the satp mode riscv: Introduce satp mode hw capabilities riscv: Correctly set the device-tree entry 'mmu-type' hw/riscv/virt.c | 19 ++-- target/riscv/cpu.c | 271 +++++++++++++++++++++++++++++++++++++++++++-- target/riscv/cpu.h | 25 +++++ target/riscv/csr.c | 29 +++-- 4 files changed, 313 insertions(+), 31 deletions(-)