| Message ID | 20230303132731.1919329-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/nouveau/fifo: set gf100_fifo_nonstall_block_dump storage-class-specifier to static | expand |
Reviewed-by: Karol Herbst <kherbst@redhat.com> will push in a moment On Fri, Mar 3, 2023 at 2:27 PM Tom Rix <trix@redhat.com> wrote: > > gcc with W=1 reports > drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c:451:1: error: > no previous prototype for ‘gf100_fifo_nonstall_block’ [-Werror=missing-prototypes] > 451 | gf100_fifo_nonstall_block(struct nvkm_event *event, int type, int index) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > gf100_fifo_nonstall_block is only used in gf100.c, so it should be static > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c > index 5bb65258c36d..6c94451d0faa 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c > @@ -447,7 +447,7 @@ gf100_fifo_nonstall_allow(struct nvkm_event *event, int type, int index) > spin_unlock_irqrestore(&fifo->lock, flags); > } > > -void > +static void > gf100_fifo_nonstall_block(struct nvkm_event *event, int type, int index) > { > struct nvkm_fifo *fifo = container_of(event, typeof(*fifo), nonstall.event); > -- > 2.27.0 >
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c index 5bb65258c36d..6c94451d0faa 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c @@ -447,7 +447,7 @@ gf100_fifo_nonstall_allow(struct nvkm_event *event, int type, int index) spin_unlock_irqrestore(&fifo->lock, flags); } -void +static void gf100_fifo_nonstall_block(struct nvkm_event *event, int type, int index) { struct nvkm_fifo *fifo = container_of(event, typeof(*fifo), nonstall.event);
gcc with W=1 reports drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c:451:1: error: no previous prototype for ‘gf100_fifo_nonstall_block’ [-Werror=missing-prototypes] 451 | gf100_fifo_nonstall_block(struct nvkm_event *event, int type, int index) | ^~~~~~~~~~~~~~~~~~~~~~~~~ gf100_fifo_nonstall_block is only used in gf100.c, so it should be static Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)