| Message ID | 20230304164135.28430-1-strit@manjaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: Lower sd speed on soquartz | expand |
On Sat, Mar 4, 2023 at 11:42 AM Dan Johansen <strit@manjaro.org> wrote: > > Just like the Quartz64 Model B the previously stated speed of sdr-104 > in soquartz is too high for the hardware to reliably communicate with > some fast SD cards. > Especially on some carrierboards. > > Lower this to sd-uhs-sdr50 to fix this. > > Fixes: 5859b5a9c3ac ("arm64: dts: rockchip: add SoQuartz CM4IO dts") > > Signed-off-by: Dan Johansen <strit@manjaro.org> Makes sense, considering the problems we're having with other boards. We should probably stop using sdr104 altogether on Rockchip, at least until they release a chip that improves on the limitations of pinctrl speed. Considering the frequency cap it isn't that much of a hit. Acked-by: Peter Geis <pgwipeout@gmail.com> > --- > arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi > index ce7165d7f1a1..102e448bc026 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi > @@ -598,7 +598,7 @@ &sdmmc1 { > non-removable; > pinctrl-names = "default"; > pinctrl-0 = <&sdmmc1_bus4 &sdmmc1_cmd &sdmmc1_clk>; > - sd-uhs-sdr104; > + sd-uhs-sdr50; > vmmc-supply = <&vcc3v3_sys>; > vqmmc-supply = <&vcc_1v8>; > status = "okay"; > -- > 2.39.2 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
Den 05.03.2023 kl. 14.43 skrev Peter Geis: > On Sat, Mar 4, 2023 at 11:42 AM Dan Johansen <strit@manjaro.org> wrote: >> Just like the Quartz64 Model B the previously stated speed of sdr-104 >> in soquartz is too high for the hardware to reliably communicate with >> some fast SD cards. >> Especially on some carrierboards. >> >> Lower this to sd-uhs-sdr50 to fix this. >> >> Fixes: 5859b5a9c3ac ("arm64: dts: rockchip: add SoQuartz CM4IO dts") >> >> Signed-off-by: Dan Johansen <strit@manjaro.org> > Makes sense, considering the problems we're having with other boards. > We should probably stop using sdr104 altogether on Rockchip, at least > until they release a chip that improves on the limitations of pinctrl > speed. Considering the frequency cap it isn't that much of a hit. I agree, better have a safe default. > > Acked-by: Peter Geis <pgwipeout@gmail.com> Thank you for the Ack. > >> --- >> arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi >> index ce7165d7f1a1..102e448bc026 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi >> @@ -598,7 +598,7 @@ &sdmmc1 { >> non-removable; >> pinctrl-names = "default"; >> pinctrl-0 = <&sdmmc1_bus4 &sdmmc1_cmd &sdmmc1_clk>; >> - sd-uhs-sdr104; >> + sd-uhs-sdr50; >> vmmc-supply = <&vcc3v3_sys>; >> vqmmc-supply = <&vcc_1v8>; >> status = "okay"; >> -- >> 2.39.2 >> >> >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rockchip > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
On Sat, 4 Mar 2023 17:41:35 +0100, Dan Johansen wrote: > Just like the Quartz64 Model B the previously stated speed of sdr-104 > in soquartz is too high for the hardware to reliably communicate with > some fast SD cards. > Especially on some carrierboards. > > Lower this to sd-uhs-sdr50 to fix this. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: Lower sd speed on soquartz commit: 5912b647bd0732ae8c78a6e5b259c82efd177d93 Best regards,
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi index ce7165d7f1a1..102e448bc026 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi @@ -598,7 +598,7 @@ &sdmmc1 { non-removable; pinctrl-names = "default"; pinctrl-0 = <&sdmmc1_bus4 &sdmmc1_cmd &sdmmc1_clk>; - sd-uhs-sdr104; + sd-uhs-sdr50; vmmc-supply = <&vcc3v3_sys>; vqmmc-supply = <&vcc_1v8>; status = "okay";
Just like the Quartz64 Model B the previously stated speed of sdr-104 in soquartz is too high for the hardware to reliably communicate with some fast SD cards. Especially on some carrierboards. Lower this to sd-uhs-sdr50 to fix this. Fixes: 5859b5a9c3ac ("arm64: dts: rockchip: add SoQuartz CM4IO dts") Signed-off-by: Dan Johansen <strit@manjaro.org> --- arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)