[4/8] dt-bindings: iio: st-sensors: Add IIS328DQ accelerometer

Commit Message

Stefan Wahren March 6, 2023, 5:22 p.m. UTC

From: Stefan Wahren <[e-mail]>

The ST IIS328DQ is an accelerometer sensor compatible with
the existing ST sensor binding.

Link: https://lore.kernel.org/linux-iio/[e-mail]/
Signed-off-by: Stefan Wahren <[e-mail]>
Signed-off-by: Stefan Wahren <[e-mail]>
---
 Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski March 7, 2023, 8:23 a.m. UTC | #1

On 06/03/2023 18:22, Stefan Wahren wrote:
> From: Stefan Wahren <[e-mail]>
> 
> The ST IIS328DQ is an accelerometer sensor compatible with
> the existing ST sensor binding.

If it is compatible with existing binding, then make it compatible.
Although your driver change suggests it is not compatible...

Best regards,
Krzysztof

Stefan Wahren March 7, 2023, 5:27 p.m. UTC | #2

Hi Krzysztof,

Am 07.03.23 um 09:23 schrieb Krzysztof Kozlowski:
> On 06/03/2023 18:22, Stefan Wahren wrote:
>> From: Stefan Wahren <[e-mail]>
>>
>> The ST IIS328DQ is an accelerometer sensor compatible with
>> the existing ST sensor binding.
> If it is compatible with existing binding, then make it compatible.
> Although your driver change suggests it is not compatible...
since the policy is to make the compatible so specific as possible, i 
will fix the wording here.
>
> Best regards,
> Krzysztof
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [e-mail]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Jonathan Cameron March 11, 2023, 6:06 p.m. UTC | #3

On Tue, 7 Mar 2023 18:27:53 +0100
Stefan Wahren <[e-mail]> wrote:

> Hi Krzysztof,
> 
> Am 07.03.23 um 09:23 schrieb Krzysztof Kozlowski:
> > On 06/03/2023 18:22, Stefan Wahren wrote:  
> >> From: Stefan Wahren <[e-mail]>
> >>
> >> The ST IIS328DQ is an accelerometer sensor compatible with
> >> the existing ST sensor binding.  
> > If it is compatible with existing binding, then make it compatible.
> > Although your driver change suggests it is not compatible...  
> since the policy is to make the compatible so specific as possible, i 
> will fix the wording here.

Driver changes are naming only - which we do want as that isn't discoverable
from the device but it will 'work' fine with a fallback compatible of
st,h3lis331dl-accel be it with wrong device naming exposed to userspace.

Hmm. That shouldn't have the postfix as it's not a multi device package
(which are the cases where we need postfix as they have multiple drivers
binding to different independent things in the one package / part number)

If someone wants to add a compatible of st,h3lis331dl and deprecate
the accel variant that would be fine, but wouldn't help us much here
for a fallback compatible and it's probably not worth the effort.

Historically we've not been doing fallback compatibles right in this
driver but it's probably not worth 'fixing' that for old devices
as the only real benefit would be things working nicely with old kernels.
Nice to not make it worse though.

So I'd like to see this fallback to st,h3lis331dl-accel

Jonathan


> >
> > Best regards,
> > Krzysztof
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > [e-mail]
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Patch

diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
index c6201976378f..247700537aa8 100644
--- a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
+++ b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
@@ -25,6 +25,7 @@  properties:
       - description: STMicroelectronics Accelerometers
         enum:
           - st,h3lis331dl-accel
+          - st,iis328dq
           - st,lis2de12
           - st,lis2dw12
           - st,lis2hh12