| Message ID | 20230213121012.1768296-9-konrad.dybcio@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/9] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible | expand |
On Mon, 13 Feb 2023 13:10:11 +0100, Konrad Dybcio wrote: > Add a compatible for the DSI on SM6115. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On 13/02/2023 13:10, Konrad Dybcio wrote: > Add a compatible for the DSI on SM6115. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index 2494817c1bd6..f195530ae964 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -25,6 +25,7 @@ properties: > - qcom,sc7280-dsi-ctrl > - qcom,sdm660-dsi-ctrl > - qcom,sdm845-dsi-ctrl > + - qcom,sm6115-dsi-ctrl This looks incomplete. You also need to add it to MDSS binding. Best regards, Krzysztof
On 7.03.2023 10:17, Krzysztof Kozlowski wrote: > On 13/02/2023 13:10, Konrad Dybcio wrote: >> Add a compatible for the DSI on SM6115. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> index 2494817c1bd6..f195530ae964 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> @@ -25,6 +25,7 @@ properties: >> - qcom,sc7280-dsi-ctrl >> - qcom,sdm660-dsi-ctrl >> - qcom,sdm845-dsi-ctrl >> + - qcom,sm6115-dsi-ctrl > > This looks incomplete. You also need to add it to MDSS binding. https://lore.kernel.org/linux-arm-msm/145066db-5723-6baa-237d-7c2b8fd476d9@linaro.org/ Does this.. but I guess I'll resend this as one series, as it only makes sense. Konrad > > Best regards, > Krzysztof >
On 07/03/2023 12:14, Konrad Dybcio wrote: > > > On 7.03.2023 10:17, Krzysztof Kozlowski wrote: >> On 13/02/2023 13:10, Konrad Dybcio wrote: >>> Add a compatible for the DSI on SM6115. >>> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>> --- >>> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >>> index 2494817c1bd6..f195530ae964 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >>> @@ -25,6 +25,7 @@ properties: >>> - qcom,sc7280-dsi-ctrl >>> - qcom,sdm660-dsi-ctrl >>> - qcom,sdm845-dsi-ctrl >>> + - qcom,sm6115-dsi-ctrl >> >> This looks incomplete. You also need to add it to MDSS binding. > https://lore.kernel.org/linux-arm-msm/145066db-5723-6baa-237d-7c2b8fd476d9@linaro.org/ > > Does this.. but I guess I'll resend this as one series, as it only > makes sense. It should be one commit. Adding sm6115 here is incomplete if other binding (using this one) does not allow it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index 2494817c1bd6..f195530ae964 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -25,6 +25,7 @@ properties: - qcom,sc7280-dsi-ctrl - qcom,sdm660-dsi-ctrl - qcom,sdm845-dsi-ctrl + - qcom,sm6115-dsi-ctrl - qcom,sm8150-dsi-ctrl - qcom,sm8250-dsi-ctrl - qcom,sm8350-dsi-ctrl @@ -351,6 +352,7 @@ allOf: contains: enum: - qcom,sdm845-dsi-ctrl + - qcom,sm6115-dsi-ctrl then: properties: clocks:
Add a compatible for the DSI on SM6115. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+)