diff mbox series

[1/1] arm64: dts: imx93: add missing tpm pwm instances

Message ID 20230227093846.151474-1-alexander.stein@ew.tq-group.com (mailing list archive)
State New, archived
Headers show
Series [1/1] arm64: dts: imx93: add missing tpm pwm instances | expand

Commit Message

Alexander Stein Feb. 27, 2023, 9:38 a.m. UTC 
TPM1/TPM3 are missing, add them.

Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx93.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Alexander Stein March 8, 2023, noon UTC | #1 
Hi everyone,

any feedback on this?

Thanks,
Alexander

Am Montag, 27. Februar 2023, 10:38:46 CET schrieb Alexander Stein:
> TPM1/TPM3 are missing, add them.
> 
> Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi index 2076f9c9983a..a30c5d5f4d13
> 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -153,6 +153,14 @@ system_counter: timer@44290000 {
>  				nxp,no-divider;
>  			};
> 
> +			tpm1: pwm@44310000 {
> +				compatible = "fsl,imx7ulp-pwm";
> +				reg = <0x44310000 0x1000>;
> +				clocks = <&clk IMX93_CLK_TPM1_GATE>;
> +				#pwm-cells = <3>;
> +				status = "disabled";
> +			};
> +
>  			tpm2: pwm@44320000 {
>  				compatible = "fsl,imx7ulp-pwm";
>  				reg = <0x44320000 0x10000>;
> @@ -316,6 +324,14 @@ mu2: mailbox@42440000 {
>  				status = "disabled";
>  			};
> 
> +			tpm3: pwm@424e0000 {
> +				compatible = "fsl,imx7ulp-pwm";
> +				reg = <0x424e0000 0x1000>;
> +				clocks = <&clk IMX93_CLK_TPM3_GATE>;
> +				#pwm-cells = <3>;
> +				status = "disabled";
> +			};
> +
>  			tpm4: pwm@424f0000 {
>  				compatible = "fsl,imx7ulp-pwm";
>  				reg = <0x424f0000 0x10000>;
Fabio Estevam March 8, 2023, 12:34 p.m. UTC | #2 
Hi Alexander,

On Mon, Feb 27, 2023 at 6:38 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> TPM1/TPM3 are missing, add them.
>
> Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Who is the original author? If it is Markus, then his name should
appear in the From: line.

Apart from that:

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Alexander Stein March 8, 2023, 12:45 p.m. UTC | #3 
Hi Fabio,

Am Mittwoch, 8. März 2023, 13:34:44 CET schrieb Fabio Estevam:
> Hi Alexander,
> 
> On Mon, Feb 27, 2023 at 6:38 AM Alexander Stein
> 
> <alexander.stein@ew.tq-group.com> wrote:
> > TPM1/TPM3 are missing, add them.
> > 
> > Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> Who is the original author? If it is Markus, then his name should
> appear in the From: line.

Yes, it's Markus. I don't know why authorship got changed, I'll send v2 with 
that fixed.

> Apart from that:
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thanks
Alexander
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 2076f9c9983a..a30c5d5f4d13 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -153,6 +153,14 @@  system_counter: timer@44290000 {
 				nxp,no-divider;
 			};
 
+			tpm1: pwm@44310000 {
+				compatible = "fsl,imx7ulp-pwm";
+				reg = <0x44310000 0x1000>;
+				clocks = <&clk IMX93_CLK_TPM1_GATE>;
+				#pwm-cells = <3>;
+				status = "disabled";
+			};
+
 			tpm2: pwm@44320000 {
 				compatible = "fsl,imx7ulp-pwm";
 				reg = <0x44320000 0x10000>;
@@ -316,6 +324,14 @@  mu2: mailbox@42440000 {
 				status = "disabled";
 			};
 
+			tpm3: pwm@424e0000 {
+				compatible = "fsl,imx7ulp-pwm";
+				reg = <0x424e0000 0x1000>;
+				clocks = <&clk IMX93_CLK_TPM3_GATE>;
+				#pwm-cells = <3>;
+				status = "disabled";
+			};
+
 			tpm4: pwm@424f0000 {
 				compatible = "fsl,imx7ulp-pwm";
 				reg = <0x424f0000 0x10000>;