| Message ID | 20230308034036.99213-2-xingyu.wu@starfivetech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add watchdog driver for StarFive JH7100/JH7110 RISC-V SoCs | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 1 and now 1 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 21 this patch: 21 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 37 this patch: 37 |
| conchuod/alphanumeric_selects | success | Out of order selects before the patch: 728 and now 728 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 3 this patch: 3 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | warning | WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? |
| conchuod/source_inline | success | Was 0 now: 0 |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On 08/03/2023 04:40, Xingyu Wu wrote: > Add bindings to describe the watchdog for the StarFive JH7100/JH7110 SoC. > And Use JH7100 as first StarFive SoC with watchdog. > > Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com> > --- What happened here? You wrote in changelog "Modified" but what exactly? How am I supposed to find it? Provide detailed description, since you decided to remove my tag. Otherwise, standard response: This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
On 2023/3/9 15:30, Krzysztof Kozlowski wrote: > On 08/03/2023 04:40, Xingyu Wu wrote: >> Add bindings to describe the watchdog for the StarFive JH7100/JH7110 SoC. >> And Use JH7100 as first StarFive SoC with watchdog. >> >> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com> >> --- > > What happened here? You wrote in changelog "Modified" but what exactly? > How am I supposed to find it? > > Provide detailed description, since you decided to remove my tag. > Otherwise, standard response: > > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions. However, there's no need to repost patches *only* to add the > tags. The upstream maintainer will do that for acks received on the > version they apply. > > https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 > > If a tag was not added on purpose, please state why and what changed. > I am sorry I did not elaborate it. The dt-bindings was only supported JH7110 watchdog in v3 patchset and you had sent Reviewed-by tags. But at the same time tried to add JH7100 watchdog after discussion and used JH7100 as the dt-binding's name because JH7100 is the first StarFive SoCs about watchdog. The compatible also add 'starfive,jh7100-wdt' in the dt-binding. It is different from the v3 patch and I did not add the Reviewed-by tag. Best regards, Xingyu Wu
On 09/03/2023 09:13, Xingyu Wu wrote: > On 2023/3/9 15:30, Krzysztof Kozlowski wrote: >> On 08/03/2023 04:40, Xingyu Wu wrote: >>> Add bindings to describe the watchdog for the StarFive JH7100/JH7110 SoC. >>> And Use JH7100 as first StarFive SoC with watchdog. >>> >>> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com> >>> --- >> >> What happened here? You wrote in changelog "Modified" but what exactly? >> How am I supposed to find it? >> >> Provide detailed description, since you decided to remove my tag. >> Otherwise, standard response: >> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions. However, there's no need to repost patches *only* to add the >> tags. The upstream maintainer will do that for acks received on the >> version they apply. >> >> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 >> >> If a tag was not added on purpose, please state why and what changed. >> > > I am sorry I did not elaborate it. The dt-bindings was only supported JH7110 watchdog in v3 patchset > and you had sent Reviewed-by tags. But at the same time tried to add JH7100 watchdog after discussion > and used JH7100 as the dt-binding's name because JH7100 is the first StarFive SoCs about watchdog. > The compatible also add 'starfive,jh7100-wdt' in the dt-binding. It is different from the v3 patch and > I did not add the Reviewed-by tag. So what is the difference? Filename and new compatible? Best regards, Krzysztof
On 2023/3/9 16:35, Krzysztof Kozlowski wrote: > On 09/03/2023 09:13, Xingyu Wu wrote: >> On 2023/3/9 15:30, Krzysztof Kozlowski wrote: >>> On 08/03/2023 04:40, Xingyu Wu wrote: >>>> Add bindings to describe the watchdog for the StarFive JH7100/JH7110 SoC. >>>> And Use JH7100 as first StarFive SoC with watchdog. >>>> >>>> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com> >>>> --- >>> >>> What happened here? You wrote in changelog "Modified" but what exactly? >>> How am I supposed to find it? >>> >>> Provide detailed description, since you decided to remove my tag. >>> Otherwise, standard response: >>> >>> This is a friendly reminder during the review process. >>> >>> It looks like you received a tag and forgot to add it. >>> >>> If you do not know the process, here is a short explanation: >>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >>> versions. However, there's no need to repost patches *only* to add the >>> tags. The upstream maintainer will do that for acks received on the >>> version they apply. >>> >>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 >>> >>> If a tag was not added on purpose, please state why and what changed. >>> >> >> I am sorry I did not elaborate it. The dt-bindings was only supported JH7110 watchdog in v3 patchset >> and you had sent Reviewed-by tags. But at the same time tried to add JH7100 watchdog after discussion >> and used JH7100 as the dt-binding's name because JH7100 is the first StarFive SoCs about watchdog. >> The compatible also add 'starfive,jh7100-wdt' in the dt-binding. It is different from the v3 patch and >> I did not add the Reviewed-by tag. > > So what is the difference? Filename and new compatible? > Yes. So are these acceptable and can still add the tag? Best regards, Xingyu Wu
On 08/03/2023 04:40, Xingyu Wu wrote: > Add bindings to describe the watchdog for the StarFive JH7100/JH7110 SoC. > And Use JH7100 as first StarFive SoC with watchdog. > > Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 2023/3/9 16:56, Krzysztof Kozlowski wrote: > On 08/03/2023 04:40, Xingyu Wu wrote: >> Add bindings to describe the watchdog for the StarFive JH7100/JH7110 SoC. >> And Use JH7100 as first StarFive SoC with watchdog. >> >> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com> >> --- > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Thank you for your understanding Best regards, Xingyu Wu
diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml new file mode 100644 index 000000000000..68f3f6fd08a6 --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml @@ -0,0 +1,71 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/starfive,jh7100-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: StarFive Watchdog for JH7100 and JH7110 SoC + +maintainers: + - Xingyu Wu <xingyu.wu@starfivetech.com> + - Samin Guo <samin.guo@starfivetech.com> + +description: + The JH7100 and JH7110 watchdog both are 32 bit counters. JH7100 watchdog + has only one timeout phase and reboots. And JH7110 watchdog has two + timeout phases. At the first phase, the signal of watchdog interrupt + output(WDOGINT) will rise when counter is 0. The counter will reload + the timeout value. And then, if counter decreases to 0 again and WDOGINT + isn't cleared, the watchdog will reset the system unless the watchdog + reset is disabled. + +allOf: + - $ref: watchdog.yaml# + +properties: + compatible: + enum: + - starfive,jh7100-wdt + - starfive,jh7110-wdt + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: APB clock + - description: Core clock + + clock-names: + items: + - const: apb + - const: core + + resets: + items: + - description: APB reset + - description: Core reset + +required: + - compatible + - reg + - clocks + - clock-names + - resets + +unevaluatedProperties: false + +examples: + - | + watchdog@12480000 { + compatible = "starfive,jh7100-wdt"; + reg = <0x12480000 0x10000>; + clocks = <&clk 171>, + <&clk 172>; + clock-names = "apb", "core"; + resets = <&rst 99>, + <&rst 100>; + };
Add bindings to describe the watchdog for the StarFive JH7100/JH7110 SoC. And Use JH7100 as first StarFive SoC with watchdog. Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com> --- .../watchdog/starfive,jh7100-wdt.yaml | 71 +++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml