| Message ID | 20230309111209.31606-1-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f3d0fbad6765da25de7ecf6481af9b6ddb0b3793 |
| Headers | show |
| Series | firmware: qcom: scm: fix bogus irq error at probe | expand |
On 9.03.2023 12:12, Johan Hovold wrote: > A recent commit added support for an optional interrupt which is only > available on some platforms. > > Stop spamming the logs with bogus error messages on platforms that do > not use this new optional resource: > > qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found > > Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic") > Cc: Guru Das Srinagesh <quic_gurus@quicinc.com> > Cc: Sibi Sankar <quic_sibis@quicinc.com> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/firmware/qcom_scm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index 468d4d5ab550..b1e11f85b805 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -1479,7 +1479,7 @@ static int qcom_scm_probe(struct platform_device *pdev) > > init_completion(&__scm->waitq_comp); > > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq < 0) { > if (irq != -ENXIO) > return irq;
On Mar 09 2023 12:12, Johan Hovold wrote: > A recent commit added support for an optional interrupt which is only > available on some platforms. > > Stop spamming the logs with bogus error messages on platforms that do > not use this new optional resource: > > qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found > > Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic") > Cc: Guru Das Srinagesh <quic_gurus@quicinc.com> > Cc: Sibi Sankar <quic_sibis@quicinc.com> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Acked-by: Guru Das Srinagesh <quic_gurus@quicinc.com> Thanks for catching this! > --- > drivers/firmware/qcom_scm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index 468d4d5ab550..b1e11f85b805 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -1479,7 +1479,7 @@ static int qcom_scm_probe(struct platform_device *pdev) > > init_completion(&__scm->waitq_comp); > > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq < 0) { > if (irq != -ENXIO) > return irq; > -- > 2.39.2 >
On Thu, Mar 9, 2023 at 5:16 AM Johan Hovold <johan+linaro@kernel.org> wrote: > > A recent commit added support for an optional interrupt which is only > available on some platforms. > > Stop spamming the logs with bogus error messages on platforms that do > not use this new optional resource: > > qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found > > Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic") > Cc: Guru Das Srinagesh <quic_gurus@quicinc.com> > Cc: Sibi Sankar <quic_sibis@quicinc.com> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/firmware/qcom_scm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index 468d4d5ab550..b1e11f85b805 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -1479,7 +1479,7 @@ static int qcom_scm_probe(struct platform_device *pdev) > > init_completion(&__scm->waitq_comp); > > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq < 0) { > if (irq != -ENXIO) > return irq; > -- > 2.39.2 > Thank you! Tested on the Thinkpad X13s Tested-by: Steev Klimaszewski <steev@kali.org> # Thinkpad X13s
Hey Johan, Thanks for the fix. On 3/9/23 16:42, Johan Hovold wrote: > A recent commit added support for an optional interrupt which is only > available on some platforms. > > Stop spamming the logs with bogus error messages on platforms that do > not use this new optional resource: > > qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found > > Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic") > Cc: Guru Das Srinagesh <quic_gurus@quicinc.com> > Cc: Sibi Sankar <quic_sibis@quicinc.com> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com> > --- > drivers/firmware/qcom_scm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index 468d4d5ab550..b1e11f85b805 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -1479,7 +1479,7 @@ static int qcom_scm_probe(struct platform_device *pdev) > > init_completion(&__scm->waitq_comp); > > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq < 0) { > if (irq != -ENXIO) > return irq;
On Thu, 9 Mar 2023 12:12:09 +0100, Johan Hovold wrote: > A recent commit added support for an optional interrupt which is only > available on some platforms. > > Stop spamming the logs with bogus error messages on platforms that do > not use this new optional resource: > > qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found > > [...] Applied, thanks! [1/1] firmware: qcom: scm: fix bogus irq error at probe commit: f3d0fbad6765da25de7ecf6481af9b6ddb0b3793 Best regards,
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 468d4d5ab550..b1e11f85b805 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -1479,7 +1479,7 @@ static int qcom_scm_probe(struct platform_device *pdev) init_completion(&__scm->waitq_comp); - irq = platform_get_irq(pdev, 0); + irq = platform_get_irq_optional(pdev, 0); if (irq < 0) { if (irq != -ENXIO) return irq;
A recent commit added support for an optional interrupt which is only available on some platforms. Stop spamming the logs with bogus error messages on platforms that do not use this new optional resource: qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic") Cc: Guru Das Srinagesh <quic_gurus@quicinc.com> Cc: Sibi Sankar <quic_sibis@quicinc.com> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/firmware/qcom_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)