[v2,0/2] crypto: inside-secure: Handle load errors better

Message

Jonathan McDowell Feb. 28, 2023, 6:28 p.m. UTC

2 minor patches to improve the error handling of the safexcel driver
when it fails to load.

Firstly, make it clear when the reason for a load failure is because the
firmware is not available.

Secondly, ensure we clean up the ring workqueues / IRQ affinity settings
to avoid a kernel warning when the driver fails to load.

v2:
 - Expand error clean up to cover ring initialisation failures

Jonathan McDowell (2):
  crypto: inside-secure: Raise firmware load failure message to error
  crypto: inside-secure - Cleanup ring IRQ workqueues on load failure

 drivers/crypto/inside-secure/safexcel.c | 39 ++++++++++++++++++-------
 1 file changed, 28 insertions(+), 11 deletions(-)

Comments

Herbert Xu March 10, 2023, 11:31 a.m. UTC | #1

On Tue, Feb 28, 2023 at 06:28:23PM +0000, Jonathan McDowell wrote:
> 2 minor patches to improve the error handling of the safexcel driver
> when it fails to load.
> 
> Firstly, make it clear when the reason for a load failure is because the
> firmware is not available.
> 
> Secondly, ensure we clean up the ring workqueues / IRQ affinity settings
> to avoid a kernel warning when the driver fails to load.
> 
> v2:
>  - Expand error clean up to cover ring initialisation failures
> 
> Jonathan McDowell (2):
>   crypto: inside-secure: Raise firmware load failure message to error
>   crypto: inside-secure - Cleanup ring IRQ workqueues on load failure
> 
>  drivers/crypto/inside-secure/safexcel.c | 39 ++++++++++++++++++-------
>  1 file changed, 28 insertions(+), 11 deletions(-)
> 
> -- 
> 2.39.2

All applied.  Thanks.