| Message ID | 20230312153429.371702-3-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/3] iio: dac: ad5755: mark OF related data as maybe unused | expand |
On Sun, 12 Mar 2023 16:34:29 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Always reference acpi_device_id and of_device_id tables, as they is > little benefit of conditional compiling and OF table could be used also > for ACPI matching via PRP0001. This fixes warning: > > drivers/iio/proximity/sx9500.c:1039:34: error: ‘sx9500_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > Applied Thanks, Jonathan > Changes since v1: > 1. Drop of_match_ptr and ACPI_PTR > --- > drivers/iio/proximity/sx9500.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c > index 8794e75e5bf9..9b2cfcade6a4 100644 > --- a/drivers/iio/proximity/sx9500.c > +++ b/drivers/iio/proximity/sx9500.c > @@ -1051,8 +1051,8 @@ MODULE_DEVICE_TABLE(i2c, sx9500_id); > static struct i2c_driver sx9500_driver = { > .driver = { > .name = SX9500_DRIVER_NAME, > - .acpi_match_table = ACPI_PTR(sx9500_acpi_match), > - .of_match_table = of_match_ptr(sx9500_of_match), > + .acpi_match_table = sx9500_acpi_match, > + .of_match_table = sx9500_of_match, > .pm = pm_sleep_ptr(&sx9500_pm_ops), > }, > .probe_new = sx9500_probe,
diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c index 8794e75e5bf9..9b2cfcade6a4 100644 --- a/drivers/iio/proximity/sx9500.c +++ b/drivers/iio/proximity/sx9500.c @@ -1051,8 +1051,8 @@ MODULE_DEVICE_TABLE(i2c, sx9500_id); static struct i2c_driver sx9500_driver = { .driver = { .name = SX9500_DRIVER_NAME, - .acpi_match_table = ACPI_PTR(sx9500_acpi_match), - .of_match_table = of_match_ptr(sx9500_of_match), + .acpi_match_table = sx9500_acpi_match, + .of_match_table = sx9500_of_match, .pm = pm_sleep_ptr(&sx9500_pm_ops), }, .probe_new = sx9500_probe,
Always reference acpi_device_id and of_device_id tables, as they is little benefit of conditional compiling and OF table could be used also for ACPI matching via PRP0001. This fixes warning: drivers/iio/proximity/sx9500.c:1039:34: error: ‘sx9500_of_match’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v1: 1. Drop of_match_ptr and ACPI_PTR --- drivers/iio/proximity/sx9500.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)