| Message ID | 20230310144724.1545223-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: sunxi: Use of_property_present() for testing DT property presence | expand |
On Fri, 10 Mar 2023 08:47:24 -0600 Rob Herring <robh@kernel.org> wrote: > It is preferred to use typed property access functions (i.e. > of_property_read_<type> functions) rather than low-level > of_get_property/of_find_property functions for reading properties. As > part of this, convert of_get_property/of_find_property calls to the > recently added of_property_present() helper when we just want to test > for presence of a property and nothing more. > > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > drivers/soc/sunxi/sunxi_mbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/sunxi/sunxi_mbus.c b/drivers/soc/sunxi/sunxi_mbus.c > index d90e4a264b6f..1734da357ca2 100644 > --- a/drivers/soc/sunxi/sunxi_mbus.c > +++ b/drivers/soc/sunxi/sunxi_mbus.c > @@ -82,7 +82,7 @@ static int sunxi_mbus_notifier(struct notifier_block *nb, > * Older DTs or SoCs who are not clearly understood need to set > * that DMA offset though. > */ > - if (of_find_property(dev->of_node, "interconnects", NULL)) > + if (of_property_present(dev->of_node, "interconnects")) > return NOTIFY_DONE; > > ret = dma_direct_set_offset(dev, PHYS_OFFSET, 0, SZ_4G);
Dne petek, 10. marec 2023 ob 15:47:24 CET je Rob Herring napisal(a): > It is preferred to use typed property access functions (i.e. > of_property_read_<type> functions) rather than low-level > of_get_property/of_find_property functions for reading properties. As > part of this, convert of_get_property/of_find_property calls to the > recently added of_property_present() helper when we just want to test > for presence of a property and nothing more. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/soc/sunxi/sunxi_mbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > diff --git a/drivers/soc/sunxi/sunxi_mbus.c b/drivers/soc/sunxi/sunxi_mbus.c > index d90e4a264b6f..1734da357ca2 100644 > --- a/drivers/soc/sunxi/sunxi_mbus.c > +++ b/drivers/soc/sunxi/sunxi_mbus.c > @@ -82,7 +82,7 @@ static int sunxi_mbus_notifier(struct notifier_block *nb, > * Older DTs or SoCs who are not clearly understood need to set > * that DMA offset though. > */ > - if (of_find_property(dev->of_node, "interconnects", NULL)) > + if (of_property_present(dev->of_node, "interconnects")) > return NOTIFY_DONE; > > ret = dma_direct_set_offset(dev, PHYS_OFFSET, 0, SZ_4G);
Dne petek, 10. marec 2023 ob 15:47:24 CET je Rob Herring napisal(a): > It is preferred to use typed property access functions (i.e. > of_property_read_<type> functions) rather than low-level > of_get_property/of_find_property functions for reading properties. As > part of this, convert of_get_property/of_find_property calls to the > recently added of_property_present() helper when we just want to test > for presence of a property and nothing more. > > Signed-off-by: Rob Herring <robh@kernel.org> Applied, thanks! Best regards, Jernej
diff --git a/drivers/soc/sunxi/sunxi_mbus.c b/drivers/soc/sunxi/sunxi_mbus.c index d90e4a264b6f..1734da357ca2 100644 --- a/drivers/soc/sunxi/sunxi_mbus.c +++ b/drivers/soc/sunxi/sunxi_mbus.c @@ -82,7 +82,7 @@ static int sunxi_mbus_notifier(struct notifier_block *nb, * Older DTs or SoCs who are not clearly understood need to set * that DMA offset though. */ - if (of_find_property(dev->of_node, "interconnects", NULL)) + if (of_property_present(dev->of_node, "interconnects")) return NOTIFY_DONE; ret = dma_direct_set_offset(dev, PHYS_OFFSET, 0, SZ_4G);
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more. Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/soc/sunxi/sunxi_mbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)