| Message ID | 1341575380-11972-1-git-send-email-keshava_mgowda@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jul 6, 2012 at 5:19 PM, Keshava Munegowda <keshava_mgowda@ti.com> wrote: > The usb host is disabled in the omap2 build; This is because > usb host is causing the retention to break in cpu idle. > > Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> > --- > arch/arm/configs/omap2plus_defconfig | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig > index 9854ff4..7b32da6 100644 > --- a/arch/arm/configs/omap2plus_defconfig > +++ b/arch/arm/configs/omap2plus_defconfig > @@ -170,17 +170,6 @@ CONFIG_SND_USB_AUDIO=m > CONFIG_SND_SOC=m > CONFIG_SND_OMAP_SOC=m > CONFIG_SND_OMAP_SOC_OMAP3_PANDORA=m > -CONFIG_USB=y > -CONFIG_USB_DEBUG=y > -CONFIG_USB_ANNOUNCE_NEW_DEVICES=y > -CONFIG_USB_DEVICEFS=y > -CONFIG_USB_SUSPEND=y > -CONFIG_USB_MON=y > -CONFIG_USB_EHCI_HCD=y > -CONFIG_USB_WDM=y > -CONFIG_USB_STORAGE=y > -CONFIG_USB_LIBUSUAL=y > -CONFIG_USB_TEST=y > CONFIG_USB_GADGET=y > CONFIG_USB_GADGET_DEBUG=y > CONFIG_USB_GADGET_DEBUG_FILES=y > -- > 1.7.9.5 > Sameo please merge this patch ; this makes the core retention to work in omap2plus_defconfig regards keshava -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 6, 2012 at 5:25 PM, Munegowda, Keshava <keshava_mgowda@ti.com> wrote: > On Fri, Jul 6, 2012 at 5:19 PM, Keshava Munegowda <keshava_mgowda@ti.com> wrote: >> The usb host is disabled in the omap2 build; This is because >> usb host is causing the retention to break in cpu idle. >> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> >> --- >> arch/arm/configs/omap2plus_defconfig | 11 ----------- >> 1 file changed, 11 deletions(-) >> >> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig >> index 9854ff4..7b32da6 100644 >> --- a/arch/arm/configs/omap2plus_defconfig >> +++ b/arch/arm/configs/omap2plus_defconfig >> @@ -170,17 +170,6 @@ CONFIG_SND_USB_AUDIO=m >> CONFIG_SND_SOC=m >> CONFIG_SND_OMAP_SOC=m >> CONFIG_SND_OMAP_SOC_OMAP3_PANDORA=m >> -CONFIG_USB=y >> -CONFIG_USB_DEBUG=y >> -CONFIG_USB_ANNOUNCE_NEW_DEVICES=y >> -CONFIG_USB_DEVICEFS=y >> -CONFIG_USB_SUSPEND=y >> -CONFIG_USB_MON=y >> -CONFIG_USB_EHCI_HCD=y >> -CONFIG_USB_WDM=y >> -CONFIG_USB_STORAGE=y >> -CONFIG_USB_LIBUSUAL=y >> -CONFIG_USB_TEST=y >> CONFIG_USB_GADGET=y >> CONFIG_USB_GADGET_DEBUG=y >> CONFIG_USB_GADGET_DEBUG_FILES=y >> -- >> 1.7.9.5 >> > > Sameo > please merge this patch ; this makes the core retention to work in > omap2plus_defconfig > If at all this patch has to be merged, it should be via Tony's tree, otherwise you might have merge conflicts. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 6, 2012 at 5:29 PM, Shilimkar, Santosh <santosh.shilimkar@ti.com> wrote: > On Fri, Jul 6, 2012 at 5:25 PM, Munegowda, Keshava > <keshava_mgowda@ti.com> wrote: >> On Fri, Jul 6, 2012 at 5:19 PM, Keshava Munegowda <keshava_mgowda@ti.com> wrote: >>> The usb host is disabled in the omap2 build; This is because >>> usb host is causing the retention to break in cpu idle. >>> >>> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> >>> --- >>> arch/arm/configs/omap2plus_defconfig | 11 ----------- >>> 1 file changed, 11 deletions(-) >>> >>> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig >>> index 9854ff4..7b32da6 100644 >>> --- a/arch/arm/configs/omap2plus_defconfig >>> +++ b/arch/arm/configs/omap2plus_defconfig >>> @@ -170,17 +170,6 @@ CONFIG_SND_USB_AUDIO=m >>> CONFIG_SND_SOC=m >>> CONFIG_SND_OMAP_SOC=m >>> CONFIG_SND_OMAP_SOC_OMAP3_PANDORA=m >>> -CONFIG_USB=y >>> -CONFIG_USB_DEBUG=y >>> -CONFIG_USB_ANNOUNCE_NEW_DEVICES=y >>> -CONFIG_USB_DEVICEFS=y >>> -CONFIG_USB_SUSPEND=y >>> -CONFIG_USB_MON=y >>> -CONFIG_USB_EHCI_HCD=y >>> -CONFIG_USB_WDM=y >>> -CONFIG_USB_STORAGE=y >>> -CONFIG_USB_LIBUSUAL=y >>> -CONFIG_USB_TEST=y >>> CONFIG_USB_GADGET=y >>> CONFIG_USB_GADGET_DEBUG=y >>> CONFIG_USB_GADGET_DEBUG_FILES=y >>> -- >>> 1.7.9.5 >>> >> >> Sameo >> please merge this patch ; this makes the core retention to work in >> omap2plus_defconfig >> > If at all this patch has to be merged, it should be via Tony's tree, > otherwise you > might have merge conflicts. > > Regards > Santosh Thanks Santosh looping Tony........ regards keshava -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Munegowda, Keshava <keshava_mgowda@ti.com> [120706 05:06]: > On Fri, Jul 6, 2012 at 5:29 PM, Shilimkar, Santosh > <santosh.shilimkar@ti.com> wrote: > > On Fri, Jul 6, 2012 at 5:25 PM, Munegowda, Keshava > > <keshava_mgowda@ti.com> wrote: > >> On Fri, Jul 6, 2012 at 5:19 PM, Keshava Munegowda <keshava_mgowda@ti.com> wrote: > >>> The usb host is disabled in the omap2 build; This is because > >>> usb host is causing the retention to break in cpu idle. ... > >> Sameo > >> please merge this patch ; this makes the core retention to work in > >> omap2plus_defconfig > >> > > If at all this patch has to be merged, it should be via Tony's tree, > > otherwise you > > might have merge conflicts. I think it's best to fix things properly, even if it means that it will take longer and go into next kernel version. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 6, 2012 at 5:37 PM, Tony Lindgren <tony@atomide.com> wrote: > * Munegowda, Keshava <keshava_mgowda@ti.com> [120706 05:06]: >> On Fri, Jul 6, 2012 at 5:29 PM, Shilimkar, Santosh >> <santosh.shilimkar@ti.com> wrote: >> > On Fri, Jul 6, 2012 at 5:25 PM, Munegowda, Keshava >> > <keshava_mgowda@ti.com> wrote: >> >> On Fri, Jul 6, 2012 at 5:19 PM, Keshava Munegowda <keshava_mgowda@ti.com> wrote: >> >>> The usb host is disabled in the omap2 build; This is because >> >>> usb host is causing the retention to break in cpu idle. > ... >> >> Sameo >> >> please merge this patch ; this makes the core retention to work in >> >> omap2plus_defconfig >> >> >> > If at all this patch has to be merged, it should be via Tony's tree, >> > otherwise you >> > might have merge conflicts. > > I think it's best to fix things properly, even if it means that it will > take longer and go into next kernel version. > > Tony Hi tony This requires ehci remote wakeup feature to be implemented, which will take at least to 3 months to get reviewed in opensource. hence for now kevin is also agreed to disable it by default; regards keshava -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Munegowda, Keshava <keshava_mgowda@ti.com> [120706 05:30]: > On Fri, Jul 6, 2012 at 5:37 PM, Tony Lindgren <tony@atomide.com> wrote: > > > > I think it's best to fix things properly, even if it means that it will > > take longer and go into next kernel version. > > This requires ehci remote wakeup feature to be implemented, which > will take at least to 3 months to > get reviewed in opensource. > hence for now kevin is also agreed to disable it by default; Why does echi need a "remote wakeup" feature? If you're talking about echi wake-up events, I don't see how that would affect core retention. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 6, 2012 at 6:09 PM, Tony Lindgren <tony@atomide.com> wrote: > * Munegowda, Keshava <keshava_mgowda@ti.com> [120706 05:30]: >> On Fri, Jul 6, 2012 at 5:37 PM, Tony Lindgren <tony@atomide.com> wrote: >> > >> > I think it's best to fix things properly, even if it means that it will >> > take longer and go into next kernel version. >> >> This requires ehci remote wakeup feature to be implemented, which >> will take at least to 3 months to >> get reviewed in opensource. >> hence for now kevin is also agreed to disable it by default; > > Why does echi need a "remote wakeup" feature? If you're talking about > echi wake-up events, I don't see how that would affect core retention. Hi Tony the cpu should hit the retention in idle; in this case, up on usb bus suspend ( no device connected) , if I cut the clock, then later device detection happen through I/O wakeup, so implementing the ehci remote wakeup using I/O chain handler ensure the retention in idle too. now, with the existing ehci driver in mainline, whether device connected or not the clocks are not cut and prevents the retention in idle. so, I need to implement the ehci clock gating mechanism through I/O interrupts in bus spend /resume . This activity will take some time. regards keshava -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig index 9854ff4..7b32da6 100644 --- a/arch/arm/configs/omap2plus_defconfig +++ b/arch/arm/configs/omap2plus_defconfig @@ -170,17 +170,6 @@ CONFIG_SND_USB_AUDIO=m CONFIG_SND_SOC=m CONFIG_SND_OMAP_SOC=m CONFIG_SND_OMAP_SOC_OMAP3_PANDORA=m -CONFIG_USB=y -CONFIG_USB_DEBUG=y -CONFIG_USB_ANNOUNCE_NEW_DEVICES=y -CONFIG_USB_DEVICEFS=y -CONFIG_USB_SUSPEND=y -CONFIG_USB_MON=y -CONFIG_USB_EHCI_HCD=y -CONFIG_USB_WDM=y -CONFIG_USB_STORAGE=y -CONFIG_USB_LIBUSUAL=y -CONFIG_USB_TEST=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DEBUG=y CONFIG_USB_GADGET_DEBUG_FILES=y
The usb host is disabled in the omap2 build; This is because usb host is causing the retention to break in cpu idle. Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> --- arch/arm/configs/omap2plus_defconfig | 11 ----------- 1 file changed, 11 deletions(-)