| Message ID | 20230223060543.2862661-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] arm64: dts: imx93: Fix eqos properties | expand |
> Subject: [PATCH 1/1] arm64: dts: imx93: Fix eqos properties > > 'macirq' is supposed to be listed first. Also only 'snps,clk-csr' is listed in the > bindings while 'clk_csr' is only supported for legacy reasons. See commit > 83936ea8d8ad2 ("net: stmmac: add a parse for new property 'snps,clk-csr'") > > Fixes: 1f4263ea6a4b ("arm64: dts: imx93: add eqos support") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> [Peng Fan] Reviewed-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx93.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi > b/arch/arm64/boot/dts/freescale/imx93.dtsi > index 4c70089d419f2..13ea4bfb97c68 100644 > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > @@ -666,9 +666,9 @@ usdhc2: mmc@42860000 { > eqos: ethernet@428a0000 { > compatible = "nxp,imx93-dwmac-eqos", > "snps,dwmac-5.10a"; > reg = <0x428a0000 0x10000>; > - interrupts = <GIC_SPI 183 > IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 184 > IRQ_TYPE_LEVEL_HIGH>; > - interrupt-names = "eth_wake_irq", "macirq"; > + interrupts = <GIC_SPI 184 > IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 183 > IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "macirq", "eth_wake_irq"; > clocks = <&clk > IMX93_CLK_ENET_QOS_GATE>, > <&clk > IMX93_CLK_ENET_QOS_GATE>, > <&clk IMX93_CLK_ENET_TIMER2>, > @@ -681,7 +681,7 @@ eqos: ethernet@428a0000 { > <&clk > IMX93_CLK_SYS_PLL_PFD0_DIV2>; > assigned-clock-rates = <100000000>, > <250000000>; > intf_mode = <&wakeupmix_gpr 0x28>; > - clk_csr = <0>; > + snps,clk-csr = <0>; > status = "disabled"; > }; > > -- > 2.34.1
On Thu, Feb 23, 2023 at 07:05:43AM +0100, Alexander Stein wrote: > 'macirq' is supposed to be listed first. Also only 'snps,clk-csr' is > listed in the bindings while 'clk_csr' is only supported for legacy > reasons. See commit 83936ea8d8ad2 ("net: stmmac: add a parse for new > property 'snps,clk-csr'") > > Fixes: 1f4263ea6a4b ("arm64: dts: imx93: add eqos support") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Applied, thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi index 4c70089d419f2..13ea4bfb97c68 100644 --- a/arch/arm64/boot/dts/freescale/imx93.dtsi +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi @@ -666,9 +666,9 @@ usdhc2: mmc@42860000 { eqos: ethernet@428a0000 { compatible = "nxp,imx93-dwmac-eqos", "snps,dwmac-5.10a"; reg = <0x428a0000 0x10000>; - interrupts = <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "eth_wake_irq", "macirq"; + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq", "eth_wake_irq"; clocks = <&clk IMX93_CLK_ENET_QOS_GATE>, <&clk IMX93_CLK_ENET_QOS_GATE>, <&clk IMX93_CLK_ENET_TIMER2>, @@ -681,7 +681,7 @@ eqos: ethernet@428a0000 { <&clk IMX93_CLK_SYS_PLL_PFD0_DIV2>; assigned-clock-rates = <100000000>, <250000000>; intf_mode = <&wakeupmix_gpr 0x28>; - clk_csr = <0>; + snps,clk-csr = <0>; status = "disabled"; };
'macirq' is supposed to be listed first. Also only 'snps,clk-csr' is listed in the bindings while 'clk_csr' is only supported for legacy reasons. See commit 83936ea8d8ad2 ("net: stmmac: add a parse for new property 'snps,clk-csr'") Fixes: 1f4263ea6a4b ("arm64: dts: imx93: add eqos support") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- arch/arm64/boot/dts/freescale/imx93.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)