| Message ID | 20230308092420.2742432-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] arm64: dts: imx8mp: fix address length for LCDIF2 | expand |
On Wed, Mar 08, 2023 at 10:24:19AM +0100, Alexander Stein wrote: > 0x238 is the offset for PANIC0_THRES, so the length needs to be 4 bytes > greater than that. > > Fixes: 94e6197dadc9 ("arm64: dts: imx8mp: Add LCDIF2 & LDB nodes") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Does it make sense to increase the length to 0x10000 instead which > is the size mentioned in the memory map in the RM? Makes sense to me. Shawn > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index a19224fe1a6a..722e36d7b420 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1128,7 +1128,7 @@ aips4: bus@32c00000 { > > lcdif2: display-controller@32e90000 { > compatible = "fsl,imx8mp-lcdif"; > - reg = <0x32e90000 0x238>; > + reg = <0x32e90000 0x23c>; > interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&clk IMX8MP_CLK_MEDIA_DISP2_PIX_ROOT>, > <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, > -- > 2.34.1 >
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index a19224fe1a6a..722e36d7b420 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -1128,7 +1128,7 @@ aips4: bus@32c00000 { lcdif2: display-controller@32e90000 { compatible = "fsl,imx8mp-lcdif"; - reg = <0x32e90000 0x238>; + reg = <0x32e90000 0x23c>; interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clk IMX8MP_CLK_MEDIA_DISP2_PIX_ROOT>, <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>,
0x238 is the offset for PANIC0_THRES, so the length needs to be 4 bytes greater than that. Fixes: 94e6197dadc9 ("arm64: dts: imx8mp: Add LCDIF2 & LDB nodes") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Does it make sense to increase the length to 0x10000 instead which is the size mentioned in the memory map in the RM? arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)