| Message ID | 20230314041515.15883-3-quic_kathirav@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | rework mailbox compatibles for Qualcomm IPQ SoCs | expand |
On 14/03/2023 05:15, Kathiravan T wrote: > Since the IPQ8074 and IPQ5332 mailbox are compatible with IPQ6018, we can > use the compatible fallback to IPQ6018. With that, we can drop the > IPQ8074 and IPQ5332 compatible references, as well we don't bloat the > of_device_id table. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> NAK. Breaks ABI and duplicates what I already sent (which you saw since you took my patches from my thread). https://lore.kernel.org/all/20230202161856.385825-4-krzysztof.kozlowski@linaro.org/ Best regards, Krzysztof
diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c index 6bbf87c6d60b..3906bd655991 100644 --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c @@ -141,9 +141,7 @@ static int qcom_apcs_ipc_remove(struct platform_device *pdev) /* .data is the offset of the ipc register within the global block */ static const struct of_device_id qcom_apcs_ipc_of_match[] = { - { .compatible = "qcom,ipq5332-apcs-apps-global", .data = &ipq6018_apcs_data }, { .compatible = "qcom,ipq6018-apcs-apps-global", .data = &ipq6018_apcs_data }, - { .compatible = "qcom,ipq8074-apcs-apps-global", .data = &ipq6018_apcs_data }, { .compatible = "qcom,msm8916-apcs-kpss-global", .data = &msm8916_apcs_data }, { .compatible = "qcom,msm8939-apcs-kpss-global", .data = &msm8916_apcs_data }, { .compatible = "qcom,msm8953-apcs-kpss-global", .data = &msm8994_apcs_data },
Since the IPQ8074 and IPQ5332 mailbox are compatible with IPQ6018, we can use the compatible fallback to IPQ6018. With that, we can drop the IPQ8074 and IPQ5332 compatible references, as well we don't bloat the of_device_id table. Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 -- 1 file changed, 2 deletions(-)