[0/5] thunderbolt: A couple of fixes

Message

Mika Westerberg March 6, 2023, 11:36 a.m. UTC

Hi,

This series includes a couple of fixes for issues found. I'm planning to
get these into v6.3-rc.

The first one is a memory leak fix.

The second one is fixing a reboot time issue reported by Christian that
we finally were able to reproduce in the lab. The reason this happened
only in Linux is that we enumerate retimers during link bring up and
there is certain step missing after the enumeration that leads the link
to not come up properly after soft-reboot. This should be fixed with
issuing UNSET_INBOUND_SBTX after retimer access and this works in the
lab.

@Christian, can you check that it solves the issue for you too?

The third one is a quirk that is needed for Intel hardware to limit the
USB3 bandwidth accordingly.

Gil Fine (2):
  thunderbolt: Add missing UNSET_INBOUND_SBTX for retimer access
  thunderbolt: Limit USB3 bandwidth of certain Intel USB4 host routers

Mika Westerberg (3):
  thunderbolt: Fix memory leak in margining
  thunderbolt: Call tb_check_quirks() after initializing adapters
  thunderbolt: Use scale field when allocating USB3 bandwidth

 drivers/thunderbolt/debugfs.c | 12 ++++----
 drivers/thunderbolt/quirks.c  | 31 ++++++++++++++++++++
 drivers/thunderbolt/retimer.c | 23 +++++++++++++--
 drivers/thunderbolt/sb_regs.h |  1 +
 drivers/thunderbolt/switch.c  |  4 +--
 drivers/thunderbolt/tb.h      |  4 +++
 drivers/thunderbolt/usb4.c    | 53 ++++++++++++++++++++++++++++++-----
 7 files changed, 111 insertions(+), 17 deletions(-)

Comments

Mika Westerberg March 13, 2023, 10:07 a.m. UTC | #1

On Mon, Mar 06, 2023 at 01:36:00PM +0200, Mika Westerberg wrote:
> Hi,
> 
> This series includes a couple of fixes for issues found. I'm planning to
> get these into v6.3-rc.
> 
> The first one is a memory leak fix.
> 
> The second one is fixing a reboot time issue reported by Christian that
> we finally were able to reproduce in the lab. The reason this happened
> only in Linux is that we enumerate retimers during link bring up and
> there is certain step missing after the enumeration that leads the link
> to not come up properly after soft-reboot. This should be fixed with
> issuing UNSET_INBOUND_SBTX after retimer access and this works in the
> lab.
> 
> @Christian, can you check that it solves the issue for you too?
> 
> The third one is a quirk that is needed for Intel hardware to limit the
> USB3 bandwidth accordingly.
> 
> Gil Fine (2):
>   thunderbolt: Add missing UNSET_INBOUND_SBTX for retimer access
>   thunderbolt: Limit USB3 bandwidth of certain Intel USB4 host routers
> 
> Mika Westerberg (3):
>   thunderbolt: Fix memory leak in margining
>   thunderbolt: Call tb_check_quirks() after initializing adapters
>   thunderbolt: Use scale field when allocating USB3 bandwidth

Fixed the typo reported by Yehezkel and applied all to
thunderbolt.git/fixes.

Christian Schaubschläger March 13, 2023, 1:07 p.m. UTC | #2

Hi Mika,


>> The second one is fixing a reboot time issue reported by Christian that
>> we finally were able to reproduce in the lab. The reason this happened
>> only in Linux is that we enumerate retimers during link bring up and
>> there is certain step missing after the enumeration that leads the link
>> to not come up properly after soft-reboot. This should be fixed with
>> issuing UNSET_INBOUND_SBTX after retimer access and this works in the
>> lab.
>>
>> @Christian, can you check that it solves the issue for you too?

I was told today that the patch solves the issue on the Elitebook!
(don't have the hardware here in my office any more...).

Thanks for fixing this!
Best regards,
Christian

Mika Westerberg March 14, 2023, 7:32 a.m. UTC | #3

On Mon, Mar 13, 2023 at 02:07:41PM +0100, Christian Schaubschläger wrote:
> Hi Mika,
> 
> 
> > > The second one is fixing a reboot time issue reported by Christian that
> > > we finally were able to reproduce in the lab. The reason this happened
> > > only in Linux is that we enumerate retimers during link bring up and
> > > there is certain step missing after the enumeration that leads the link
> > > to not come up properly after soft-reboot. This should be fixed with
> > > issuing UNSET_INBOUND_SBTX after retimer access and this works in the
> > > lab.
> > > 
> > > @Christian, can you check that it solves the issue for you too?
> 
> I was told today that the patch solves the issue on the Elitebook!

Okay good to know :)