[net,0/4] net: ipa: minor bug fixes

Message

Alex Elder March 14, 2023, 8:38 p.m. UTC

The four patches in this series fix some errors, though none of them
cause any compile or runtime problems.

The first changes the files included by "drivers/net/ipa/reg.h" to
ensure everything it requires is included with the file.  It also
stops unnecessarily including another file.  The prerequisites are
apparently satisfied other ways, currently.

The second adds two struct declarations to "gsi_reg.h", to ensure
they're declared before they're used later in the file.  Again, it
seems these declarations are currently resolved wherever this file
is included.

The third removes register definitions that were added for IPA v5.0
that are not needed.  And the last updates some validity checks for
IPA v5.0 registers.  No IPA v5.0 platforms are yet supported, so the
issues resolved here were never harmful.

					-Alex

Alex Elder (4):
  net: ipa: reg: include <linux/bug.h>
  net: ipa: add two missing declarations
  net: ipa: kill FILT_ROUT_CACHE_CFG IPA register
  net: ipa: fix some register validity checks

 drivers/net/ipa/gsi_reg.c |  9 ++++++++-
 drivers/net/ipa/gsi_reg.h |  4 ++++
 drivers/net/ipa/ipa_reg.c | 28 ++++++++++++++++++----------
 drivers/net/ipa/ipa_reg.h | 21 ++++++---------------
 drivers/net/ipa/reg.h     |  3 ++-
 5 files changed, 38 insertions(+), 27 deletions(-)

Comments

Alex Elder March 14, 2023, 9:23 p.m. UTC | #1

On 3/14/23 3:38 PM, Alex Elder wrote:
> The four patches in this series fix some errors, though none of them
> cause any compile or runtime problems.
> 
> The first changes the files included by "drivers/net/ipa/reg.h" to
> ensure everything it requires is included with the file.  It also
> stops unnecessarily including another file.  The prerequisites are
> apparently satisfied other ways, currently.
> 
> The second adds two struct declarations to "gsi_reg.h", to ensure
> they're declared before they're used later in the file.  Again, it
> seems these declarations are currently resolved wherever this file
> is included.
> 
> The third removes register definitions that were added for IPA v5.0
> that are not needed.  And the last updates some validity checks for
> IPA v5.0 registers.  No IPA v5.0 platforms are yet supported, so the
> issues resolved here were never harmful.

Sorry, it seems I used the wrong hashes in some
of my "Fixes" tags.  I will post v2 of this series
tomorrow.

					-Alex


> 					-Alex
> 
> Alex Elder (4):
>    net: ipa: reg: include <linux/bug.h>
>    net: ipa: add two missing declarations
>    net: ipa: kill FILT_ROUT_CACHE_CFG IPA register
>    net: ipa: fix some register validity checks
> 
>   drivers/net/ipa/gsi_reg.c |  9 ++++++++-
>   drivers/net/ipa/gsi_reg.h |  4 ++++
>   drivers/net/ipa/ipa_reg.c | 28 ++++++++++++++++++----------
>   drivers/net/ipa/ipa_reg.h | 21 ++++++---------------
>   drivers/net/ipa/reg.h     |  3 ++-
>   5 files changed, 38 insertions(+), 27 deletions(-)
>