| Message ID | 20230106185700.28744-1-babu.moger@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | target/i386: Update AMD EPYC CPU Models | expand |
On Fri, Jan 06, 2023 at 12:56:55PM -0600, Babu Moger wrote: > This series adds following changes. > a. Allow versioned CPUs to specify new cache_info pointers. > b. Add EPYC-v4, EPYC-Rome-v3 and EPYC-Milan-v2 fixing the > cache_info.complex_indexing. > c. Introduce EPYC-Milan-v2 by adding few missing feature bits. Acked-by: Michael S. Tsirkin <mst@redhat.com> who's merging this btw? target/i386/cpu.c doesn't have an official maintainer in MAINTAINERS ... > --- > v2: > Refreshed the patches on top of latest master. > Changed the feature NULL_SELECT_CLEARS_BASE to NULL_SEL_CLR_BASE to > match the kernel name. > https://lore.kernel.org/kvm/20221205233235.622491-3-kim.phillips@amd.com/ > > v1: https://lore.kernel.org/kvm/167001034454.62456.7111414518087569436.stgit@bmoger-ubuntu/ > > > Babu Moger (3): > target/i386: Add a couple of feature bits in 8000_0008_EBX > target/i386: Add feature bits for CPUID_Fn80000021_EAX > target/i386: Add missing feature bits in EPYC-Milan model > > Michael Roth (2): > target/i386: allow versioned CPUs to specify new cache_info > target/i386: Add new EPYC CPU versions with updated cache_info > > target/i386/cpu.c | 252 +++++++++++++++++++++++++++++++++++++++++++++- > target/i386/cpu.h | 12 +++ > 2 files changed, 259 insertions(+), 5 deletions(-) > > -- > 2.34.1
> -----Original Message----- > From: Michael S. Tsirkin <mst@redhat.com> > Sent: Friday, January 27, 2023 6:53 AM > To: Moger, Babu <Babu.Moger@amd.com> > Cc: pbonzini@redhat.com; mtosatti@redhat.com; kvm@vger.kernel.org; > marcel.apfelbaum@gmail.com; imammedo@redhat.com; > richard.henderson@linaro.org; yang.zhong@intel.com; jing2.liu@intel.com; > vkuznets@redhat.com; Roth, Michael <Michael.Roth@amd.com>; Huang2, Wei > <Wei.Huang2@amd.com> > Subject: Re: [PATCH v2 0/5] target/i386: Update AMD EPYC CPU Models > > On Fri, Jan 06, 2023 at 12:56:55PM -0600, Babu Moger wrote: > > This series adds following changes. > > a. Allow versioned CPUs to specify new cache_info pointers. > > b. Add EPYC-v4, EPYC-Rome-v3 and EPYC-Milan-v2 fixing the > > cache_info.complex_indexing. > > c. Introduce EPYC-Milan-v2 by adding few missing feature bits. > > Acked-by: Michael S. Tsirkin <mst@redhat.com> Michael, Thank you > > who's merging this btw? > target/i386/cpu.c doesn't have an official maintainer in MAINTAINERS ... I thought Paolo might pick this up. Thanks Babu > > > --- > > v2: > > Refreshed the patches on top of latest master. > > Changed the feature NULL_SELECT_CLEARS_BASE to NULL_SEL_CLR_BASE > to > > match the kernel name. > > https://lore.kernel.org/kvm/20221205233235.622491-3- > kim.phillips@amd.com/ > > > > v1: > https://lore.kernel.org/kvm/167001034454.62456.7111414518087569436.stgit > @bmoger-ubuntu/ > > > > > > Babu Moger (3): > > target/i386: Add a couple of feature bits in 8000_0008_EBX > > target/i386: Add feature bits for CPUID_Fn80000021_EAX > > target/i386: Add missing feature bits in EPYC-Milan model > > > > Michael Roth (2): > > target/i386: allow versioned CPUs to specify new cache_info > > target/i386: Add new EPYC CPU versions with updated cache_info > > > > target/i386/cpu.c | 252 > +++++++++++++++++++++++++++++++++++++++++++++- > > target/i386/cpu.h | 12 +++ > > 2 files changed, 259 insertions(+), 5 deletions(-) > > > > -- > > 2.34.1
Gentle ping again. Hope this patch doesn't get lost. Thanks Babu On 1/31/23 14:21, Moger, Babu wrote: > >> -----Original Message----- >> From: Michael S. Tsirkin <mst@redhat.com> >> Sent: Friday, January 27, 2023 6:53 AM >> To: Moger, Babu <Babu.Moger@amd.com> >> Cc: pbonzini@redhat.com; mtosatti@redhat.com; kvm@vger.kernel.org; >> marcel.apfelbaum@gmail.com; imammedo@redhat.com; >> richard.henderson@linaro.org; yang.zhong@intel.com; jing2.liu@intel.com; >> vkuznets@redhat.com; Roth, Michael <Michael.Roth@amd.com>; Huang2, Wei >> <Wei.Huang2@amd.com> >> Subject: Re: [PATCH v2 0/5] target/i386: Update AMD EPYC CPU Models >> >> On Fri, Jan 06, 2023 at 12:56:55PM -0600, Babu Moger wrote: >> > This series adds following changes. >> > a. Allow versioned CPUs to specify new cache_info pointers. >> > b. Add EPYC-v4, EPYC-Rome-v3 and EPYC-Milan-v2 fixing the >> > cache_info.complex_indexing. >> > c. Introduce EPYC-Milan-v2 by adding few missing feature bits. >> >> Acked-by: Michael S. Tsirkin <mst@redhat.com> > > Michael, Thank you > >> >> who's merging this btw? >> target/i386/cpu.c doesn't have an official maintainer in MAINTAINERS ... > > I thought Paolo might pick this up. > > Thanks > Babu > >> >> > --- >> > v2: >> > Refreshed the patches on top of latest master. >> > Changed the feature NULL_SELECT_CLEARS_BASE to NULL_SEL_CLR_BASE >> to >> > match the kernel name. >> > https://lore.kernel.org/kvm/20221205233235.622491-3- >> kim.phillips@amd.com/ >> > >> > v1: >> https://lore.kernel.org/kvm/167001034454.62456.7111414518087569436.stgit >> @bmoger-ubuntu/ >> > >> > >> > Babu Moger (3): >> > target/i386: Add a couple of feature bits in 8000_0008_EBX >> > target/i386: Add feature bits for CPUID_Fn80000021_EAX >> > target/i386: Add missing feature bits in EPYC-Milan model >> > >> > Michael Roth (2): >> > target/i386: allow versioned CPUs to specify new cache_info >> > target/i386: Add new EPYC CPU versions with updated cache_info >> > >> > target/i386/cpu.c | 252 >> +++++++++++++++++++++++++++++++++++++++++++++- >> > target/i386/cpu.h | 12 +++ >> > 2 files changed, 259 insertions(+), 5 deletions(-) >> > >> > -- >> > 2.34.1 >
Hi Paolo, Any plans to merge these patches to v8.0 release. Thanks Babu On 3/1/23 14:01, Moger, Babu wrote: > Gentle ping again. Hope this patch doesn't get lost. > Thanks > Babu > > On 1/31/23 14:21, Moger, Babu wrote: >> >>> -----Original Message----- >>> From: Michael S. Tsirkin <mst@redhat.com> >>> Sent: Friday, January 27, 2023 6:53 AM >>> To: Moger, Babu <Babu.Moger@amd.com> >>> Cc: pbonzini@redhat.com; mtosatti@redhat.com; kvm@vger.kernel.org; >>> marcel.apfelbaum@gmail.com; imammedo@redhat.com; >>> richard.henderson@linaro.org; yang.zhong@intel.com; jing2.liu@intel.com; >>> vkuznets@redhat.com; Roth, Michael <Michael.Roth@amd.com>; Huang2, Wei >>> <Wei.Huang2@amd.com> >>> Subject: Re: [PATCH v2 0/5] target/i386: Update AMD EPYC CPU Models >>> >>> On Fri, Jan 06, 2023 at 12:56:55PM -0600, Babu Moger wrote: >>>> This series adds following changes. >>>> a. Allow versioned CPUs to specify new cache_info pointers. >>>> b. Add EPYC-v4, EPYC-Rome-v3 and EPYC-Milan-v2 fixing the >>>> cache_info.complex_indexing. >>>> c. Introduce EPYC-Milan-v2 by adding few missing feature bits. >>> >>> Acked-by: Michael S. Tsirkin <mst@redhat.com> >> >> Michael, Thank you >> >>> >>> who's merging this btw? >>> target/i386/cpu.c doesn't have an official maintainer in MAINTAINERS ... >> >> I thought Paolo might pick this up. >> >> Thanks >> Babu >> >>> >>>> --- >>>> v2: >>>> Refreshed the patches on top of latest master. >>>> Changed the feature NULL_SELECT_CLEARS_BASE to NULL_SEL_CLR_BASE >>> to >>>> match the kernel name. >>>> https://lore.kernel.org/kvm/20221205233235.622491-3- >>> kim.phillips@amd.com/ >>>> >>>> v1: >>> https://lore.kernel.org/kvm/167001034454.62456.7111414518087569436.stgit >>> @bmoger-ubuntu/ >>>> >>>> >>>> Babu Moger (3): >>>> target/i386: Add a couple of feature bits in 8000_0008_EBX >>>> target/i386: Add feature bits for CPUID_Fn80000021_EAX >>>> target/i386: Add missing feature bits in EPYC-Milan model >>>> >>>> Michael Roth (2): >>>> target/i386: allow versioned CPUs to specify new cache_info >>>> target/i386: Add new EPYC CPU versions with updated cache_info >>>> >>>> target/i386/cpu.c | 252 >>> +++++++++++++++++++++++++++++++++++++++++++++- >>>> target/i386/cpu.h | 12 +++ >>>> 2 files changed, 259 insertions(+), 5 deletions(-) >>>> >>>> -- >>>> 2.34.1 >> >