| Message ID | 20230315181902.4177819-3-joel@joelfernandes.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cae16f2c2e11c60c888715f4d98c12740683d6a2 |
| Headers | show |
| Series | None | expand |
On 3/15/23 19:18, Joel Fernandes (Google) wrote: > From: "Uladzislau Rezki (Sony)" <urezki@gmail.com> > > The kvfree_rcu() macro's single-argument form is deprecated. Therefore > switch to the new kvfree_rcu_mightsleep() variant. The goal is to > avoid accidental use of the single-argument forms, which can introduce > functionality bugs in atomic contexts and latency bugs in non-atomic > contexts. > > Cc: Steven Rostedt (VMware) <rostedt@goodmis.org> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > --- > kernel/trace/trace_osnoise.c | 2 +- > kernel/trace/trace_probe.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c > index 04f0fdae19a1..f68ca1e6460f 100644 > --- a/kernel/trace/trace_osnoise.c > +++ b/kernel/trace/trace_osnoise.c > @@ -159,7 +159,7 @@ static void osnoise_unregister_instance(struct trace_array *tr) > if (!found) > return; > > - kvfree_rcu(inst); > + kvfree_rcu_mightsleep(inst); > } > > /* Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org> Thanks! -- Daniel
On Thu, Mar 16, 2023 at 3:38 AM Daniel Bristot de Oliveira <bristot@kernel.org> wrote: > > On 3/15/23 19:18, Joel Fernandes (Google) wrote: > > From: "Uladzislau Rezki (Sony)" <urezki@gmail.com> > > > > The kvfree_rcu() macro's single-argument form is deprecated. Therefore > > switch to the new kvfree_rcu_mightsleep() variant. The goal is to > > avoid accidental use of the single-argument forms, which can introduce > > functionality bugs in atomic contexts and latency bugs in non-atomic > > contexts. > > > > Cc: Steven Rostedt (VMware) <rostedt@goodmis.org> > > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > > --- > > kernel/trace/trace_osnoise.c | 2 +- > > kernel/trace/trace_probe.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c > > index 04f0fdae19a1..f68ca1e6460f 100644 > > --- a/kernel/trace/trace_osnoise.c > > +++ b/kernel/trace/trace_osnoise.c > > @@ -159,7 +159,7 @@ static void osnoise_unregister_instance(struct trace_array *tr) > > if (!found) > > return; > > > > - kvfree_rcu(inst); > > + kvfree_rcu_mightsleep(inst); > > } > > > > /* > > Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org> Thanks! - Joel
diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index 04f0fdae19a1..f68ca1e6460f 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -159,7 +159,7 @@ static void osnoise_unregister_instance(struct trace_array *tr) if (!found) return; - kvfree_rcu(inst); + kvfree_rcu_mightsleep(inst); } /* diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c index 20d0c4a97633..2d2616678295 100644 --- a/kernel/trace/trace_probe.c +++ b/kernel/trace/trace_probe.c @@ -1172,7 +1172,7 @@ int trace_probe_remove_file(struct trace_probe *tp, return -ENOENT; list_del_rcu(&link->list); - kvfree_rcu(link); + kvfree_rcu_mightsleep(link); if (list_empty(&tp->event->files)) trace_probe_clear_flag(tp, TP_FLAG_TRACE);