| Message ID | 20230314134642.21535-1-clin@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | pinctrl: s32: driver improvements and generic struct use | expand |
On Tue, Mar 14, 2023 at 3:46 PM Chester Lin <clin@suse.com> wrote: > > Hello, > > This patch series contains some improvements for s32 pinctrl drivers suggested > by upstream[1], such as > > - Fix error shadowings and improve return value handlings. > - Fix print format. > - Remove unnecessary blanks. > - Use proper macros and helpers to simplify codes. > - Refactor config param parsing and remove config arguments that are never used. > - Use generic struct pingroup and struct pinfunction to describe pin data. Overall it looks not bad, thank you for doing this. Individual patches have been reviewed and commented accordingly.
Hi Andy, On Tue, Mar 14, 2023 at 07:21:55PM +0200, Andy Shevchenko wrote: > On Tue, Mar 14, 2023 at 3:46 PM Chester Lin <clin@suse.com> wrote: > > > > Hello, > > > > This patch series contains some improvements for s32 pinctrl drivers suggested > > by upstream[1], such as > > > > - Fix error shadowings and improve return value handlings. > > - Fix print format. > > - Remove unnecessary blanks. > > - Use proper macros and helpers to simplify codes. > > - Refactor config param parsing and remove config arguments that are never used. > > - Use generic struct pingroup and struct pinfunction to describe pin data. > > Overall it looks not bad, thank you for doing this. > Individual patches have been reviewed and commented accordingly. Thank you for reviewing this patch. I will fix the rest in v2 soon. Regards, Chester > > -- > With Best Regards, > Andy Shevchenko
Hello, This patch series contains some improvements for s32 pinctrl drivers suggested by upstream[1], such as - Fix error shadowings and improve return value handlings. - Fix print format. - Remove unnecessary blanks. - Use proper macros and helpers to simplify codes. - Refactor config param parsing and remove config arguments that are never used. - Use generic struct pingroup and struct pinfunction to describe pin data. Regards, Chester [1] https://lore.kernel.org/all/20230220023320.3499-1-clin@suse.com/ Chester Lin (3): pinctrl: s32: refine error/return/config checks and simplify driver codes pinctrl: s32cc: refactor pin config parsing pinctrl: s32cc: embed generic struct pingroup and pinfunction drivers/pinctrl/nxp/pinctrl-s32.h | 22 +-- drivers/pinctrl/nxp/pinctrl-s32cc.c | 283 ++++++++++++++++------------ drivers/pinctrl/nxp/pinctrl-s32g2.c | 8 +- 3 files changed, 168 insertions(+), 145 deletions(-)