| Message ID | 20230311090733.56918-7-hal.feng@starfivetech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Basic clock, reset & device tree support for StarFive JH7110 RISC-V SoC | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 1 and now 1 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 18 this patch: 18 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 18 this patch: 18 |
| conchuod/alphanumeric_selects | success | Out of order selects before the patch: 728 and now 728 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 3 this patch: 3 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | warning | WARNING: please write a help paragraph that fully describes the config symbol |
| conchuod/source_inline | success | Was 0 now: 0 |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Sa, 2023-03-11 at 17:07 +0800, Hal Feng wrote: > From: Emil Renner Berthing <kernel@esmil.dk> > > This moves the StarFive JH7100 reset driver to a new subdirectory in > preparation for adding more StarFive reset drivers. > > Tested-by: Tommaso Merciai <tomm.merciai@gmail.com> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > --- > MAINTAINERS | 2 +- > drivers/reset/Kconfig | 8 +------- > drivers/reset/Makefile | 2 +- > drivers/reset/starfive/Kconfig | 8 ++++++++ > drivers/reset/starfive/Makefile | 2 ++ > drivers/reset/{ => starfive}/reset-starfive-jh7100.c | 0 > 6 files changed, 13 insertions(+), 9 deletions(-) > create mode 100644 drivers/reset/starfive/Kconfig > create mode 100644 drivers/reset/starfive/Makefile > rename drivers/reset/{ => starfive}/reset-starfive-jh7100.c (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index caba3b61ad5c..87f210e357ca 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19940,7 +19940,7 @@ STARFIVE JH7100 RESET CONTROLLER DRIVER > M: Emil Renner Berthing <kernel@esmil.dk> > S: Maintained > F: Documentation/devicetree/bindings/reset/starfive,jh7100-reset.yaml > -F: drivers/reset/reset-starfive-jh7100.c > +F: drivers/reset/starfive/reset-starfive-jh7100.c > F: include/dt-bindings/reset/starfive-jh7100.h > > > > > STARFIVE JH71XX PMU CONTROLLER DRIVER > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > index 6ae5aa46a6b2..6aa8f243b30c 100644 > --- a/drivers/reset/Kconfig > +++ b/drivers/reset/Kconfig > @@ -232,13 +232,6 @@ config RESET_SOCFPGA > This enables the reset driver for the SoCFPGA ARMv7 platforms. This > driver gets initialized early during platform init calls. > > > > > -config RESET_STARFIVE_JH7100 > - bool "StarFive JH7100 Reset Driver" > - depends on ARCH_STARFIVE || COMPILE_TEST > - default ARCH_STARFIVE > - help > - This enables the reset controller driver for the StarFive JH7100 SoC. > - > config RESET_SUNPLUS > bool "Sunplus SoCs Reset Driver" if COMPILE_TEST > default ARCH_SUNPLUS > @@ -320,6 +313,7 @@ config RESET_ZYNQ > help > This enables the reset controller driver for Xilinx Zynq SoCs. > > > > > +source "drivers/reset/starfive/Kconfig" > source "drivers/reset/sti/Kconfig" > source "drivers/reset/hisilicon/Kconfig" > source "drivers/reset/tegra/Kconfig" > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile > index 3e7e5fd633a8..719b8f6f84bc 100644 > --- a/drivers/reset/Makefile > +++ b/drivers/reset/Makefile > @@ -1,6 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > obj-y += core.o > obj-y += hisilicon/ > +obj-$(CONFIG_ARCH_STARFIVE) += starfive/ This should really be obj-y, otherwise this won't compile with COMPILE_TEST=y but ARCH_STARFIVE=n. With that fixed, Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
On Tue, 14 Mar 2023 15:34:26 +0100, Philipp Zabel wrote: > On Sa, 2023-03-11 at 17:07 +0800, Hal Feng wrote: >> From: Emil Renner Berthing <kernel@esmil.dk> >> >> This moves the StarFive JH7100 reset driver to a new subdirectory in >> preparation for adding more StarFive reset drivers. >> >> Tested-by: Tommaso Merciai <tomm.merciai@gmail.com> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> >> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> >> Signed-off-by: Hal Feng <hal.feng@starfivetech.com> >> --- >> MAINTAINERS | 2 +- >> drivers/reset/Kconfig | 8 +------- >> drivers/reset/Makefile | 2 +- >> drivers/reset/starfive/Kconfig | 8 ++++++++ >> drivers/reset/starfive/Makefile | 2 ++ >> drivers/reset/{ => starfive}/reset-starfive-jh7100.c | 0 >> 6 files changed, 13 insertions(+), 9 deletions(-) >> create mode 100644 drivers/reset/starfive/Kconfig >> create mode 100644 drivers/reset/starfive/Makefile >> rename drivers/reset/{ => starfive}/reset-starfive-jh7100.c (100%) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index caba3b61ad5c..87f210e357ca 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -19940,7 +19940,7 @@ STARFIVE JH7100 RESET CONTROLLER DRIVER >> M: Emil Renner Berthing <kernel@esmil.dk> >> S: Maintained >> F: Documentation/devicetree/bindings/reset/starfive,jh7100-reset.yaml >> -F: drivers/reset/reset-starfive-jh7100.c >> +F: drivers/reset/starfive/reset-starfive-jh7100.c >> F: include/dt-bindings/reset/starfive-jh7100.h >> >> >> >> >> STARFIVE JH71XX PMU CONTROLLER DRIVER >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig >> index 6ae5aa46a6b2..6aa8f243b30c 100644 >> --- a/drivers/reset/Kconfig >> +++ b/drivers/reset/Kconfig >> @@ -232,13 +232,6 @@ config RESET_SOCFPGA >> This enables the reset driver for the SoCFPGA ARMv7 platforms. This >> driver gets initialized early during platform init calls. >> >> >> >> >> -config RESET_STARFIVE_JH7100 >> - bool "StarFive JH7100 Reset Driver" >> - depends on ARCH_STARFIVE || COMPILE_TEST >> - default ARCH_STARFIVE >> - help >> - This enables the reset controller driver for the StarFive JH7100 SoC. >> - >> config RESET_SUNPLUS >> bool "Sunplus SoCs Reset Driver" if COMPILE_TEST >> default ARCH_SUNPLUS >> @@ -320,6 +313,7 @@ config RESET_ZYNQ >> help >> This enables the reset controller driver for Xilinx Zynq SoCs. >> >> >> >> >> +source "drivers/reset/starfive/Kconfig" >> source "drivers/reset/sti/Kconfig" >> source "drivers/reset/hisilicon/Kconfig" >> source "drivers/reset/tegra/Kconfig" >> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile >> index 3e7e5fd633a8..719b8f6f84bc 100644 >> --- a/drivers/reset/Makefile >> +++ b/drivers/reset/Makefile >> @@ -1,6 +1,7 @@ >> # SPDX-License-Identifier: GPL-2.0 >> obj-y += core.o >> obj-y += hisilicon/ >> +obj-$(CONFIG_ARCH_STARFIVE) += starfive/ > > This should really be obj-y, otherwise this won't compile with > COMPILE_TEST=y but ARCH_STARFIVE=n. > > With that fixed, > Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> The same problem exists in drivers/clk/Makefile. Will fix them in the next version. Thank you for your review. Best regards, Hal
diff --git a/MAINTAINERS b/MAINTAINERS index caba3b61ad5c..87f210e357ca 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19940,7 +19940,7 @@ STARFIVE JH7100 RESET CONTROLLER DRIVER M: Emil Renner Berthing <kernel@esmil.dk> S: Maintained F: Documentation/devicetree/bindings/reset/starfive,jh7100-reset.yaml -F: drivers/reset/reset-starfive-jh7100.c +F: drivers/reset/starfive/reset-starfive-jh7100.c F: include/dt-bindings/reset/starfive-jh7100.h STARFIVE JH71XX PMU CONTROLLER DRIVER diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index 6ae5aa46a6b2..6aa8f243b30c 100644 --- a/drivers/reset/Kconfig +++ b/drivers/reset/Kconfig @@ -232,13 +232,6 @@ config RESET_SOCFPGA This enables the reset driver for the SoCFPGA ARMv7 platforms. This driver gets initialized early during platform init calls. -config RESET_STARFIVE_JH7100 - bool "StarFive JH7100 Reset Driver" - depends on ARCH_STARFIVE || COMPILE_TEST - default ARCH_STARFIVE - help - This enables the reset controller driver for the StarFive JH7100 SoC. - config RESET_SUNPLUS bool "Sunplus SoCs Reset Driver" if COMPILE_TEST default ARCH_SUNPLUS @@ -320,6 +313,7 @@ config RESET_ZYNQ help This enables the reset controller driver for Xilinx Zynq SoCs. +source "drivers/reset/starfive/Kconfig" source "drivers/reset/sti/Kconfig" source "drivers/reset/hisilicon/Kconfig" source "drivers/reset/tegra/Kconfig" diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile index 3e7e5fd633a8..719b8f6f84bc 100644 --- a/drivers/reset/Makefile +++ b/drivers/reset/Makefile @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-y += core.o obj-y += hisilicon/ +obj-$(CONFIG_ARCH_STARFIVE) += starfive/ obj-$(CONFIG_ARCH_STI) += sti/ obj-$(CONFIG_ARCH_TEGRA) += tegra/ obj-$(CONFIG_RESET_A10SR) += reset-a10sr.o @@ -30,7 +31,6 @@ obj-$(CONFIG_RESET_RZG2L_USBPHY_CTRL) += reset-rzg2l-usbphy-ctrl.o obj-$(CONFIG_RESET_SCMI) += reset-scmi.o obj-$(CONFIG_RESET_SIMPLE) += reset-simple.o obj-$(CONFIG_RESET_SOCFPGA) += reset-socfpga.o -obj-$(CONFIG_RESET_STARFIVE_JH7100) += reset-starfive-jh7100.o obj-$(CONFIG_RESET_SUNPLUS) += reset-sunplus.o obj-$(CONFIG_RESET_SUNXI) += reset-sunxi.o obj-$(CONFIG_RESET_TI_SCI) += reset-ti-sci.o diff --git a/drivers/reset/starfive/Kconfig b/drivers/reset/starfive/Kconfig new file mode 100644 index 000000000000..abbf0c52d03e --- /dev/null +++ b/drivers/reset/starfive/Kconfig @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config RESET_STARFIVE_JH7100 + bool "StarFive JH7100 Reset Driver" + depends on ARCH_STARFIVE || COMPILE_TEST + default ARCH_STARFIVE + help + This enables the reset controller driver for the StarFive JH7100 SoC. diff --git a/drivers/reset/starfive/Makefile b/drivers/reset/starfive/Makefile new file mode 100644 index 000000000000..670d049423f5 --- /dev/null +++ b/drivers/reset/starfive/Makefile @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0 +obj-$(CONFIG_RESET_STARFIVE_JH7100) += reset-starfive-jh7100.o diff --git a/drivers/reset/reset-starfive-jh7100.c b/drivers/reset/starfive/reset-starfive-jh7100.c similarity index 100% rename from drivers/reset/reset-starfive-jh7100.c rename to drivers/reset/starfive/reset-starfive-jh7100.c