| Message ID | 20230213112138.32118-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 91e78b2585348284ef7cdb6a8736fd21389914fe |
| Headers | show |
| Series | [v1,1/1] dmaengine: Actually use devm_add_action_or_reset() | expand |
On Mon, Feb 13, 2023 at 01:21:38PM +0200, Andy Shevchenko wrote: > It appears that the commit a1beaa50b583 ("dmaengine: Simplify > dmaenginem_async_device_register() function") mentions > devm_add_action_or_reset() the actual change utilised devm_add_action() > call by mistake. > > Fix the issue by switching to devm_add_action_or_reset(). Vinod, are you okay with this fix?
On 13-02-23, 13:21, Andy Shevchenko wrote: > It appears that the commit a1beaa50b583 ("dmaengine: Simplify > dmaenginem_async_device_register() function") mentions > devm_add_action_or_reset() the actual change utilised devm_add_action() > call by mistake. > > Fix the issue by switching to devm_add_action_or_reset(). Applied, thanks
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index c24bca210104..826b98284fa1 100644 --- a/drivers/dma/dmaengine.c +++ b/drivers/dma/dmaengine.c @@ -1342,7 +1342,7 @@ int dmaenginem_async_device_register(struct dma_device *device) if (ret) return ret; - return devm_add_action(device->dev, dmaenginem_async_device_unregister, device); + return devm_add_action_or_reset(device->dev, dmaenginem_async_device_unregister, device); } EXPORT_SYMBOL(dmaenginem_async_device_register);
It appears that the commit a1beaa50b583 ("dmaengine: Simplify dmaenginem_async_device_register() function") mentions devm_add_action_or_reset() the actual change utilised devm_add_action() call by mistake. Fix the issue by switching to devm_add_action_or_reset(). Fixes: a1beaa50b583 ("dmaengine: Simplify dmaenginem_async_device_register() function") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/dma/dmaengine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)