| Message ID | 20230313225103.30512-17-Sergey.Semin@baikalelectronics.ru (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: net: dwmac: Extend clocks, props desc and constraints | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/apply | fail | Patch does not apply to net-next |
On Tue, 14 Mar 2023 01:51:03 +0300, Serge Semin wrote: > Currently the CBS algorithm specific properties could be used > unconditionally in the MTL Tx queue sub-nodes. It's definitely wrong from > the correct Tx queue description point of view. Let's fix that in a way so > the "snps,send_slope", "snps,idle_slope", "snps,high_credit" and > "snps,low_credit" properties would be allowed only if the CBS TC algorithm > is enabled for the MTL Tx queue. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 9df301cf674e..c6a9b44650c3 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -322,7 +322,12 @@ properties: - snps,dcb-algorithm - snps,avb-algorithm + # Credit Base Shaper is configurable for AVB algo only dependencies: + snps,send_slope: ["snps,avb-algorithm"] + snps,idle_slope: ["snps,avb-algorithm"] + snps,high_credit: ["snps,avb-algorithm"] + snps,low_credit: ["snps,avb-algorithm"] snps,weight: ["snps,dcb-algorithm"] additionalProperties: false
Currently the CBS algorithm specific properties could be used unconditionally in the MTL Tx queue sub-nodes. It's definitely wrong from the correct Tx queue description point of view. Let's fix that in a way so the "snps,send_slope", "snps,idle_slope", "snps,high_credit" and "snps,low_credit" properties would be allowed only if the CBS TC algorithm is enabled for the MTL Tx queue. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++ 1 file changed, 5 insertions(+)