| Message ID | 20230320135710.1989-3-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1681ce3735483ab6897e403a20a7faf5c34c1f09 |
| Headers | show |
| Series | arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property | expand |
On 20.03.2023 14:57, Johan Hovold wrote: > The SPMI PMIC register region width is fixed and should not be encoded > in the devicetree. > > Fixes: 42f45cc655d0 ("arm64: dts: qcom: sc8280xp-pmics: add pmk8280 sdam nvram") > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > index 1411edd42b25..c35e7f6bd657 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi > @@ -107,7 +107,7 @@ pmk8280_rtc: rtc@6100 { > > pmk8280_sdam_6: nvram@8500 { > compatible = "qcom,spmi-sdam"; > - reg = <0x8500 0x100>; > + reg = <0x8500>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0 0x8500 0x100>;
On 20/03/2023 14:57, Johan Hovold wrote: > The SPMI PMIC register region width is fixed and should not be encoded > in the devicetree. It also violates size-cells=0. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Mar 20, 2023 at 02:57:09PM +0100, Johan Hovold wrote: > The SPMI PMIC register region width is fixed and should not be encoded > in the devicetree. > > Fixes: 42f45cc655d0 ("arm64: dts: qcom: sc8280xp-pmics: add pmk8280 sdam nvram") Bah, that should have been: Fixes: d6dbbda37ab5 ("arm64: dts: qcom: sc8280xp-pmics: add pmk8280 sdam nvram") Can you fix that up when applying, Bjorn? Johan
On Mon, Mar 20, 2023 at 03:11:39PM +0100, Krzysztof Kozlowski wrote: > On 20/03/2023 14:57, Johan Hovold wrote: > > The SPMI PMIC register region width is fixed and should not be encoded > > in the devicetree. > > It also violates size-cells=0. That's the same thing. Johan
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi index 1411edd42b25..c35e7f6bd657 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi @@ -107,7 +107,7 @@ pmk8280_rtc: rtc@6100 { pmk8280_sdam_6: nvram@8500 { compatible = "qcom,spmi-sdam"; - reg = <0x8500 0x100>; + reg = <0x8500>; #address-cells = <1>; #size-cells = <1>; ranges = <0 0x8500 0x100>;
The SPMI PMIC register region width is fixed and should not be encoded in the devicetree. Fixes: 42f45cc655d0 ("arm64: dts: qcom: sc8280xp-pmics: add pmk8280 sdam nvram") Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)