| Message ID | 202303221007049346627@zte.com.cn |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | phy: marvell: phy-mvebu-a3700-comphy: use devm_platform_ioremap_resource_byname() | expand |
Hello, ye.xingchen@zte.com.cn wrote on Wed, 22 Mar 2023 10:07:04 +0800 (CST): > From: Ye Xingchen <ye.xingchen@zte.com.cn> > > Convert platform_get_resource_byname(),devm_ioremap_resource() to a single > call to devm_platform_ioremap_resource_byname(), as this is exactly what > this function does. > > Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
On Wed, 22 Mar 2023 10:07:04 +0800 (CST) <ye.xingchen@zte.com.cn> wrote: > From: Ye Xingchen <ye.xingchen@zte.com.cn> > > Convert platform_get_resource_byname(),devm_ioremap_resource() to a single > call to devm_platform_ioremap_resource_byname(), as this is exactly what > this function does. > > Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn> > --- > drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/phy/marvell/phy-mvebu-a3700-comphy.c b/drivers/phy/marvell/phy-mvebu-a3700-comphy.c > index d641b345afa3..9aeeedf59f44 100644 > --- a/drivers/phy/marvell/phy-mvebu-a3700-comphy.c > +++ b/drivers/phy/marvell/phy-mvebu-a3700-comphy.c > @@ -1241,7 +1241,6 @@ static int mvebu_a3700_comphy_probe(struct platform_device *pdev) > struct mvebu_a3700_comphy_priv *priv; > struct phy_provider *provider; > struct device_node *child; > - struct resource *res; > struct clk *clk; > int ret; > > @@ -1251,26 +1250,19 @@ static int mvebu_a3700_comphy_probe(struct platform_device *pdev) > > spin_lock_init(&priv->lock); > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "comphy"); > - priv->comphy_regs = devm_ioremap_resource(&pdev->dev, res); > + priv->comphy_regs = devm_platform_ioremap_resource_byname(pdev, "comphy"); > if (IS_ERR(priv->comphy_regs)) > return PTR_ERR(priv->comphy_regs); > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > - "lane1_pcie_gbe"); > - priv->lane1_phy_regs = devm_ioremap_resource(&pdev->dev, res); > + priv->lane1_phy_regs = devm_platform_ioremap_resource_byname(pdev, "lane1_pcie_gbe"); > if (IS_ERR(priv->lane1_phy_regs)) > return PTR_ERR(priv->lane1_phy_regs); > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > - "lane0_usb3_gbe"); > - priv->lane0_phy_regs = devm_ioremap_resource(&pdev->dev, res); > + priv->lane0_phy_regs = devm_platform_ioremap_resource_byname(pdev, "lane0_usb3_gbe"); > if (IS_ERR(priv->lane0_phy_regs)) > return PTR_ERR(priv->lane0_phy_regs); > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > - "lane2_sata_usb3"); > - priv->lane2_phy_indirect = devm_ioremap_resource(&pdev->dev, res); > + priv->lane2_phy_indirect = devm_platform_ioremap_resource_byname(pdev, "lane2_sata_usb3"); > if (IS_ERR(priv->lane2_phy_indirect)) > return PTR_ERR(priv->lane2_phy_indirect); > Reviewed-by: Marek Behún <kabel@kernel.org>
diff --git a/drivers/phy/marvell/phy-mvebu-a3700-comphy.c b/drivers/phy/marvell/phy-mvebu-a3700-comphy.c index d641b345afa3..9aeeedf59f44 100644 --- a/drivers/phy/marvell/phy-mvebu-a3700-comphy.c +++ b/drivers/phy/marvell/phy-mvebu-a3700-comphy.c @@ -1241,7 +1241,6 @@ static int mvebu_a3700_comphy_probe(struct platform_device *pdev) struct mvebu_a3700_comphy_priv *priv; struct phy_provider *provider; struct device_node *child; - struct resource *res; struct clk *clk; int ret; @@ -1251,26 +1250,19 @@ static int mvebu_a3700_comphy_probe(struct platform_device *pdev) spin_lock_init(&priv->lock); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "comphy"); - priv->comphy_regs = devm_ioremap_resource(&pdev->dev, res); + priv->comphy_regs = devm_platform_ioremap_resource_byname(pdev, "comphy"); if (IS_ERR(priv->comphy_regs)) return PTR_ERR(priv->comphy_regs); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, - "lane1_pcie_gbe"); - priv->lane1_phy_regs = devm_ioremap_resource(&pdev->dev, res); + priv->lane1_phy_regs = devm_platform_ioremap_resource_byname(pdev, "lane1_pcie_gbe"); if (IS_ERR(priv->lane1_phy_regs)) return PTR_ERR(priv->lane1_phy_regs); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, - "lane0_usb3_gbe"); - priv->lane0_phy_regs = devm_ioremap_resource(&pdev->dev, res); + priv->lane0_phy_regs = devm_platform_ioremap_resource_byname(pdev, "lane0_usb3_gbe"); if (IS_ERR(priv->lane0_phy_regs)) return PTR_ERR(priv->lane0_phy_regs); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, - "lane2_sata_usb3"); - priv->lane2_phy_indirect = devm_ioremap_resource(&pdev->dev, res); + priv->lane2_phy_indirect = devm_platform_ioremap_resource_byname(pdev, "lane2_sata_usb3"); if (IS_ERR(priv->lane2_phy_indirect)) return PTR_ERR(priv->lane2_phy_indirect);