| Message ID | 20230322102941.959-2-michal.orzel@amd.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xen/arm: fixes around domain_vpl011_init | expand |
> On 22 Mar 2023, at 10:29, Michal Orzel <michal.orzel@amd.com> wrote: > > We are assigning return code of domain_vpl011_init() to a variable > without checking it for an error. Fix it. > > Fixes: 3580c8b2dfc3 ("xen/arm: if direct-map domain use native UART address and IRQ number for vPL011") > Signed-off-by: Michal Orzel <michal.orzel@amd.com> Hi Michal, Looks good to me, Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
Hi, On 22/03/2023 10:29, Michal Orzel wrote: > We are assigning return code of domain_vpl011_init() to a variable > without checking it for an error. Fix it. > > Fixes: 3580c8b2dfc3 ("xen/arm: if direct-map domain use native UART address and IRQ number for vPL011") > Signed-off-by: Michal Orzel <michal.orzel@amd.com> Acked-by: Julien Grall <jgrall@amazon.com> Cheers,
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 9707eb7b1bb1..3195c5b6d6ac 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3826,7 +3826,11 @@ static int __init construct_domU(struct domain *d, * shall be done first. */ if ( kinfo.vpl011 ) + { rc = domain_vpl011_init(d, NULL); + if ( rc < 0 ) + return rc; + } rc = prepare_dtb_domU(d, &kinfo); if ( rc < 0 )
We are assigning return code of domain_vpl011_init() to a variable without checking it for an error. Fix it. Fixes: 3580c8b2dfc3 ("xen/arm: if direct-map domain use native UART address and IRQ number for vPL011") Signed-off-by: Michal Orzel <michal.orzel@amd.com> --- xen/arch/arm/domain_build.c | 4 ++++ 1 file changed, 4 insertions(+)