mbox series

[v2,0/2] remoteproc: get rproc devices for clusters

Message ID 20230322040933.924813-1-tanmay.shah@amd.com (mailing list archive)
Headers show
Series remoteproc: get rproc devices for clusters | expand

Message

Shah, Tanmay March 22, 2023, 4:09 a.m. UTC 
This series extends original patch and makes rproc_put() work
for clusters along with rprog_get_by_phandle().

v1 is here: https://lore.kernel.org/all/20221214221643.1286585-1-mathieu.poirier@linaro.org/

Mathieu Poirier (1):
  remoteproc: Make rproc_get_by_phandle() work for clusters

Tanmay Shah (1):
  remoteproc: enhance rproc_put() for clusters

 drivers/remoteproc/remoteproc_core.c | 41 +++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)


base-commit: e19967994d342a5986d950a1bfddf19d7e1191b7

Comments

Bjorn Andersson March 22, 2023, 2:12 p.m. UTC | #1 
On Tue, Mar 21, 2023 at 09:09:32PM -0700, Tanmay Shah wrote:
> This series extends original patch and makes rproc_put() work
> for clusters along with rprog_get_by_phandle().
> 
> v1 is here: https://lore.kernel.org/all/20221214221643.1286585-1-mathieu.poirier@linaro.org/
> 

What changed since v1?

Thanks,
Bjorn

> Mathieu Poirier (1):
>   remoteproc: Make rproc_get_by_phandle() work for clusters
> 
> Tanmay Shah (1):
>   remoteproc: enhance rproc_put() for clusters
> 
>  drivers/remoteproc/remoteproc_core.c | 41 +++++++++++++++++++++++++++-
>  1 file changed, 40 insertions(+), 1 deletion(-)
> 
> 
> base-commit: e19967994d342a5986d950a1bfddf19d7e1191b7
> -- 
> 2.25.1
>
Mathieu Poirier March 22, 2023, 4:11 p.m. UTC | #2 
On Wed, Mar 22, 2023 at 07:12:15AM -0700, Bjorn Andersson wrote:
> On Tue, Mar 21, 2023 at 09:09:32PM -0700, Tanmay Shah wrote:
> > This series extends original patch and makes rproc_put() work
> > for clusters along with rprog_get_by_phandle().
> > 
> > v1 is here: https://lore.kernel.org/all/20221214221643.1286585-1-mathieu.poirier@linaro.org/
> > 
> 
> What changed since v1?
>

Path 2/2 was not part of the original submission.  Speaking of that original
submission, you did not follow-up on my last comment, something that would be
much appreciated in order to move forward with this fix.

Thanks,
Mathieu


> Thanks,
> Bjorn
> 
> > Mathieu Poirier (1):
> >   remoteproc: Make rproc_get_by_phandle() work for clusters
> > 
> > Tanmay Shah (1):
> >   remoteproc: enhance rproc_put() for clusters
> > 
> >  drivers/remoteproc/remoteproc_core.c | 41 +++++++++++++++++++++++++++-
> >  1 file changed, 40 insertions(+), 1 deletion(-)
> > 
> > 
> > base-commit: e19967994d342a5986d950a1bfddf19d7e1191b7
> > -- 
> > 2.25.1
> >
Shah, Tanmay March 22, 2023, 5:37 p.m. UTC | #3 
On 3/22/23 7:12 AM, Bjorn Andersson wrote:
> On Tue, Mar 21, 2023 at 09:09:32PM -0700, Tanmay Shah wrote:
>> This series extends original patch and makes rproc_put() work
>> for clusters along with rprog_get_by_phandle().
>>
>> v1 is here: https://lore.kernel.org/all/20221214221643.1286585-1-mathieu.poirier@linaro.org/
>>
> What changed since v1?


Hello Bjorn,

Thanks for reviews.

rproc_put() is fixed in v2. I will add proper change-log in cover-letter 
in next revision.


Thanks,


> Thanks,
> Bjorn
>
>> Mathieu Poirier (1):
>>    remoteproc: Make rproc_get_by_phandle() work for clusters
>>
>> Tanmay Shah (1):
>>    remoteproc: enhance rproc_put() for clusters
>>
>>   drivers/remoteproc/remoteproc_core.c | 41 +++++++++++++++++++++++++++-
>>   1 file changed, 40 insertions(+), 1 deletion(-)
>>
>>
>> base-commit: e19967994d342a5986d950a1bfddf19d7e1191b7
>> -- 
>> 2.25.1
>>