| Message ID | 20230320213508.2358213-7-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtw88: Add SDIO support | expand |
> -----Original Message----- > From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Sent: Tuesday, March 21, 2023 5:35 AM > To: linux-wireless@vger.kernel.org > Cc: Yan-Hsuan Chuang <tony0620emma@gmail.com>; Kalle Valo <kvalo@kernel.org>; Ulf Hansson > <ulf.hansson@linaro.org>; linux-kernel@vger.kernel.org; netdev@vger.kernel.org; > linux-mmc@vger.kernel.org; Chris Morgan <macroalpha82@gmail.com>; Nitin Gupta <nitin.gupta981@gmail.com>; > Neo Jou <neojou@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>; Jernej Skrabec <jernej.skrabec@gmail.com>; > Larry Finger <Larry.Finger@lwfinger.net>; Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Subject: [PATCH v3 6/9] mmc: sdio: add Realtek SDIO vendor ID and various wifi device IDs > > > Add the SDIO vendor ID for Realtek and some device IDs extracted from > their GPL vendor driver. This will be useful in the future when the > rtw88 driver gains support for these chips. > > Acked-by: Ulf Hansson <ulf.hansson@linaro.org> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com> > --- > Changes since v2: > - none > > Changes since v1: > - Add Ulf's Acked-by (who added: "I assume it's easier if Kalle picks > up this patch, along with the series") > > > include/linux/mmc/sdio_ids.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h > index 0e4ef9c5127a..d7cd39a8ad57 100644 > --- a/include/linux/mmc/sdio_ids.h > +++ b/include/linux/mmc/sdio_ids.h > @@ -112,6 +112,15 @@ > #define SDIO_VENDOR_ID_MICROCHIP_WILC 0x0296 > #define SDIO_DEVICE_ID_MICROCHIP_WILC1000 0x5347 > > +#define SDIO_VENDOR_ID_REALTEK 0x024c > +#define SDIO_DEVICE_ID_REALTEK_RTW8723BS 0xb723 > +#define SDIO_DEVICE_ID_REALTEK_RTW8723DS 0xd723 > +#define SDIO_DEVICE_ID_REALTEK_RTW8821BS 0xb821 > +#define SDIO_DEVICE_ID_REALTEK_RTW8821CS 0xc821 > +#define SDIO_DEVICE_ID_REALTEK_RTW8821DS 0xd821 > +#define SDIO_DEVICE_ID_REALTEK_RTW8822BS 0xb822 > +#define SDIO_DEVICE_ID_REALTEK_RTW8822CS 0xc822 > + > #define SDIO_VENDOR_ID_SIANO 0x039a > #define SDIO_DEVICE_ID_SIANO_NOVA_B0 0x0201 > #define SDIO_DEVICE_ID_SIANO_NICE 0x0202 > -- > 2.40.0
On Monday 20 March 2023 22:35:05 Martin Blumenstingl wrote: > Add the SDIO vendor ID for Realtek and some device IDs extracted from > their GPL vendor driver. This will be useful in the future when the > rtw88 driver gains support for these chips. > > Acked-by: Ulf Hansson <ulf.hansson@linaro.org> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > Changes since v2: > - none > > Changes since v1: > - Add Ulf's Acked-by (who added: "I assume it's easier if Kalle picks > up this patch, along with the series") > > > include/linux/mmc/sdio_ids.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h > index 0e4ef9c5127a..d7cd39a8ad57 100644 > --- a/include/linux/mmc/sdio_ids.h > +++ b/include/linux/mmc/sdio_ids.h > @@ -112,6 +112,15 @@ > #define SDIO_VENDOR_ID_MICROCHIP_WILC 0x0296 > #define SDIO_DEVICE_ID_MICROCHIP_WILC1000 0x5347 > > +#define SDIO_VENDOR_ID_REALTEK 0x024c > +#define SDIO_DEVICE_ID_REALTEK_RTW8723BS 0xb723 > +#define SDIO_DEVICE_ID_REALTEK_RTW8723DS 0xd723 > +#define SDIO_DEVICE_ID_REALTEK_RTW8821BS 0xb821 > +#define SDIO_DEVICE_ID_REALTEK_RTW8821CS 0xc821 > +#define SDIO_DEVICE_ID_REALTEK_RTW8821DS 0xd821 > +#define SDIO_DEVICE_ID_REALTEK_RTW8822BS 0xb822 > +#define SDIO_DEVICE_ID_REALTEK_RTW8822CS 0xc822 Hello! Could you sort lines by values, like it is in all other sections? Also it would be nice to put these ids into sdioids database at: https://github.com/sdioutils > + > #define SDIO_VENDOR_ID_SIANO 0x039a > #define SDIO_DEVICE_ID_SIANO_NOVA_B0 0x0201 > #define SDIO_DEVICE_ID_SIANO_NICE 0x0202 > -- > 2.40.0 >
diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h index 0e4ef9c5127a..d7cd39a8ad57 100644 --- a/include/linux/mmc/sdio_ids.h +++ b/include/linux/mmc/sdio_ids.h @@ -112,6 +112,15 @@ #define SDIO_VENDOR_ID_MICROCHIP_WILC 0x0296 #define SDIO_DEVICE_ID_MICROCHIP_WILC1000 0x5347 +#define SDIO_VENDOR_ID_REALTEK 0x024c +#define SDIO_DEVICE_ID_REALTEK_RTW8723BS 0xb723 +#define SDIO_DEVICE_ID_REALTEK_RTW8723DS 0xd723 +#define SDIO_DEVICE_ID_REALTEK_RTW8821BS 0xb821 +#define SDIO_DEVICE_ID_REALTEK_RTW8821CS 0xc821 +#define SDIO_DEVICE_ID_REALTEK_RTW8821DS 0xd821 +#define SDIO_DEVICE_ID_REALTEK_RTW8822BS 0xb822 +#define SDIO_DEVICE_ID_REALTEK_RTW8822CS 0xc822 + #define SDIO_VENDOR_ID_SIANO 0x039a #define SDIO_DEVICE_ID_SIANO_NOVA_B0 0x0201 #define SDIO_DEVICE_ID_SIANO_NICE 0x0202