mbox series

[V2,0/3] nvmem: support post read for U-Boot's "ethaddr"

Message ID 20230318171356.29515-1-zajec5@gmail.com (mailing list archive)
Headers show
Series nvmem: support post read for U-Boot's "ethaddr" | expand

Message

Rafał Miłecki March 18, 2023, 5:13 p.m. UTC
From: Rafał Miłecki <rafal@milecki.pl>

This change is required for NVMEM consumers to get expected MAC address
from U-Boot env data variable "ethaddr".

To address some previous concerns:
1. Yes, U-Boot env binding & driver should be converted to NVMEM layout
2. My priority is to get working MAC rather than fancy DT syntax
3. I AM going to convert U-Boot env into layout later
4. This work DOESN'T conflict with layout migration
5. This code WILL stay during / after layout migration

My brain limitations don't allow me to handle everything at once, please
let's review what I already have here.

Rafał Miłecki (3):
  dt-bindings: nvmem: u-boot,env: add MAC's #nvmem-cell-cells
  nvmem: core: support specifying both: cell raw data & post read
    lengths
  nvmem: u-boot-env: post-process "ethaddr" env variable

 .../devicetree/bindings/nvmem/u-boot,env.yaml |  7 ++++-
 drivers/nvmem/Kconfig                         |  1 +
 drivers/nvmem/core.c                          | 11 +++++---
 drivers/nvmem/u-boot-env.c                    | 26 +++++++++++++++++++
 include/linux/nvmem-provider.h                |  2 ++
 5 files changed, 42 insertions(+), 5 deletions(-)

Comments

Srinivas Kandagatla March 23, 2023, 8:23 a.m. UTC | #1
On 18/03/2023 17:13, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This change is required for NVMEM consumers to get expected MAC address
> from U-Boot env data variable "ethaddr".
> 
> To address some previous concerns:
> 1. Yes, U-Boot env binding & driver should be converted to NVMEM layout
> 2. My priority is to get working MAC rather than fancy DT syntax
> 3. I AM going to convert U-Boot env into layout later
> 4. This work DOESN'T conflict with layout migration
> 5. This code WILL stay during / after layout migration
> 
> My brain limitations don't allow me to handle everything at once, please
> let's review what I already have here.


Thanks for your patience.

Applied now,

--srini

> 
> Rafał Miłecki (3):
>    dt-bindings: nvmem: u-boot,env: add MAC's #nvmem-cell-cells
>    nvmem: core: support specifying both: cell raw data & post read
>      lengths
>    nvmem: u-boot-env: post-process "ethaddr" env variable
> 
>   .../devicetree/bindings/nvmem/u-boot,env.yaml |  7 ++++-
>   drivers/nvmem/Kconfig                         |  1 +
>   drivers/nvmem/core.c                          | 11 +++++---
>   drivers/nvmem/u-boot-env.c                    | 26 +++++++++++++++++++
>   include/linux/nvmem-provider.h                |  2 ++
>   5 files changed, 42 insertions(+), 5 deletions(-)
>