| Message ID | 20230322144528.704077-1-ivan.orlov0322@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 735b0e0f2d001b7ed9486db84453fb860e764a4d |
| Headers | show |
| Series | selftests: kvm: Add 'malloc' failure check in vcpu_save_state | expand |
On Wed, 22 Mar 2023 18:45:28 +0400, Ivan Orlov wrote: > There is a 'malloc' call in vcpu_save_state function, which can > be unsuccessful. This patch will add the malloc failure checking > to avoid possible null dereference and give more information > about test fail reasons. > > Applied to kvm-x86 selftests, thanks! [1/1] selftests: kvm: Add 'malloc' failure check in vcpu_save_state https://github.com/kvm-x86/linux/commit/735b0e0f2d00 -- https://github.com/kvm-x86/linux/tree/next https://github.com/kvm-x86/linux/tree/fixes
diff --git a/tools/testing/selftests/kvm/lib/x86_64/processor.c b/tools/testing/selftests/kvm/lib/x86_64/processor.c index c39a4353ba19..827647ff3d41 100644 --- a/tools/testing/selftests/kvm/lib/x86_64/processor.c +++ b/tools/testing/selftests/kvm/lib/x86_64/processor.c @@ -954,6 +954,7 @@ struct kvm_x86_state *vcpu_save_state(struct kvm_vcpu *vcpu) vcpu_run_complete_io(vcpu); state = malloc(sizeof(*state) + msr_list->nmsrs * sizeof(state->msrs.entries[0])); + TEST_ASSERT(state, "-ENOMEM when allocating kvm state"); vcpu_events_get(vcpu, &state->events); vcpu_mp_state_get(vcpu, &state->mp_state);
There is a 'malloc' call in vcpu_save_state function, which can be unsuccessful. This patch will add the malloc failure checking to avoid possible null dereference and give more information about test fail reasons. Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com> --- tools/testing/selftests/kvm/lib/x86_64/processor.c | 1 + 1 file changed, 1 insertion(+)