diff mbox series

[net-next] dev_ioctl: fix a W=1 warning

Message ID d4a549bc-062c-e6cb-fb2f-75f32f8b3964@gmail.com (mailing list archive)
State Accepted
Commit e5b42483ccce50d5b957f474fd332afd4ef0c27b
Delegated to: Netdev Maintainers
Headers show
Series [net-next] dev_ioctl: fix a W=1 warning | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 21 this patch: 20
netdev/cc_maintainers warning 1 maintainers not CCed: keescook@chromium.org
netdev/build_clang success Errors and warnings before: 19 this patch: 18
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 21 this patch: 20
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 1 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Heiner Kallweit March 24, 2023, 10:11 p.m. UTC
This fixes the following warning when compiled with GCC 12.2.0 and W=1.

net/core/dev_ioctl.c:475: warning: Function parameter or member 'data'
not described in 'dev_ioctl'

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 net/core/dev_ioctl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Horman March 25, 2023, 9:51 a.m. UTC | #1
On Fri, Mar 24, 2023 at 11:11:49PM +0100, Heiner Kallweit wrote:
> This fixes the following warning when compiled with GCC 12.2.0 and W=1.
> 
> net/core/dev_ioctl.c:475: warning: Function parameter or member 'data'
> not described in 'dev_ioctl'
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
patchwork-bot+netdevbpf@kernel.org March 27, 2023, 8:40 a.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 24 Mar 2023 23:11:49 +0100 you wrote:
> This fixes the following warning when compiled with GCC 12.2.0 and W=1.
> 
> net/core/dev_ioctl.c:475: warning: Function parameter or member 'data'
> not described in 'dev_ioctl'
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next] dev_ioctl: fix a W=1 warning
    https://git.kernel.org/netdev/net-next/c/e5b42483ccce

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c
index 5cdbfbf9a..846669426 100644
--- a/net/core/dev_ioctl.c
+++ b/net/core/dev_ioctl.c
@@ -462,6 +462,7 @@  EXPORT_SYMBOL(dev_load);
  *	@net: the applicable net namespace
  *	@cmd: command to issue
  *	@ifr: pointer to a struct ifreq in user space
+ *	@data: data exchanged with userspace
  *	@need_copyout: whether or not copy_to_user() should be called
  *
  *	Issue ioctl functions to devices. This is normally called by the