mbox series

[0/7] Avoid a few casts from void *

Message ID cover.1679051552.git.vl@samba.org (mailing list archive)
Headers show
Series Avoid a few casts from void * | expand

Message

Volker Lendecke March 17, 2023, 11:15 a.m. UTC 
We should not go through void * without type-checking if it's not
really necessary.

Volker Lendecke (7):
  cifs: Avoid a cast in add_lease_context()
  cifs: Avoid a cast in add_durable_context()
  cifs: Avoid a cast in add_posix_context()
  cifs: Avoid a cast in add_sd_context()
  cifs: Avoid a cast in add_durable_v2_context()
  cifs: Avoid a cast in add_durable_reconnect_v2_context()
  cifs: Avoid a cast in add_query_id_context()

 fs/cifs/smb2pdu.c | 55 ++++++++++++++++++++++++++---------------------
 1 file changed, 30 insertions(+), 25 deletions(-)

Comments

Ralph Boehme March 27, 2023, 2:56 p.m. UTC | #1 
On 3/17/23 12:15, Volker Lendecke wrote:
> We should not go through void * without type-checking if it's not
> really necessary.
> 
> Volker Lendecke (7):
>    cifs: Avoid a cast in add_lease_context()
>    cifs: Avoid a cast in add_durable_context()
>    cifs: Avoid a cast in add_posix_context()
>    cifs: Avoid a cast in add_sd_context()
>    cifs: Avoid a cast in add_durable_v2_context()
>    cifs: Avoid a cast in add_durable_reconnect_v2_context()
>    cifs: Avoid a cast in add_query_id_context()
> 
>   fs/cifs/smb2pdu.c | 55 ++++++++++++++++++++++++++---------------------
>   1 file changed, 30 insertions(+), 25 deletions(-)
> 

Reviewed-by Ralph Boehme <slow@samba.org>

Thanks!
-slow
Steve French April 24, 2023, 2:22 a.m. UTC | #2 
I merged patch one of this series but looks like the other ones were
obsoleted by the other three cleanup patches you did for
SMB2_open_init.  Let me know about patches I may have missed, as we
get this updated for the merge window

On Fri, Mar 17, 2023 at 6:19 AM Volker Lendecke <vl@samba.org> wrote:
>
> We should not go through void * without type-checking if it's not
> really necessary.
>
> Volker Lendecke (7):
>   cifs: Avoid a cast in add_lease_context()
>   cifs: Avoid a cast in add_durable_context()
>   cifs: Avoid a cast in add_posix_context()
>   cifs: Avoid a cast in add_sd_context()
>   cifs: Avoid a cast in add_durable_v2_context()
>   cifs: Avoid a cast in add_durable_reconnect_v2_context()
>   cifs: Avoid a cast in add_query_id_context()
>
>  fs/cifs/smb2pdu.c | 55 ++++++++++++++++++++++++++---------------------
>  1 file changed, 30 insertions(+), 25 deletions(-)
>
> --
> 2.30.2
>