[net-next,v5,0/2] allocate multiple skbuffs on tx

Message

Arseniy Krasnov March 25, 2023, 10:02 p.m. UTC

This adds small optimization for tx path: instead of allocating single
skbuff on every call to transport, allocate multiple skbuff's until
credit space allows, thus trying to send as much as possible data without
return to af_vsock.c.

Also this patchset includes second patch which adds check and return from
'virtio_transport_get_credit()' and 'virtio_transport_put_credit()' when
these functions are called with 0 argument. This is needed, because zero
argument makes both functions to behave as no-effect, but both of them
always tries to acquire spinlock. Moreover, first patch always calls
function 'virtio_transport_put_credit()' with zero argument in case of
successful packet transmission.

 Link to v1:
 https://lore.kernel.org/netdev/[e-mail]/
 Link to v2:
 https://lore.kernel.org/netdev/[e-mail]/
 Link to v3:
 https://lore.kernel.org/netdev/[e-mail]/
 Link to v4:
 https://lore.kernel.org/netdev/[e-mail]/
 Link to v5:
 https://lore.kernel.org/netdev/[e-mail]/

 Changelog:
 v1 -> v2:
 - If sent something, return number of bytes sent (even in
   case of error). Return error only if failed to sent first
   skbuff.

 v2 -> v3:
 - Handle case when transport callback returns unexpected value which
   is not equal to 'skb->len'. Break loop.
 - Don't check for zero value of 'rest_len' before calling
   'virtio_transport_put_credit()'. Decided to add this check directly
   to 'virtio_transport_put_credit()' in separate patch.

 v3 -> v4:
 - Use WARN_ONCE() to handle case when transport callback returns
   unexpected value.
 - Remove useless 'ret = -EFAULT;' assignment for case above.

 v4 -> v5:
 - Remove extra 'ret' initialization.
 - Remove empty extra line before 'if (ret < 0)'.
 - Add R-b tag for the first patch.
 - Add second patch, thus creating patchset of 2 patches.

Arseniy Krasnov (2):
  virtio/vsock: allocate multiple skbuffs on tx
  virtio/vsock: check argument to avoid no effect call

 net/vmw_vsock/virtio_transport_common.c | 63 +++++++++++++++++++------
 1 file changed, 49 insertions(+), 14 deletions(-)

Comments

[e-mail] March 28, 2023, 10:10 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <[e-mail]>:

On Sun, 26 Mar 2023 01:02:43 +0300 you wrote:
> This adds small optimization for tx path: instead of allocating single
> skbuff on every call to transport, allocate multiple skbuff's until
> credit space allows, thus trying to send as much as possible data without
> return to af_vsock.c.
> 
> Also this patchset includes second patch which adds check and return from
> 'virtio_transport_get_credit()' and 'virtio_transport_put_credit()' when
> these functions are called with 0 argument. This is needed, because zero
> argument makes both functions to behave as no-effect, but both of them
> always tries to acquire spinlock. Moreover, first patch always calls
> function 'virtio_transport_put_credit()' with zero argument in case of
> successful packet transmission.
> 
> [...]

Here is the summary with links:
  - [net-next,v5,1/2] virtio/vsock: allocate multiple skbuffs on tx
    https://git.kernel.org/netdev/net-next/c/b68ffb1b3bee
  - [net-next,v5,2/2] virtio/vsock: check argument to avoid no effect call
    https://git.kernel.org/netdev/net-next/c/e3ec366eb0d1

You are awesome, thank you!