mbox series

[v2,0/3] xen/netback: fix issue introduced recently

Message ID 20230328131047.2440-1-jgross@suse.com (mailing list archive)
Headers show
Series xen/netback: fix issue introduced recently | expand

Message

Jürgen Groß March 28, 2023, 1:10 p.m. UTC 
The fix for XSA-423 introduced a bug which resulted in loss of network
connection in some configurations.

The first patch is fixing the issue, while the second one is removing
a test which isn't needed. The third patch is making error messages
more uniform.

Changes in V2:
- add patch 3
- comment addressed (patch 1)


Juergen Gross (3):
  xen/netback: don't do grant copy across page boundary
  xen/netback: remove not needed test in xenvif_tx_build_gops()
  xen/netback: use same error messages for same errors

 drivers/net/xen-netback/common.h  |  2 +-
 drivers/net/xen-netback/netback.c | 37 ++++++++++++++++++++++---------
 2 files changed, 28 insertions(+), 11 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 28, 2023, 1:30 p.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 28 Mar 2023 15:10:44 +0200 you wrote:
> The fix for XSA-423 introduced a bug which resulted in loss of network
> connection in some configurations.
> 
> The first patch is fixing the issue, while the second one is removing
> a test which isn't needed. The third patch is making error messages
> more uniform.
> 
> [...]

Here is the summary with links:
  - [v2,1/3] xen/netback: don't do grant copy across page boundary
    (no matching commit)
  - [v2,2/3] xen/netback: remove not needed test in xenvif_tx_build_gops()
    https://git.kernel.org/netdev/net/c/8fb8ebf94877
  - [v2,3/3] xen/netback: use same error messages for same errors
    (no matching commit)

You are awesome, thank you!
Paolo Abeni March 28, 2023, 1:52 p.m. UTC | #2 
Hi,

On Tue, 2023-03-28 at 15:10 +0200, Juergen Gross wrote:
> The fix for XSA-423 introduced a bug which resulted in loss of network
> connection in some configurations.
> 
> The first patch is fixing the issue, while the second one is removing
> a test which isn't needed. The third patch is making error messages
> more uniform.
> 
> Changes in V2:
> - add patch 3
> - comment addressed (patch 1)

I misread the thread on v2 as the build_bug_on() was not needed and
applied such revision. 

Please rebase any further change on top of current net.

Thanks,

Paolo
Jan Beulich March 28, 2023, 1:57 p.m. UTC | #3 
On 28.03.2023 15:52, Paolo Abeni wrote:
> On Tue, 2023-03-28 at 15:10 +0200, Juergen Gross wrote:
>> The fix for XSA-423 introduced a bug which resulted in loss of network
>> connection in some configurations.
>>
>> The first patch is fixing the issue, while the second one is removing
>> a test which isn't needed. The third patch is making error messages
>> more uniform.
>>
>> Changes in V2:
>> - add patch 3
>> - comment addressed (patch 1)
> 
> I misread the thread on v2 as the build_bug_on() was not needed and
> applied such revision. 

I guess it's not the end of the world if we go forward without that extra
check. It's a safeguard for theoretical future work which, as Jürgen says,
isn't very likely to occur anyway.

Jan