| Message ID | 20230103-topic-sm8550-upstream-mdss-dsi-v3-0-660c3bcb127f@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/msm: add support for SM8550 | expand |
On Mon, 09 Jan 2023 11:15:17 +0100, Neil Armstrong wrote: > This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. > > This patchset is based on the SM8450 display support serie at [1]. > > In order to work, the following patchsets are required: > - PM8550 LDO fix at [2] > - DISPCC driver at [3] > > [...] Applied, thanks! [1/7] dt-bindings: display/msm: document the SM8550 DSI PHY https://gitlab.freedesktop.org/lumag/msm/-/commit/71917f654bae [2/7] dt-bindings: display/msm: document DPU on SM8550 https://gitlab.freedesktop.org/lumag/msm/-/commit/602082368233 [3/7] dt-bindings: display/msm: document MDSS on SM8550 https://gitlab.freedesktop.org/lumag/msm/-/commit/9cb8eacfb528 [4/7] drm/msm/dpu: add support for SM8550 https://gitlab.freedesktop.org/lumag/msm/-/commit/c3cc4e88efb0 [5/7] drm/msm: mdss: add support for SM8550 https://gitlab.freedesktop.org/lumag/msm/-/commit/f96cca5ed719 [6/7] drm/msm/dsi: add support for DSI-PHY on SM8550 https://gitlab.freedesktop.org/lumag/msm/-/commit/0fd17f93661d [7/7] drm/msm/dsi: add support for DSI 2.7.0 https://gitlab.freedesktop.org/lumag/msm/-/commit/d797ca161b87 Best regards,
On 10/01/2023 01:43, Dmitry Baryshkov wrote: > > On Mon, 09 Jan 2023 11:15:17 +0100, Neil Armstrong wrote: >> This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. >> >> This patchset is based on the SM8450 display support serie at [1]. >> >> In order to work, the following patchsets are required: >> - PM8550 LDO fix at [2] >> - DISPCC driver at [3] >> >> [...] > > Applied, thanks! > > [1/7] dt-bindings: display/msm: document the SM8550 DSI PHY > https://gitlab.freedesktop.org/lumag/msm/-/commit/71917f654bae > [2/7] dt-bindings: display/msm: document DPU on SM8550 > https://gitlab.freedesktop.org/lumag/msm/-/commit/602082368233 These two patches were removed for now, until we have dispcc and interconnect bindings in place. > [3/7] dt-bindings: display/msm: document MDSS on SM8550 > https://gitlab.freedesktop.org/lumag/msm/-/commit/9cb8eacfb528 > [4/7] drm/msm/dpu: add support for SM8550 > https://gitlab.freedesktop.org/lumag/msm/-/commit/c3cc4e88efb0 > [5/7] drm/msm: mdss: add support for SM8550 > https://gitlab.freedesktop.org/lumag/msm/-/commit/f96cca5ed719 > [6/7] drm/msm/dsi: add support for DSI-PHY on SM8550 > https://gitlab.freedesktop.org/lumag/msm/-/commit/0fd17f93661d > [7/7] drm/msm/dsi: add support for DSI 2.7.0 > https://gitlab.freedesktop.org/lumag/msm/-/commit/d797ca161b87 > > Best regards,
On Mon, 09 Jan 2023 11:15:17 +0100, Neil Armstrong wrote: > This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. > > This patchset is based on the SM8450 display support serie at [1]. > > In order to work, the following patchsets are required: > - PM8550 LDO fix at [2] > - DISPCC driver at [3] > > [...] Applied, thanks! [2/7] dt-bindings: display/msm: document DPU on SM8550 https://gitlab.freedesktop.org/lumag/msm/-/commit/4557e40338d2 [3/7] dt-bindings: display/msm: document MDSS on SM8550 https://gitlab.freedesktop.org/lumag/msm/-/commit/0e4205eb8663 Best regards,
On Tue, Mar 28, 2023 at 5:38 PM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > > On Mon, 09 Jan 2023 11:15:17 +0100, Neil Armstrong wrote: > > This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. > > > > This patchset is based on the SM8450 display support serie at [1]. > > > > In order to work, the following patchsets are required: > > - PM8550 LDO fix at [2] > > - DISPCC driver at [3] > > > > [...] > > Applied, thanks! > > [2/7] dt-bindings: display/msm: document DPU on SM8550 > https://gitlab.freedesktop.org/lumag/msm/-/commit/4557e40338d2 > [3/7] dt-bindings: display/msm: document MDSS on SM8550 > https://gitlab.freedesktop.org/lumag/msm/-/commit/0e4205eb8663 And now failing on linux-next just as my bot reported: Documentation/devicetree/bindings/display/msm/qcom,sm8550-dpu.example.dts:24:18: fatal error: dt-bindings/interconnect/qcom,sm8550.h: No such file or directory 24 | #include <dt-bindings/interconnect/qcom,sm8550.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/display/msm/qcom,sm8550-dpu.example.dtb] Error 1 Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.example.dts:25:18: fatal error: dt-bindings/interconnect/qcom,sm8550.h: No such file or directory 25 | #include <dt-bindings/interconnect/qcom,sm8550.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. Please fix. And quickly please. Fixes in the DRM tree seem to take forever to get in... Rob
On 29/03/2023 22:52, Rob Herring wrote: > On Tue, Mar 28, 2023 at 5:38 PM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: >> >> >> On Mon, 09 Jan 2023 11:15:17 +0100, Neil Armstrong wrote: >>> This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. >>> >>> This patchset is based on the SM8450 display support serie at [1]. >>> >>> In order to work, the following patchsets are required: >>> - PM8550 LDO fix at [2] >>> - DISPCC driver at [3] >>> >>> [...] >> >> Applied, thanks! >> >> [2/7] dt-bindings: display/msm: document DPU on SM8550 >> https://gitlab.freedesktop.org/lumag/msm/-/commit/4557e40338d2 >> [3/7] dt-bindings: display/msm: document MDSS on SM8550 >> https://gitlab.freedesktop.org/lumag/msm/-/commit/0e4205eb8663 > > And now failing on linux-next just as my bot reported: > > Documentation/devicetree/bindings/display/msm/qcom,sm8550-dpu.example.dts:24:18: > fatal error: dt-bindings/interconnect/qcom,sm8550.h: No such file or > directory > 24 | #include <dt-bindings/interconnect/qcom,sm8550.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > make[1]: *** [scripts/Makefile.lib:419: > Documentation/devicetree/bindings/display/msm/qcom,sm8550-dpu.example.dtb] > Error 1 > Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.example.dts:25:18: > fatal error: dt-bindings/interconnect/qcom,sm8550.h: No such file or > directory > 25 | #include <dt-bindings/interconnect/qcom,sm8550.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > > Please fix. And quickly please. Fixes in the DRM tree seem to take > forever to get in... I pushed the fix, so it will arrive in linux-next tomorrow or the day after tomorrow. Please excuse me for breaking it again. I checked that the patches were merged, but didn't notice that the header name was changed in the process. Mea culpa.
On 29/03/2023 22:13, Dmitry Baryshkov wrote: > On 29/03/2023 22:52, Rob Herring wrote: >> On Tue, Mar 28, 2023 at 5:38 PM Dmitry Baryshkov >> <dmitry.baryshkov@linaro.org> wrote: >>> >>> >>> On Mon, 09 Jan 2023 11:15:17 +0100, Neil Armstrong wrote: >>>> This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. >>>> >>>> This patchset is based on the SM8450 display support serie at [1]. >>>> >>>> In order to work, the following patchsets are required: >>>> - PM8550 LDO fix at [2] >>>> - DISPCC driver at [3] >>>> >>>> [...] >>> >>> Applied, thanks! >>> >>> [2/7] dt-bindings: display/msm: document DPU on SM8550 >>> https://gitlab.freedesktop.org/lumag/msm/-/commit/4557e40338d2 >>> [3/7] dt-bindings: display/msm: document MDSS on SM8550 >>> https://gitlab.freedesktop.org/lumag/msm/-/commit/0e4205eb8663 >> >> And now failing on linux-next just as my bot reported: >> >> Documentation/devicetree/bindings/display/msm/qcom,sm8550-dpu.example.dts:24:18: >> fatal error: dt-bindings/interconnect/qcom,sm8550.h: No such file or >> directory >> 24 | #include <dt-bindings/interconnect/qcom,sm8550.h> >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> compilation terminated. >> make[1]: *** [scripts/Makefile.lib:419: >> Documentation/devicetree/bindings/display/msm/qcom,sm8550-dpu.example.dtb] >> Error 1 >> Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.example.dts:25:18: >> fatal error: dt-bindings/interconnect/qcom,sm8550.h: No such file or >> directory >> 25 | #include <dt-bindings/interconnect/qcom,sm8550.h> >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> compilation terminated. >> >> Please fix. And quickly please. Fixes in the DRM tree seem to take >> forever to get in... > > I pushed the fix, so it will arrive in linux-next tomorrow or the day after tomorrow. Please excuse me for breaking it again. I checked that the patches were merged, but didn't notice that the header name was changed in the process. Mea culpa. My bad I should have rebased and sent a v4 with the bindings only, Neil >
This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. This patchset is based on the SM8450 display support serie at [1]. In order to work, the following patchsets are required: - PM8550 LDO fix at [2] - DISPCC driver at [3] + the DT changes. [1] https://lore.kernel.org/all/20221207012231.112059-1-dmitry.baryshkov@linaro.org/ [2] https://lore.kernel.org/all/20230102-topic-sm8550-upstream-fixes-reg-l11b-nldo-v1-1-d97def246338@linaro.org/ [3] https://lore.kernel.org/all/20230103-topic-sm8550-upstream-dispcc-v2-0-786ddd8785a2@linaro.org To: Rob Clark <robdclark@gmail.com> To: Abhinav Kumar <quic_abhinavk@quicinc.com> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Sean Paul <sean@poorly.run> To: David Airlie <airlied@gmail.com> To: Daniel Vetter <daniel@ffwll.ch> To: Rob Herring <robh+dt@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> To: Jonathan Marek <jonathan@marek.ca> Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- Changes in v3: - Patch 1,2,3: Added Acked-by/Reviewed-by - Patch 6: Fixed compatible to qcom,sm8550-dsi-phy-4nm - Link to v2: https://lore.kernel.org/r/20230103-topic-sm8550-upstream-mdss-dsi-v2-0-87f1c16d7635@linaro.org Changes in v2: - Rebased on msm-next-lumag & msm-next-lumag-dpu - Fixed cover letter title to SM8550 - Patch 1: renamed compatible to qcom,sm8550-dsi-phy-4nm - Patch 2: split in 2 patches, switch to renamed qcom,sm8550-dsi-phy-4nm - Patch 3: switch CTL to use CTL_SC7280_MASK, Added Reviewed-by - Patch 4: Added Reviewed-by - Patch 5: fixed V5.2 quirk order - Patch 6: Added Reviewed-by - Link to v1: https://lore.kernel.org/r/20230103-topic-sm8550-upstream-mdss-dsi-v1-0-9ccd7e652fcd@linaro.org --- Neil Armstrong (7): dt-bindings: display/msm: document the SM8550 DSI PHY dt-bindings: display/msm: document DPU on SM8550 dt-bindings: display/msm: document MDSS on SM8550 drm/msm/dpu: add support for SM8550 drm/msm: mdss: add support for SM8550 drm/msm/dsi: add support for DSI-PHY on SM8550 drm/msm/dsi: add support for DSI 2.7.0 .../bindings/display/msm/dsi-phy-7nm.yaml | 1 + .../bindings/display/msm/qcom,sm8550-dpu.yaml | 134 +++++++++ .../bindings/display/msm/qcom,sm8550-mdss.yaml | 331 +++++++++++++++++++++ drivers/gpu/drm/msm/Kconfig | 4 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 197 ++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 2 + drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + drivers/gpu/drm/msm/dsi/dsi_cfg.c | 16 + drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 + drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 88 +++++- drivers/gpu/drm/msm/msm_mdss.c | 2 + 14 files changed, 765 insertions(+), 16 deletions(-) --- base-commit: 58372c69004c06773cbe74a05f2c1a4a8b23db9c change-id: 20230103-topic-sm8550-upstream-mdss-dsi-35ca8acea529 Best regards,