| Message ID | 7f7b0dde0caa2d2977b4fb5b65b63036e75f5022.1680071972.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | can: rcar_canfd: Fix plain integer in transceivers[] init | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Series ignored based on subject |
Hi Geert, Looks fine to me. On Wed Mar 29, 2023 at 8:40 AM CEST, Geert Uytterhoeven wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > With C=1: > > drivers/net/can/rcar/rcar_canfd.c:1852:59: warning: Using plain integer as NULL pointer > > Fixes: a0340df7eca4f28e ("can: rcar_canfd: Add transceiver support") > Reported-by: Jakub Kicinski <kuba@kernel.org> > Link: https://lore.kernel.org/r/20230328145658.7fdbc394@kernel.org > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/net/can/rcar/rcar_canfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c > index ecdb8ffe2f670c9b..11626d2a0afb1a90 100644 > --- a/drivers/net/can/rcar/rcar_canfd.c > +++ b/drivers/net/can/rcar/rcar_canfd.c > @@ -1848,7 +1848,7 @@ static void rcar_canfd_channel_remove(struct rcar_canfd_global *gpriv, u32 ch) > > static int rcar_canfd_probe(struct platform_device *pdev) > { > - struct phy *transceivers[RCANFD_NUM_CHANNELS] = { 0, }; > + struct phy *transceivers[RCANFD_NUM_CHANNELS] = { NULL, }; > const struct rcar_canfd_hw_info *info; > struct device *dev = &pdev->dev; > void __iomem *addr; > -- > 2.34.1 Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com> BR Steen
diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c index ecdb8ffe2f670c9b..11626d2a0afb1a90 100644 --- a/drivers/net/can/rcar/rcar_canfd.c +++ b/drivers/net/can/rcar/rcar_canfd.c @@ -1848,7 +1848,7 @@ static void rcar_canfd_channel_remove(struct rcar_canfd_global *gpriv, u32 ch) static int rcar_canfd_probe(struct platform_device *pdev) { - struct phy *transceivers[RCANFD_NUM_CHANNELS] = { 0, }; + struct phy *transceivers[RCANFD_NUM_CHANNELS] = { NULL, }; const struct rcar_canfd_hw_info *info; struct device *dev = &pdev->dev; void __iomem *addr;
With C=1: drivers/net/can/rcar/rcar_canfd.c:1852:59: warning: Using plain integer as NULL pointer Fixes: a0340df7eca4f28e ("can: rcar_canfd: Add transceiver support") Reported-by: Jakub Kicinski <kuba@kernel.org> Link: https://lore.kernel.org/r/20230328145658.7fdbc394@kernel.org Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/can/rcar/rcar_canfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)