| Message ID | 20230330021841.67724-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e83ce86aa7d914484038b181725718136387c7e1 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | b43legacy: Remove the unused function prev_slot() | expand |
On Thu, Mar 30, 2023 at 10:18:41AM +0800, Jiapeng Chong wrote: > The function prev_slot is defined in the dma.c file, but not called > elsewhere, so remove this unused function. > > drivers/net/wireless/broadcom/b43legacy/dma.c:130:19: warning: unused function 'prev_slot'. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4642 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Reviewed-by: Simon Horman <simon.horman@corigine.com>
On 3/29/23 21:18, Jiapeng Chong wrote: > The function prev_slot is defined in the dma.c file, but not called > elsewhere, so remove this unused function. > > drivers/net/wireless/broadcom/b43legacy/dma.c:130:19: warning: unused function 'prev_slot'. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4642 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/net/wireless/broadcom/b43legacy/dma.c | 8 -------- > 1 file changed, 8 deletions(-) Acked-by: Larry Finger <Larry.Finger@lwfinger.net> Thanks, Larry
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > The function prev_slot is defined in the dma.c file, but not called > elsewhere, so remove this unused function. > > drivers/net/wireless/broadcom/b43legacy/dma.c:130:19: warning: unused function 'prev_slot'. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4642 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > Reviewed-by: Simon Horman <simon.horman@corigine.com> > Acked-by: Larry Finger <Larry.Finger@lwfinger.net> Patch applied to wireless-next.git, thanks. e83ce86aa7d9 wifi: b43legacy: Remove the unused function prev_slot()
diff --git a/drivers/net/wireless/broadcom/b43legacy/dma.c b/drivers/net/wireless/broadcom/b43legacy/dma.c index 6869f2bf1bae..60e41de72f29 100644 --- a/drivers/net/wireless/broadcom/b43legacy/dma.c +++ b/drivers/net/wireless/broadcom/b43legacy/dma.c @@ -127,14 +127,6 @@ static inline int next_slot(struct b43legacy_dmaring *ring, int slot) return slot + 1; } -static inline int prev_slot(struct b43legacy_dmaring *ring, int slot) -{ - B43legacy_WARN_ON(!(slot >= 0 && slot <= ring->nr_slots - 1)); - if (slot == 0) - return ring->nr_slots - 1; - return slot - 1; -} - #ifdef CONFIG_B43LEGACY_DEBUG static void update_max_used_slots(struct b43legacy_dmaring *ring, int current_used_slots)
The function prev_slot is defined in the dma.c file, but not called elsewhere, so remove this unused function. drivers/net/wireless/broadcom/b43legacy/dma.c:130:19: warning: unused function 'prev_slot'. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4642 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/net/wireless/broadcom/b43legacy/dma.c | 8 -------- 1 file changed, 8 deletions(-)