[0/3] Simplify SMB2_open_init

Message

Volker Lendecke March 30, 2023, 12:04 p.m. UTC

Stitching together can be done in one place, there's no need to do
this in every add_*_context function.

This supersedes the patchet in

https://www.spinics.net/lists/linux-cifs/msg28087.html.

Volker Lendecke (3):
  cifs: Simplify SMB2_open_init()
  cifs: Simplify SMB2_open_init()
  cifs: Simplify SMB2_open_init()

 fs/cifs/smb2pdu.c | 106 +++++++++++-----------------------------------
 1 file changed, 25 insertions(+), 81 deletions(-)

Comments

Enzo Matsumiya March 30, 2023, 10:20 p.m. UTC | #1

Hi Volker,

On 03/30, Volker Lendecke wrote:
>Stitching together can be done in one place, there's no need to do
>this in every add_*_context function.
>
>This supersedes the patchet in
>
>https://www.spinics.net/lists/linux-cifs/msg28087.html.
>
>Volker Lendecke (3):
>  cifs: Simplify SMB2_open_init()
>  cifs: Simplify SMB2_open_init()
>  cifs: Simplify SMB2_open_init()
>
> fs/cifs/smb2pdu.c | 106 +++++++++++-----------------------------------
> 1 file changed, 25 insertions(+), 81 deletions(-)

Would you mind using more descriptive titles please?  To make
referencing/backporting easier.

Also IMHO patches 1/3 and 3/3 could be merged into a single patch.

Aside from that, Reviewed-by: Enzo Matsumiya <[e-mail]>


Cheers,

Enzo

Steve French March 30, 2023, 10:25 p.m. UTC | #2

My main worry is that these are done in the way that makes it easier
for Ronnie/Enzo/Paulo etc. to backport - since we have plenty of
bugs/features to work on that they will be wanting to backport over
the next few releases - and don't want to make their life too much
harder - but these changes look reasonably small

On Thu, Mar 30, 2023 at 5:21 PM Enzo Matsumiya <[e-mail]> wrote:
>
> Hi Volker,
>
> On 03/30, Volker Lendecke wrote:
> >Stitching together can be done in one place, there's no need to do
> >this in every add_*_context function.
> >
> >This supersedes the patchet in
> >
> >https://www.spinics.net/lists/linux-cifs/msg28087.html.
> >
> >Volker Lendecke (3):
> >  cifs: Simplify SMB2_open_init()
> >  cifs: Simplify SMB2_open_init()
> >  cifs: Simplify SMB2_open_init()
> >
> > fs/cifs/smb2pdu.c | 106 +++++++++++-----------------------------------
> > 1 file changed, 25 insertions(+), 81 deletions(-)
>
> Would you mind using more descriptive titles please?  To make
> referencing/backporting easier.
>
> Also IMHO patches 1/3 and 3/3 could be merged into a single patch.
>
> Aside from that, Reviewed-by: Enzo Matsumiya <[e-mail]>
>
>
> Cheers,
>
> Enzo

Steve French April 23, 2023, 6:10 a.m. UTC | #3

Let me know if any updated patches (with merge window approaching soon)

On Thu, Mar 30, 2023 at 7:16 AM Volker Lendecke <[e-mail]> wrote:
>
> Stitching together can be done in one place, there's no need to do
> this in every add_*_context function.
>
> This supersedes the patchet in
>
> https://www.spinics.net/lists/linux-cifs/msg28087.html.
>
> Volker Lendecke (3):
>   cifs: Simplify SMB2_open_init()
>   cifs: Simplify SMB2_open_init()
>   cifs: Simplify SMB2_open_init()
>
>  fs/cifs/smb2pdu.c | 106 +++++++++++-----------------------------------
>  1 file changed, 25 insertions(+), 81 deletions(-)
>
> --
> 2.30.2
>