mbox series

[GIT,PULL] etnaviv-fixes for 6.3

Message ID de8e08c2599ec0e22456ae36e9757b9ff14c2124.camel@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL] etnaviv-fixes for 6.3 | expand

Pull-request

https://git.pengutronix.de/git/lst/linux etnaviv/fixes

Message

Lucas Stach March 30, 2023, 4:19 p.m. UTC
Hi Dave, Daniel,

please pull the following fixes for the next rc. One fix to get rid of
a memory leak showing up in the wild and two reverts to get rid of the
scheduler use-after-free reported by Danilo.

Regards,
Lucas

The following changes since commit fe15c26ee26efa11741a7b632e9f23b01aca4cc6:

  Linux 6.3-rc1 (2023-03-05 14:52:03 -0800)

are available in the Git repository at:

  https://git.pengutronix.de/git/lst/linux etnaviv/fixes

for you to fetch changes up to baad10973fdb442912af676de3348e80bd8fe602:

  Revert "drm/scheduler: track GPU active time per entity" (2023-03-30 17:47:05 +0200)

----------------------------------------------------------------
Lucas Stach (3):
      drm/etnaviv: fix reference leak when mmaping imported buffer
      Revert "drm/etnaviv: export client GPU usage statistics via fdinfo"
      Revert "drm/scheduler: track GPU active time per entity"

 drivers/gpu/drm/etnaviv/etnaviv_drv.c       | 43 +------------------------------------------
 drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 10 +++++++++-
 drivers/gpu/drm/scheduler/sched_main.c      |  6 ------
 include/drm/gpu_scheduler.h                 |  7 -------
 4 files changed, 10 insertions(+), 56 deletions(-)

Comments

Daniel Vetter March 30, 2023, 6:25 p.m. UTC | #1
On Thu, Mar 30, 2023 at 06:19:36PM +0200, Lucas Stach wrote:
> Hi Dave, Daniel,
> 
> please pull the following fixes for the next rc. One fix to get rid of
> a memory leak showing up in the wild and two reverts to get rid of the
> scheduler use-after-free reported by Danilo.
> 
> Regards,
> Lucas
> 
> The following changes since commit fe15c26ee26efa11741a7b632e9f23b01aca4cc6:
> 
>   Linux 6.3-rc1 (2023-03-05 14:52:03 -0800)
> 
> are available in the Git repository at:
> 
>   https://git.pengutronix.de/git/lst/linux etnaviv/fixes

Pulled thanks.

> for you to fetch changes up to baad10973fdb442912af676de3348e80bd8fe602:
> 
>   Revert "drm/scheduler: track GPU active time per entity" (2023-03-30 17:47:05 +0200)
> 
> ----------------------------------------------------------------
> Lucas Stach (3):
>       drm/etnaviv: fix reference leak when mmaping imported buffer
>       Revert "drm/etnaviv: export client GPU usage statistics via fdinfo"
>       Revert "drm/scheduler: track GPU active time per entity"

Please record acks/r-b for shared code (afaict the revert didnt even go to
any m-l, at least it's not on lore) and explain why this is going through
a driver tree and not drm-misc. Avoids me crawling through lore to figure
out what's up.
-Daniel

> 
>  drivers/gpu/drm/etnaviv/etnaviv_drv.c       | 43 +------------------------------------------
>  drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 10 +++++++++-
>  drivers/gpu/drm/scheduler/sched_main.c      |  6 ------
>  include/drm/gpu_scheduler.h                 |  7 -------
>  4 files changed, 10 insertions(+), 56 deletions(-)
>
Danilo Krummrich March 31, 2023, 12:15 a.m. UTC | #2
On 3/30/23 18:19, Lucas Stach wrote:
> Hi Dave, Daniel,
> 
> please pull the following fixes for the next rc. One fix to get rid of
> a memory leak showing up in the wild and two reverts to get rid of the
> scheduler use-after-free reported by Danilo.

Besides the reverts, we might want to consider something like this as 
well: https://lore.kernel.org/all/20230331000622.4156-1-dakr@redhat.com/T/#u

Considering Christians response to my report, this isn't the first time 
this happened. Admittedly, it's a bit subtle and I'd like to prevent 
something like this happening again.

- Danilo

> 
> Regards,
> Lucas
> 
> The following changes since commit fe15c26ee26efa11741a7b632e9f23b01aca4cc6:
> 
>    Linux 6.3-rc1 (2023-03-05 14:52:03 -0800)
> 
> are available in the Git repository at:
> 
>    https://git.pengutronix.de/git/lst/linux etnaviv/fixes
> 
> for you to fetch changes up to baad10973fdb442912af676de3348e80bd8fe602:
> 
>    Revert "drm/scheduler: track GPU active time per entity" (2023-03-30 17:47:05 +0200)
> 
> ----------------------------------------------------------------
> Lucas Stach (3):
>        drm/etnaviv: fix reference leak when mmaping imported buffer
>        Revert "drm/etnaviv: export client GPU usage statistics via fdinfo"
>        Revert "drm/scheduler: track GPU active time per entity"
> 
>   drivers/gpu/drm/etnaviv/etnaviv_drv.c       | 43 +------------------------------------------
>   drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 10 +++++++++-
>   drivers/gpu/drm/scheduler/sched_main.c      |  6 ------
>   include/drm/gpu_scheduler.h                 |  7 -------
>   4 files changed, 10 insertions(+), 56 deletions(-)
>