mbox series

[0/2] RTW88 USB bug fixes

Message ID 20230331121054.112758-1-s.hauer@pengutronix.de (mailing list archive)
Headers show
Series RTW88 USB bug fixes | expand

Message

Sascha Hauer March 31, 2023, 12:10 p.m. UTC
This series fixes two bugs in the RTW88 USB driver I was reported from
several people and that I also encountered myself.

The first one resulted in "timed out to flush queue 3" messages from the
driver and sometimes a complete stall of the TX queues.

The second one is specific to the RTW8821CU chipset. Here 2GHz networks
were hardly seen and impossible to connect to. This goes down to
misinterpreting the rfe_option field in the efuse.

Sascha Hauer (2):
  wifi: rtw88: usb: fix priority queue to endpoint mapping
  wifi: rtw88: rtw8821c: Fix rfe_option field width

 drivers/net/wireless/realtek/rtw88/rtw8821c.c |  3 +-
 drivers/net/wireless/realtek/rtw88/usb.c      | 70 +++++++++++++------
 2 files changed, 48 insertions(+), 25 deletions(-)

Comments

Alex G. March 31, 2023, 8:34 p.m. UTC | #1
On 3/31/23 07:10, Sascha Hauer wrote:
> This series fixes two bugs in the RTW88 USB driver I was reported from
> several people and that I also encountered myself.
> 
> The first one resulted in "timed out to flush queue 3" messages from the
> driver and sometimes a complete stall of the TX queues.
> 
> The second one is specific to the RTW8821CU chipset. Here 2GHz networks
> were hardly seen and impossible to connect to. This goes down to
> misinterpreting the rfe_option field in the efuse.

I applied both these patches, tested an 8821CU, and the news are good:

The number of kernel warnings and adapter hangs has gone down considerably.

The signal levels on 2.4GHz bands have improved noticeably. There is the 
occasional station coming in 30dB lower than on nearby adapters. I 
wasn't able to find a pattern here.

I can now run these adapters in IBSS and 802.11s modes on the 2.4 GHz 
band. That was not possible before.

I am impressed with the improvements in these patches. For the series:

Tested-by: Alexandru gagniuc <mr.nuke.me@gmail.com>
>
> Sascha Hauer (2):
>    wifi: rtw88: usb: fix priority queue to endpoint mapping
>    wifi: rtw88: rtw8821c: Fix rfe_option field width
> 
>   drivers/net/wireless/realtek/rtw88/rtw8821c.c |  3 +-
>   drivers/net/wireless/realtek/rtw88/usb.c      | 70 +++++++++++++------
>   2 files changed, 48 insertions(+), 25 deletions(-)
>
Larry Finger April 1, 2023, 2:05 a.m. UTC | #2
On 3/31/23 15:34, Alex G. wrote:
> On 3/31/23 07:10, Sascha Hauer wrote:
>> This series fixes two bugs in the RTW88 USB driver I was reported from
>> several people and that I also encountered myself.
>>
>> The first one resulted in "timed out to flush queue 3" messages from the
>> driver and sometimes a complete stall of the TX queues.
>>
>> The second one is specific to the RTW8821CU chipset. Here 2GHz networks
>> were hardly seen and impossible to connect to. This goes down to
>> misinterpreting the rfe_option field in the efuse.
> 
> I applied both these patches, tested an 8821CU, and the news are good:
> 
> The number of kernel warnings and adapter hangs has gone down considerably.
> 
> The signal levels on 2.4GHz bands have improved noticeably. There is the 
> occasional station coming in 30dB lower than on nearby adapters. I wasn't able 
> to find a pattern here.
> 
> I can now run these adapters in IBSS and 802.11s modes on the 2.4 GHz band. That 
> was not possible before.
> 
> I am impressed with the improvements in these patches. For the series:
> 
> Tested-by: Alexandru gagniuc <mr.nuke.me@gmail.com>
>>
>> Sascha Hauer (2):
>>    wifi: rtw88: usb: fix priority queue to endpoint mapping
>>    wifi: rtw88: rtw8821c: Fix rfe_option field width
>>
>>   drivers/net/wireless/realtek/rtw88/rtw8821c.c |  3 +- >>   drivers/net/wireless/realtek/rtw88/usb.c      | 70 +++++++++++++------
>>   2 files changed, 48 insertions(+), 25 deletions(-)

I can confirm that these changes cleared up my problems with the "timed out to 
flush queue" warnings that caused a problem before with my rtw8822bu.

Tested-by: Larry Finger <Larry,Finger@lwfinger.net>

Thanks,

Larry
ValdikSS April 1, 2023, 2:08 a.m. UTC | #3
On 31.03.2023 23:34, Alex G. wrote:
> On 3/31/23 07:10, Sascha Hauer wrote:
>> This series fixes two bugs in the RTW88 USB driver I was reported from
>> several people and that I also encountered myself.
>>
>> The first one resulted in "timed out to flush queue 3" messages from the
>> driver and sometimes a complete stall of the TX queues.
>>
>> The second one is specific to the RTW8821CU chipset. Here 2GHz networks
>> were hardly seen and impossible to connect to. This goes down to
>> misinterpreting the rfe_option field in the efuse.

Tested on RTL8811CU, these two patches fix both issues. 2.4 GHz networks 
now work perfectly fine.

Tested-by: ValdikSS <iam@valdikss.org.ru>