| Message ID | 20230329074614.1037625-1-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dt-bindings: iio: st-sensors: Fix repeated text | expand |
On 29/03/2023 09:46, Linus Walleij wrote: > The description oddly contains a copy of the initial paragraph. > Let's not repeat ourselves. > > Cc: Jonathan Cameron <jic23@kernel.org> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Denis Ciocca <denis.ciocca@st.com> > Cc: devicetree@vger.kernel.org Please drop the autogenerated scripts/get_maintainer.pl CC-entries from commit msg (Jonathan's, Lars', Rob's, mine, DT list). There is no single need to store automated output of get_maintainers.pl in the git log. It can be easily re-created at any given time, thus its presence in the git history is redundant and obfuscates the log. If you need it for your own patch management purposes, keep it under the --- separator. > Reported-by: Diederik de Haas <didi.debian@cknow.org> I don't think it is a bug yet, so rather: Suggested-by: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, Mar 29, 2023 at 10:25 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Please drop the autogenerated scripts/get_maintainer.pl CC-entries from > commit msg (Jonathan's, Lars', Rob's, mine, DT list). There is no single > need to store automated output of get_maintainers.pl in the git log. It > can be easily re-created at any given time, thus its presence in the git > history is redundant and obfuscates the log. > > If you need it for your own patch management purposes, keep it under the > --- separator. Oh yeah I've seen that people do this these days, just (old) bad habits. I am trying to use b4 for this going forward, it always does the right thing. Thanks! Linus Walleij
On Wed, 29 Mar 2023 10:39:08 +0200 Linus Walleij <linus.walleij@linaro.org> wrote: > On Wed, Mar 29, 2023 at 10:25 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > > Please drop the autogenerated scripts/get_maintainer.pl CC-entries from > > commit msg (Jonathan's, Lars', Rob's, mine, DT list). There is no single > > need to store automated output of get_maintainers.pl in the git log. It > > can be easily re-created at any given time, thus its presence in the git > > history is redundant and obfuscates the log. > > > > If you need it for your own patch management purposes, keep it under the > > --- separator. > > Oh yeah I've seen that people do this these days, just (old) bad habits. > > I am trying to use b4 for this going forward, it always does the right thing. > > Thanks! > Linus Walleij Applied with suggested tweaks. Thanks, Jonathan
diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml index c6201976378f..558ae650f218 100644 --- a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml +++ b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml @@ -11,9 +11,6 @@ description: The STMicroelectronics sensor devices are pretty straight-forward what type of sensor it is. Note that whilst this covers many STMicro MEMs sensors, some more complex IMUs need their own bindings. - The STMicroelectronics sensor devices are pretty straight-forward I2C or - SPI devices, all sharing the same device tree descriptions no matter what - type of sensor it is. maintainers: - Denis Ciocca <denis.ciocca@st.com>
The description oddly contains a copy of the initial paragraph. Let's not repeat ourselves. Cc: Jonathan Cameron <jic23@kernel.org> Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Rob Herring <robh+dt@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Denis Ciocca <denis.ciocca@st.com> Cc: devicetree@vger.kernel.org Reported-by: Diederik de Haas <didi.debian@cknow.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 3 --- 1 file changed, 3 deletions(-)