| Message ID | 20230328193632.226095-5-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | arm64: dts: qcom: sa8775p: add more IOMMUs | expand |
On 28/03/2023 21:36, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > The KGSL iommu will require the clocks property to be set. Enable it for > sa8775p in the bindings. > > Cc: Will Deacon <will@kernel.org> > Cc: Robin Murphy <robin.murphy@arm.com> > Cc: Joerg Roedel <joro@8bytes.org> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > index 807cb511fe18..74d5164ed1e8 100644 > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > @@ -375,7 +375,6 @@ allOf: > - nvidia,smmu-500 > - qcom,qcm2290-smmu-500 > - qcom,qdu1000-smmu-500 > - - qcom,sa8775p-smmu-500 Then you need to describe them, like other variants are doing. Best regards, Krzysztof
On Tue, Mar 28, 2023 at 09:36:29PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > The KGSL iommu will require the clocks property to be set. Enable it for Isn't KGSL the name for QCom's adreno vendor driver? What does that have to do with bindings? > sa8775p in the bindings. > > Cc: Will Deacon <will@kernel.org> > Cc: Robin Murphy <robin.murphy@arm.com> > Cc: Joerg Roedel <joro@8bytes.org> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > index 807cb511fe18..74d5164ed1e8 100644 > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > @@ -375,7 +375,6 @@ allOf: > - nvidia,smmu-500 > - qcom,qcm2290-smmu-500 > - qcom,qdu1000-smmu-500 > - - qcom,sa8775p-smmu-500 > - qcom,sc7180-smmu-500 > - qcom,sc8180x-smmu-500 > - qcom,sc8280xp-smmu-500 > -- > 2.37.2 >
On 3.04.2023 22:41, Rob Herring wrote: > On Tue, Mar 28, 2023 at 09:36:29PM +0200, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >> >> The KGSL iommu will require the clocks property to be set. Enable it for > > Isn't KGSL the name for QCom's adreno vendor driver? What does that have > to do with bindings? It's called "KGSL SMMU" (as opposed to the other "APPS SMMU" (Application Processor SubSystem) in some places in Qualcommland Konrad > >> sa8775p in the bindings. >> >> Cc: Will Deacon <will@kernel.org> >> Cc: Robin Murphy <robin.murphy@arm.com> >> Cc: Joerg Roedel <joro@8bytes.org> >> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 807cb511fe18..74d5164ed1e8 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -375,7 +375,6 @@ allOf: >> - nvidia,smmu-500 >> - qcom,qcm2290-smmu-500 >> - qcom,qdu1000-smmu-500 >> - - qcom,sa8775p-smmu-500 >> - qcom,sc7180-smmu-500 >> - qcom,sc8180x-smmu-500 >> - qcom,sc8280xp-smmu-500 >> -- >> 2.37.2 >>
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml index 807cb511fe18..74d5164ed1e8 100644 --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml @@ -375,7 +375,6 @@ allOf: - nvidia,smmu-500 - qcom,qcm2290-smmu-500 - qcom,qdu1000-smmu-500 - - qcom,sa8775p-smmu-500 - qcom,sc7180-smmu-500 - qcom,sc8180x-smmu-500 - qcom,sc8280xp-smmu-500