| Message ID | 20230404171411.699655-4-zlang@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fstests specific MAINTAINERS file | expand |
Hi Zorro, On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote: > +FSVERITY > +L: fsverity@lists.linux.dev > +S: Supported > +F: common/verity > + > +FSCRYPT > +L: linux-fscrypt@vger.kernel.org > +S: Supported > +F: common/encrypt Most of the encrypt and verity tests are in tests/generic/ and are in the 'encrypt' or 'verity' test groups. These file patterns only pick up the common files, not the actual tests. Have you considered adding a way to specify maintainers for a test group? Something like: G: encrypt and G: verity - Eric
On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote: > The fstests supports different kind of fs testing, better to cc > specific fs mailing list for specific fs testing, to get better > reviewing points. So record these mailing lists and files related > with them in MAINTAINERS file. > > Signed-off-by: Zorro Lang <zlang@kernel.org> > --- > > If someone mailing list doesn't want to be in cc list of related fstests > patch, please reply this email, I'll remove that line. > > Or if I missed someone mailing list, please feel free to tell me. > > Thanks, > Zorro > > MAINTAINERS | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 09b1a5a3..620368cb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -107,6 +107,83 @@ Maintainers List > should send patch to fstests@ at least. Other relevant mailing list > or reviewer or co-maintainer can be in cc list. > > +BTRFS > +L: linux-btrfs@vger.kernel.org > +S: Supported > +F: tests/btrfs/ > +F: common/btrfs > + > +CEPH > +L: ceph-devel@vger.kernel.org > +S: Supported > +F: tests/ceph/ > +F: common/ceph > + > +CIFS > +L: linux-cifs@vger.kernel.org > +S: Supported > +F: tests/cifs > + > +EXT4 > +L: linux-ext4@vger.kernel.org > +S: Supported > +F: tests/ext4/ > +F: common/ext4 > + > +F2FS > +L: linux-f2fs-devel@lists.sourceforge.net > +S: Supported > +F: tests/f2fs/ > +F: common/f2fs > + > +FSVERITY > +L: fsverity@lists.linux.dev > +S: Supported > +F: common/verity > + > +FSCRYPT > +L: linux-fscrypt@vger.kernel.org > +S: Supported > +F: common/encrypt > + > +FS-IDMAPPED > +L: linux-fsdevel@vger.kernel.org > +S: Supported > +F: src/vfs/ > + > +NFS > +L: linux-nfs@vger.kernel.org > +S: Supported > +F: tests/nfs/ > +F: common/nfs > + > +OCFS2 > +L: ocfs2-devel@oss.oracle.com > +S: Supported > +F: tests/ocfs2/ > + > +OVERLAYFS > +L: linux-unionfs@vger.kernel.org > +S: Supported > +F: tests/overlay > +F: common/overlay > + > +UDF > +R: Jan Kara <jack@suse.com> > +S: Supported > +F: tests/udf/ > + > +XFS > +L: linux-xfs@vger.kernel.org > +S: Supported > +F: common/dump > +F: common/fuzzy > +F: common/inject > +F: common/populate note that populate and fuzzy apply to ext* as well. > +F: common/repair > +F: common/xfs > +F: tests/xfs/ Otherwise looks good to me, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > + > ALL > M: Zorro Lang <zlang@kernel.org> > L: fstests@vger.kernel.org > -- > 2.39.2 >
On Tue, Apr 04, 2023 at 03:16:53PM -0700, Eric Biggers wrote: > Hi Zorro, > > On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote: > > +FSVERITY > > +L: fsverity@lists.linux.dev > > +S: Supported > > +F: common/verity > > + > > +FSCRYPT > > +L: linux-fscrypt@vger.kernel.org > > +S: Supported > > +F: common/encrypt > > Most of the encrypt and verity tests are in tests/generic/ and are in the > 'encrypt' or 'verity' test groups. > > These file patterns only pick up the common files, not the actual tests. > > Have you considered adding a way to specify maintainers for a test group? > Something like: > > G: encrypt > > and > > G: verity Yes, good suggestion. --D > - Eric
Reviewed-by: Steven French <stfrench@microsoft.com> On Tue, Apr 4, 2023 at 6:22 PM Darrick J. Wong <djwong@kernel.org> wrote: > > On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote: > > The fstests supports different kind of fs testing, better to cc > > specific fs mailing list for specific fs testing, to get better > > reviewing points. So record these mailing lists and files related > > with them in MAINTAINERS file. > > > > Signed-off-by: Zorro Lang <zlang@kernel.org> > > --- > > > > If someone mailing list doesn't want to be in cc list of related fstests > > patch, please reply this email, I'll remove that line. > > > > Or if I missed someone mailing list, please feel free to tell me. > > > > Thanks, > > Zorro > > > > MAINTAINERS | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 77 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 09b1a5a3..620368cb 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -107,6 +107,83 @@ Maintainers List > > should send patch to fstests@ at least. Other relevant mailing list > > or reviewer or co-maintainer can be in cc list. > > > > +BTRFS > > +L: linux-btrfs@vger.kernel.org > > +S: Supported > > +F: tests/btrfs/ > > +F: common/btrfs > > + > > +CEPH > > +L: ceph-devel@vger.kernel.org > > +S: Supported > > +F: tests/ceph/ > > +F: common/ceph > > + > > +CIFS > > +L: linux-cifs@vger.kernel.org > > +S: Supported > > +F: tests/cifs > > + > > +EXT4 > > +L: linux-ext4@vger.kernel.org > > +S: Supported > > +F: tests/ext4/ > > +F: common/ext4 > > + > > +F2FS > > +L: linux-f2fs-devel@lists.sourceforge.net > > +S: Supported > > +F: tests/f2fs/ > > +F: common/f2fs > > + > > +FSVERITY > > +L: fsverity@lists.linux.dev > > +S: Supported > > +F: common/verity > > + > > +FSCRYPT > > +L: linux-fscrypt@vger.kernel.org > > +S: Supported > > +F: common/encrypt > > + > > +FS-IDMAPPED > > +L: linux-fsdevel@vger.kernel.org > > +S: Supported > > +F: src/vfs/ > > + > > +NFS > > +L: linux-nfs@vger.kernel.org > > +S: Supported > > +F: tests/nfs/ > > +F: common/nfs > > + > > +OCFS2 > > +L: ocfs2-devel@oss.oracle.com > > +S: Supported > > +F: tests/ocfs2/ > > + > > +OVERLAYFS > > +L: linux-unionfs@vger.kernel.org > > +S: Supported > > +F: tests/overlay > > +F: common/overlay > > + > > +UDF > > +R: Jan Kara <jack@suse.com> > > +S: Supported > > +F: tests/udf/ > > + > > +XFS > > +L: linux-xfs@vger.kernel.org > > +S: Supported > > +F: common/dump > > +F: common/fuzzy > > +F: common/inject > > +F: common/populate > > note that populate and fuzzy apply to ext* as well. > > > +F: common/repair > > +F: common/xfs > > +F: tests/xfs/ > > Otherwise looks good to me, > > Reviewed-by: Darrick J. Wong <djwong@kernel.org> > > --D > > > + > > ALL > > M: Zorro Lang <zlang@kernel.org> > > L: fstests@vger.kernel.org > > -- > > 2.39.2 > >
On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote: > The fstests supports different kind of fs testing, better to cc > specific fs mailing list for specific fs testing, to get better > reviewing points. So record these mailing lists and files related > with them in MAINTAINERS file. > > Signed-off-by: Zorro Lang <zlang@kernel.org> > --- > > If someone mailing list doesn't want to be in cc list of related fstests > patch, please reply this email, I'll remove that line. > > Or if I missed someone mailing list, please feel free to tell me. > > Thanks, > Zorro > > MAINTAINERS | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 09b1a5a3..620368cb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -107,6 +107,83 @@ Maintainers List > should send patch to fstests@ at least. Other relevant mailing list > or reviewer or co-maintainer can be in cc list. > > +BTRFS > +L: linux-btrfs@vger.kernel.org > +S: Supported > +F: tests/btrfs/ > +F: common/btrfs > + > +CEPH > +L: ceph-devel@vger.kernel.org > +S: Supported > +F: tests/ceph/ > +F: common/ceph > + > +CIFS > +L: linux-cifs@vger.kernel.org > +S: Supported > +F: tests/cifs > + > +EXT4 > +L: linux-ext4@vger.kernel.org > +S: Supported > +F: tests/ext4/ > +F: common/ext4 > + > +F2FS > +L: linux-f2fs-devel@lists.sourceforge.net > +S: Supported > +F: tests/f2fs/ > +F: common/f2fs > + > +FSVERITY > +L: fsverity@lists.linux.dev > +S: Supported > +F: common/verity > + > +FSCRYPT > +L: linux-fscrypt@vger.kernel.org > +S: Supported > +F: common/encrypt > + > +FS-IDMAPPED > +L: linux-fsdevel@vger.kernel.org > +S: Supported > +F: src/vfs/ Same suggestion as earlier, make that section VFS as it covers generic functionality, Acked-by: Christian Brauner <brauner@kernel.org>
On Wed 05-04-23 01:14:09, Zorro Lang wrote: > The fstests supports different kind of fs testing, better to cc > specific fs mailing list for specific fs testing, to get better > reviewing points. So record these mailing lists and files related > with them in MAINTAINERS file. > > Signed-off-by: Zorro Lang <zlang@kernel.org> > --- Looks good to me. Feel free to add: Acked-by: Jan Kara <jack@suse.cz> Honza > > If someone mailing list doesn't want to be in cc list of related fstests > patch, please reply this email, I'll remove that line. > > Or if I missed someone mailing list, please feel free to tell me. > > Thanks, > Zorro > > MAINTAINERS | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 09b1a5a3..620368cb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -107,6 +107,83 @@ Maintainers List > should send patch to fstests@ at least. Other relevant mailing list > or reviewer or co-maintainer can be in cc list. > > +BTRFS > +L: linux-btrfs@vger.kernel.org > +S: Supported > +F: tests/btrfs/ > +F: common/btrfs > + > +CEPH > +L: ceph-devel@vger.kernel.org > +S: Supported > +F: tests/ceph/ > +F: common/ceph > + > +CIFS > +L: linux-cifs@vger.kernel.org > +S: Supported > +F: tests/cifs > + > +EXT4 > +L: linux-ext4@vger.kernel.org > +S: Supported > +F: tests/ext4/ > +F: common/ext4 > + > +F2FS > +L: linux-f2fs-devel@lists.sourceforge.net > +S: Supported > +F: tests/f2fs/ > +F: common/f2fs > + > +FSVERITY > +L: fsverity@lists.linux.dev > +S: Supported > +F: common/verity > + > +FSCRYPT > +L: linux-fscrypt@vger.kernel.org > +S: Supported > +F: common/encrypt > + > +FS-IDMAPPED > +L: linux-fsdevel@vger.kernel.org > +S: Supported > +F: src/vfs/ > + > +NFS > +L: linux-nfs@vger.kernel.org > +S: Supported > +F: tests/nfs/ > +F: common/nfs > + > +OCFS2 > +L: ocfs2-devel@oss.oracle.com > +S: Supported > +F: tests/ocfs2/ > + > +OVERLAYFS > +L: linux-unionfs@vger.kernel.org > +S: Supported > +F: tests/overlay > +F: common/overlay > + > +UDF > +R: Jan Kara <jack@suse.com> > +S: Supported > +F: tests/udf/ > + > +XFS > +L: linux-xfs@vger.kernel.org > +S: Supported > +F: common/dump > +F: common/fuzzy > +F: common/inject > +F: common/populate > +F: common/repair > +F: common/xfs > +F: tests/xfs/ > + > ALL > M: Zorro Lang <zlang@kernel.org> > L: fstests@vger.kernel.org > -- > 2.39.2 >
On Tue, Apr 04, 2023 at 03:16:53PM -0700, Eric Biggers wrote: > Hi Zorro, > > On Wed, Apr 05, 2023 at 01:14:09AM +0800, Zorro Lang wrote: > > +FSVERITY > > +L: fsverity@lists.linux.dev > > +S: Supported > > +F: common/verity > > + > > +FSCRYPT > > +L: linux-fscrypt@vger.kernel.org > > +S: Supported > > +F: common/encrypt > > Most of the encrypt and verity tests are in tests/generic/ and are in the > 'encrypt' or 'verity' test groups. > > These file patterns only pick up the common files, not the actual tests. > > Have you considered adding a way to specify maintainers for a test group? > Something like: > > G: encrypt > > and > > G: verity Good idea! Let's check if this patchset is acceptable by most of you, then I'll think about how to add this feature later. Thanks, Zorro > > - Eric >
On 4/5/23 01:14, Zorro Lang wrote: > The fstests supports different kind of fs testing, better to cc > specific fs mailing list for specific fs testing, to get better > reviewing points. So record these mailing lists and files related > with them in MAINTAINERS file. > > Signed-off-by: Zorro Lang <zlang@kernel.org> > --- > > If someone mailing list doesn't want to be in cc list of related fstests > patch, please reply this email, I'll remove that line. > > Or if I missed someone mailing list, please feel free to tell me. > > Thanks, > Zorro > > MAINTAINERS | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 09b1a5a3..620368cb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -107,6 +107,83 @@ Maintainers List > should send patch to fstests@ at least. Other relevant mailing list > or reviewer or co-maintainer can be in cc list. > > +BTRFS > +L: linux-btrfs@vger.kernel.org > +S: Supported > +F: tests/btrfs/ > +F: common/btrfs > + > +CEPH > +L: ceph-devel@vger.kernel.org > +S: Supported > +F: tests/ceph/ > +F: common/ceph > + LGTM and feel free to add: Acked-by: Xiubo Li <xiubli@redhat.com> Thanks, - Xiubo
On 2023/4/5 1:14, Zorro Lang wrote: > +F2FS > +L: linux-f2fs-devel@lists.sourceforge.net > +S: Supported > +F: tests/f2fs/ > +F: common/f2fs Acked-by: Chao Yu <chao@kernel.org> Thanks,
diff --git a/MAINTAINERS b/MAINTAINERS index 09b1a5a3..620368cb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -107,6 +107,83 @@ Maintainers List should send patch to fstests@ at least. Other relevant mailing list or reviewer or co-maintainer can be in cc list. +BTRFS +L: linux-btrfs@vger.kernel.org +S: Supported +F: tests/btrfs/ +F: common/btrfs + +CEPH +L: ceph-devel@vger.kernel.org +S: Supported +F: tests/ceph/ +F: common/ceph + +CIFS +L: linux-cifs@vger.kernel.org +S: Supported +F: tests/cifs + +EXT4 +L: linux-ext4@vger.kernel.org +S: Supported +F: tests/ext4/ +F: common/ext4 + +F2FS +L: linux-f2fs-devel@lists.sourceforge.net +S: Supported +F: tests/f2fs/ +F: common/f2fs + +FSVERITY +L: fsverity@lists.linux.dev +S: Supported +F: common/verity + +FSCRYPT +L: linux-fscrypt@vger.kernel.org +S: Supported +F: common/encrypt + +FS-IDMAPPED +L: linux-fsdevel@vger.kernel.org +S: Supported +F: src/vfs/ + +NFS +L: linux-nfs@vger.kernel.org +S: Supported +F: tests/nfs/ +F: common/nfs + +OCFS2 +L: ocfs2-devel@oss.oracle.com +S: Supported +F: tests/ocfs2/ + +OVERLAYFS +L: linux-unionfs@vger.kernel.org +S: Supported +F: tests/overlay +F: common/overlay + +UDF +R: Jan Kara <jack@suse.com> +S: Supported +F: tests/udf/ + +XFS +L: linux-xfs@vger.kernel.org +S: Supported +F: common/dump +F: common/fuzzy +F: common/inject +F: common/populate +F: common/repair +F: common/xfs +F: tests/xfs/ + ALL M: Zorro Lang <zlang@kernel.org> L: fstests@vger.kernel.org
The fstests supports different kind of fs testing, better to cc specific fs mailing list for specific fs testing, to get better reviewing points. So record these mailing lists and files related with them in MAINTAINERS file. Signed-off-by: Zorro Lang <zlang@kernel.org> --- If someone mailing list doesn't want to be in cc list of related fstests patch, please reply this email, I'll remove that line. Or if I missed someone mailing list, please feel free to tell me. Thanks, Zorro MAINTAINERS | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+)